Fixed issue in all roles where AH_HOST was not being defaulted to if no variable set #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
added a commit
that referenced
this pull request
Feb 27, 2024
* Update pre-commit (#326) Co-authored-by: branic <branic@users.noreply.github.com> * Update pre-commit * Fix ansible-lint running against .py files (#332) * Fix ansible-lint running against .py files * Fix a pylint issue * Update description in the user role README (#333) Updated the one line description in the role. Co-authored-by: Sean Sullivan <ssulliva@redhat.com> * Fix version comparison (#337) fix #334 alternative implementarion for #335 * Update pre-commit (#338) Co-authored-by: branic <branic@users.noreply.github.com> * user: Fix password type field in README (#342) The `password` type was set to bool instead of str. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> * update repository roles (#343) Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com> * Update pre-commit (#344) Co-authored-by: branic <branic@users.noreply.github.com> * Fix wording to sync (#345) * Update pre-commit * Fix markdown tables (#349) Co-authored-by: Sean Sullivan <ssulliva@redhat.com> * Update pre-commit (#348) Co-authored-by: branic <branic@users.noreply.github.com> Co-authored-by: Sean Sullivan <ssulliva@redhat.com> * Update pre-commit * collection_remote: set sync_dependencies default to PAH default (#346) Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com> * Fix typo in ah_group_roles variable * Add branch specifics to Contributing guide (#360) * Fix documentation for validate_certs (#364) * Fixed issue in all roles where AH_HOST was not being defaulted to if no variable set (#363) * Fix documentation for group_roles role (#359) * Update pre-commit (#361) Co-authored-by: branic <branic@users.noreply.github.com> --------- Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: branic <branic@users.noreply.github.com> Co-authored-by: Tom Page <tpage@redhat.com> Co-authored-by: Richard J Osborne <20555769+rjo-uk@users.noreply.github.com> Co-authored-by: Bruno Rocha <rochacbruno@users.noreply.github.com> Co-authored-by: Dimitri Savineau <savineau.dimitri@gmail.com> Co-authored-by: David Danielsson <djdanielsson@users.noreply.github.com> Co-authored-by: dbk-rabel <57803476+dbk-rabel@users.noreply.github.com> Co-authored-by: Bram Mertens <bmertens@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Default omits the hostname option on the role so we fallback to the env var
How should this be tested?
Env var can be used.
We don't have any ENV var testing in the CI. Maybe we should...
Is there a relevant Issue open for this?
resolves #362
Other Relevant info, PRs, etc