Replies: 10 comments 32 replies
-
|
I have this bug #29708 which is not present in 4.0.2. |
Beta Was this translation helpful? Give feedback.
-
|
@sadpandajoe I looked through old PRs and I couldn't find one where this changed either 🤷 thanks for looking. I guess if someone figures it out in time we can revert, otherwise I'll just point people to that issue where the fix has been posted |
Beta Was this translation helpful? Give feedback.
-
|
It appears that this PR #28158 and commit 2d63722 removed the imports of [2d63722] superset/tasks/celery_app.py:L34-35
# Need to import late, as the celery_app will have been setup by "create_app()"
- # pylint: disable=wrong-import-position, unused-import
- from . import cache, scheduler # isort:skipThis can be fixed, as found above, by updating the config to explicitly import it. But, as there is no context to the removal of this line in the PR, I'm guessing it was not intended? |
Beta Was this translation helpful? Give feedback.
-
|
@mistercrunch I'm guessing this was probably just removed by accident by ruff as they were unused imports. I'll create a PR to address this. |
Beta Was this translation helpful? Give feedback.
-
|
Great find @wdav, I've created the PR: #29921 to address this. |
Beta Was this translation helpful? Give feedback.
-
|
Oh yes that has to be it. Sorry about that. |
Beta Was this translation helpful? Give feedback.
-
|
Hopefully, this bug #28145 can be merged. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I was using Python 3.8, not 3.9, which is not supported for the upgrade. So, I upgraded to the latest version 3.11. |
Beta Was this translation helpful? Give feedback.
-
|
@sadpandajoe, I tried using now a virtual venv with Python 3.10.2 and encountered the same error when checking "Query History": |
Beta Was this translation helpful? Give feedback.
-
|
Hi, will this be fixed in 4.1.0? |
Beta Was this translation helpful? Give feedback.
-
|
Doesn't look like the PR owner has made any updates to their PR. If it gets merged we can try to cherry it in, but I don't see this as a blocker as it's already happening as part of 4.0.2 for some users. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Please see below bugs. |
Beta Was this translation helpful? Give feedback.
-
|
thank you @iercan! |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Looks like we weren't able to reproduce the issue in #29729 so I wouldn't say this is a blocker for 4.1 until we can find something that is reproducible. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
thanks @michael-s-molina. I'll make sure I cherry this into the next RC |
Beta Was this translation helpful? Give feedback.
-
|
fixed with #29799 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I provided a fix here. |
Beta Was this translation helpful? Give feedback.
-
|
I think once the PR is merged, we can create RC2 and put it up for another vote. |
Beta Was this translation helpful? Give feedback.
-
|
#27416 also still persist with different error. I added comment on issue. |
Beta Was this translation helpful? Give feedback.
-
|
I don't think this is a blocker for 4.1 since it's happening in 3.1.1 and 4.0 |
Beta Was this translation helpful? Give feedback.
-
|
@eschutho could you push this pre-release |
Beta Was this translation helpful? Give feedback.
-
|
Since 4.1.0rc1 was downvoted, we'll push one up for rc2. |
Beta Was this translation helpful? Give feedback.
-
|
I'll work on creating a rc2 once #29860 is merged and put it up for another round of voting |
Beta Was this translation helpful? Give feedback.
-
|
@sadpandajoe please push this pre-release |
Beta Was this translation helpful? Give feedback.
-
|
@Habeeb556 It has been released 16 hours ago: https://github.com/apache/superset/releases/tag/4.1.0rc2 The discussion can be found here: #29999 |
Beta Was this translation helpful? Give feedback.
-
|
Yes I know, but I need it on PyPI, so I can |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
thanks @michael-s-molina for fixing this |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
will cherry in rc2 |
Beta Was this translation helpful? Give feedback.
-
|
In 4.1.0rc1 we are running into this issue which is not present on 4.1.0 nor on master: #29931 |
Beta Was this translation helpful? Give feedback.
-
|
@exolightor mind looking again when we cut rc2? 4.1.0rc1 didn't pass and it looks like we are waiting on a couple more fixes before we can cut RC2. |
Beta Was this translation helpful? Give feedback.
-
Hello Superset Community,
This is a call for the vote to release Apache Superset version 4.1.0.
The release candidate:
https://dist.apache.org/repos/dist/dev/superset/4.1.0rc1/
The Git tag for the release:
https://github.com/apache/superset/tree/4.1.0rc1
The CHANGELOG for the release:
https://github.com/apache/superset/blob/4.1.0rc1/CHANGELOG/4.1.0.md
The instructions for updating to the release:
https://github.com/apache/superset/blob/4.1.0rc1/UPDATING.md
Public keys are available at:
https://www.apache.org/dist/superset/KEYS
This discussion was created from the release 4.1.0rc1.
Beta Was this translation helpful? Give feedback.
All reactions