Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement EmptyState components #18676

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Conversation

kgabryje
Copy link
Member

SUMMARY

Implement "empty state" components, which will be used as:

  • chart placeholder in explore before query is run or query returns no results
  • data table placeholder in explore before query is run or query returns no results
  • placeholder in metrics/columns popovers in explore if there are no saved metrics/expressions in dataset
  • placeholders in dashboard edit mode when no element is added to dashboard
  • placeholder in native filters bar when there are no native filters added

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

image

image

TESTING INSTRUCTIONS

Take a look at storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #18676 (3d602d2) into master (7c69a1b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18676      +/-   ##
==========================================
- Coverage   66.30%   66.25%   -0.05%     
==========================================
  Files        1603     1604       +1     
  Lines       62772    62807      +35     
  Branches     6323     6333      +10     
==========================================
- Hits        41618    41613       -5     
- Misses      19502    19542      +40     
  Partials     1652     1652              
Flag Coverage Δ
javascript 51.20% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/components/EmptyState/index.tsx 0.00% <0.00%> (ø)
...frontend/src/SqlLab/components/SouthPane/index.tsx 63.33% <0.00%> (ø)
...ontend/src/SqlLab/components/QuerySearch/index.tsx 73.07% <0.00%> (ø)
...ntend/src/SqlLab/components/QueryHistory/index.tsx 50.00% <0.00%> (ø)
...legacy-preset-chart-deckgl/src/DeckGLContainer.jsx 0.00% <0.00%> (ø)
...src/dashboard/components/DeleteComponentButton.jsx
...rontend/src/SqlLab/components/QueryTable/index.jsx
...src/dashboard/components/DeleteComponentButton.tsx 100.00% <0.00%> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 68.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c69a1b...3d602d2. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit a7d505d into apache:master Feb 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants