fix(presto/trino): Ensure get_table_names only returns real tables #21794

john-bodley · 2022-10-13T04:27:23Z

SUMMARY

Like Presto, previously the "table" concept Trino represents both real tables and views which meant that there was overlap when fetching the combined table and view names. This was resolved by bumping the trino-presto-client which per the changelog includes a number of fixes I authored with addresses these shortcomings.

This PR remedies said issue and:

Cleans up the get_table_names and get_view_names docstrings
Deprecates the undocumented PRESTO_SPLIT_VIEWS_FROM_TABLES feature flag*
Cleans up Presto's integration tests

* This leverages learnings from the Trino changes where previously the implement for fetching views used the information_schema.views table which needs to compile the views as opposed to the information_schemas.tables with the appropriate filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added/updated the integration tests.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

john-bodley · 2022-10-13T04:41:38Z

superset/db_engine_specs/presto.py

    ) -> List[str]:
-        tables = super().get_table_names(database, inspector, schema)
-        if not is_feature_enabled("PRESTO_SPLIT_VIEWS_FROM_TABLES"):


I'm not quite sure why this undocumented feature flag existed. Why wouldn't one want to split views from tables as is the case with the other engine specifications.

When I added the feature at Lyft it would take 90 seconds to read all the views, so I thought it would be better to put it behind a feature flag.

Yikes. @betodealmeida I'm somewhat surprised that is the case as per Trino's definition of their get_table_names method (which differs from PyHive) it uses very similar logic as what you provided for the get_view_names. i.e., querying a table within the INFORMATION_SCHEMA schema however your method should be faster given that INFORMATION_SCHEMA.TABLES is a superset of INFORMATION_SCHEMA.VIEWS.

I wonder if the poor performance was related to when the schema was undefined? This functionally, i.e., fetching all tables/views across all schemas, was deprecated in #21284 given that the SQL Lab frontend no longer supports searching across all schemas, i.e., a schema must be defined.

john-bodley · 2022-10-13T04:43:55Z

tests/integration_tests/db_engine_specs/presto_tests.py

@@ -33,42 +33,29 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
    def test_get_datatype_presto(self):
        self.assertEqual("STRING", PrestoEngineSpec.get_datatype("string"))

-    def test_presto_get_view_names_return_empty_list(


I'm not sure what the purpose of this function was, i.e., the logic can be inferred.

john-bodley · 2022-10-13T04:46:35Z

tests/integration_tests/db_engine_specs/presto_tests.py

-        mock_get_table_names.return_value = table_names
-        mock_is_feature_enabled.return_value = True
-        tables = PrestoEngineSpec.get_table_names(mock.Mock(), mock.Mock(), None)
-        assert sorted(tables) == sorted(table_names)


This is where I'm puzzled. The result—["table1", "table2", "view1", "view2"]—is the same for test_get_table_names_no_split_views_from_tables and test_get_table_names_split_views_from_tables even though feature is disabled and enabled respectively. When the feature is enabled the result should be ["table1", "table2"], i.e., sans views.

john-bodley · 2022-10-13T04:51:40Z

superset/db_engine_specs/presto.py

    ) -> List[str]:
-        """Returns an empty list


Incorrect comment as it depended on state of the feature flag.

betodealmeida

Thanks, John!

betodealmeida · 2022-10-13T04:57:49Z

superset/db_engine_specs/presto.py

    ) -> List[str]:
-        tables = super().get_table_names(database, inspector, schema)
-        if not is_feature_enabled("PRESTO_SPLIT_VIEWS_FROM_TABLES"):


When I added the feature at Lyft it would take 90 seconds to read all the views, so I thought it would be better to put it behind a feature flag.

codecov · 2022-10-13T05:00:15Z

Codecov Report

Merging #21794 (ca3553e) into master (4496748) will decrease coverage by 11.49%.
The diff coverage is 28.57%.

❗ Current head ca3553e differs from pull request most recent head 87b9879. Consider uploading reports for the commit 87b9879 to get more accurate results

@@             Coverage Diff             @@
##           master   #21794       +/-   ##
===========================================
- Coverage   67.12%   55.62%   -11.50%     
===========================================
  Files        1818     1818               
  Lines       69639    69632        -7     
  Branches     7496     7496               
===========================================
- Hits        46747    38735     -8012     
- Misses      20954    28959     +8005     
  Partials     1938     1938

Flag	Coverage Δ
hive	`?`
mysql	`?`
postgres	`?`
presto	`52.74% <28.57%> (+0.01%)`	⬆️
python	`57.69% <28.57%> (-23.88%)`	⬇️
sqlite	`?`
unit	`51.21% <28.57%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/base.py	`74.25% <ø> (-14.92%)`	⬇️
superset/db_engine_specs/databricks.py	`77.27% <ø> (ø)`
superset/db_engine_specs/presto.py	`40.70% <20.00%> (-47.08%)`	⬇️
superset/databases/api.py	`52.30% <50.00%> (-41.24%)`	⬇️
superset/utils/dashboard_import_export.py	`0.00% <0.00%> (-100.00%)`	⬇️
superset/tags/core.py	`4.54% <0.00%> (-95.46%)`	⬇️
superset/key_value/commands/update.py	`0.00% <0.00%> (-90.91%)`	⬇️
superset/key_value/commands/delete.py	`0.00% <0.00%> (-87.88%)`	⬇️
superset/db_engines/hive.py	`0.00% <0.00%> (-85.19%)`	⬇️
superset/key_value/commands/delete_expired.py	`0.00% <0.00%> (-84.00%)`	⬇️
... and 288 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

john-bodley · 2022-10-13T05:55:23Z

superset/db_engine_specs/databricks.py

@@ -96,16 +94,3 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
        }
        extra.update(BaseEngineSpec.get_extra_params(database))
        return extra
-
-    @classmethod


This is the same as the base class and thus it's not needed.

john-bodley · 2022-11-09T16:11:25Z

requirements/testing.txt

 statsd==3.3.0
    # via -r requirements/testing.in
-trino==0.315.0
+trino==0.319.0


The result of running pip-compile-multi --no-upgrade.

…pache#21794)

(cherry picked from commit 0b31b2c)

* feat: add ssh tunneling to dynamic form for Database Connection UI (apache#22689) Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * chore(dashboard): Log events for download as image (apache#22793) * docs: link docker readme in docker config section (apache#22796) * chore: Add explicit bidirectional performant relationships for SQLA model (apache#22413) * fix: better logic to extract errors on databricks (apache#22792) * fix(hive): Regression in apache#21794 (apache#22794) * fix: Unexpected error on simple filter (apache#22814) * feat(docker): Build multiple python version images (apache#22770) Co-authored-by: Daniel Draper <daniel.draper@understand.ai> * fix: allow CSV upload in Other db (apache#22807) * chore: Convert direct uses of antd icons to 'Icons' component (apache#22516) * fix(sqllab): type error on renderBigIntStr (apache#22813) * chore: upgrade react-datetime, react-intersection-observer and react-checkbox-tree (apache#22585) * feat(helm): Add ability to customize affinity per deployment (apache#22827) * chore(issue templates): discouraging Issues for feature requests (apache#22617) * docs(alerts & reports): add, prune, reorganize (apache#20872) * chore(tests): Streamline Cypress login to fix fails/flakes (apache#22844) * feat: export/import `allow_dml` flag (apache#22806) * chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (apache#22789) * test: Fix act errors in DatasourceControl test (apache#22845) * test: Fix act errors in DatabaseModal test (apache#22846) * feat: Move cross filters to Dashboard (apache#22785) * fix(cpq): Add `schema` to Query.data() payload (apache#22791) * fix(Annotation Layers): Error when render options with renamed columns (apache#22453) * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.48.2 to 5.49.0 in /superset-websocket (apache#22838) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(misc): Spelling (apache#19678) Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /docs (apache#22858) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(cache): update doc strings (apache#22865) * chore: migrate react-diff-viewer to react-diff-viewer-continued for react 18 upgrade (apache#22834) * chore: upgrade react-table for react 18 upgrade (apache#22780) * chore: upgrade react-reverse-portal for react upgrade (apache#22779) * chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (apache#22852) * fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (apache#22872) * fix(sqllab): reverts apache#22695 (apache#22861) * feat(ssh_tunnel): Add feature flag to SSH Tunnel API (apache#22805) * fix: revert RESTful apis and react view for RLS (apache#22818) * chore: deprecate /superset/slice_json/<int:slice_id> and /superset/annotation_json/<int:layer_id> (apache#22496) * chore: add statsd support to base API and refactor (apache#22887) * chore: Migrate /superset/queries/<last_updated_ms> to API v1 (apache#22611) * docs: add Skyscanner to users list (apache#22888) Co-authored-by: Calum <calum.leslie@skyscanner.net> * feat: Add excel export (apache#22006) Co-authored-by: Igor Șincariov <igorsinc@pm.me> Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com> * build(deps): bump moment from 2.29.2 to 2.29.4 in /docs (apache#22891) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump underscore from 1.12.0 to 1.12.1 in /superset-frontend (apache#22892) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: deprecate /superset/filter/... endpoint, migrate to apiv1 (apache#22882) * fix: bump isort to fix pre-commit CI (apache#22907) * chore: migrate /sql_json and /results to apiv1 (apache#22809) * chore: Localization of superset pt. 2 (apache#22772) * fix: edit pyarrow stringify to better handle emojis and accents (apache#22881) * fix(sqllab): inconsistent addNewQueryEditor behavior (apache#21999) * fix(i18n): greatly optimize Chinese translation (apache#22036) * chore: skip puppeteer chromium download (apache#22623) * fix(dependency): update cryptography import (apache#22744) Co-authored-by: Daniel Draper <daniel.draper@understand.ai> * feat: add pyproject.toml file to project (apache#20291) * chore(db_engine_specs): clean up column spec logic and add tests (apache#22871) * feat: Adds the ECharts Sunburst chart (apache#22833) * fix: Time range filter applied on a dashboard is not persisting to the chart explore (apache#22920) * fix(fab): Fix regression on FAB dropdowns (apache#22889) * chore: migrate @vx/responsive to @visx/responsive for react 18 upgrade (apache#22815) * fix: fix warning in ssh tunnel (apache#22912) * chore: upgrade packages for react v17 upgrade (apache#22914) * chore: upgrade react-router-dom to 5.3.4 (apache#22878) * build(deps-dev): bump eslint from 8.32.0 to 8.33.0 in /superset-websocket (apache#22902) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(helm): Make Chart.AppVersion default value for image tag (apache#22854) * chore: Migrate /superset/tables/* to API v1 (apache#22501) * fix(native-filters): Ensure that time range filter loses focus after closing modal (apache#22937) * fix: Remove button is broken for metrics on Explore (apache#22940) * feat: Enable new dataset creation flow II (apache#22835) * fix(datasets): Fix property selection on JSON response (apache#22944) * fix: Improve performance of CSV download (apache#22929) * test: Clean up AdhocFilterOption test warnings (apache#22915) * chore: Bump Flask-AppBuilder constraints (apache#22927) * chore(welcome): change default last tab to "all" (apache#22798) * fix(explore): Time comparison in Mixed Chart in GENERIC_CHART_AXES not working (apache#22945) * chore(superset-ui-chart-controls): refactor pivot and rename operator (apache#22963) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend (apache#22958) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): unable to update linked charts (apache#22896) * chore(frontend): Spelling (apache#19676) Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> * chore: add waitress for win32 platform (apache#22935) * fix(datasets): Include expression and description in duplicated dataset columns (apache#22943) * feat: add tabs to edit dataset page (apache#22043) Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com> * docs: add Caizin to the user list (apache#22961) * test: Fix act errors in DatabaseList test (apache#22970) * test: Clean up QueryList test warnings (apache#22972) * fix(native-filters): Don't include description icon in truncation calc (apache#22941) * fix: Prevents last temporal filter removal (apache#22982) * fix(explore): Mark time range dashboard filter with warning icon (apache#22984) * docs(alerts & reports): clarify nature of "-dev" labeled container images (apache#22988) * chore: bump python version to 3.8.16 in Dockerfile (apache#22934) * fix: Form data was not being passed to save/update slice (apache#22989) * feat(ssh_tunnel): SSH Tunnel Switch extension (apache#22967) * chore: Fix grammar (apache#22831) * docs: added Orange inside the inthewild.md doc (apache#22986) * fix: add new config to allow for specific import data urls (apache#22942) * build(deps): bump pre-commit from 2.20.0 to 3.0.4 in /requirements (apache#22996) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): Save button incorrectly disabled when adding new metric with dnd (apache#23000) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs (apache#22956) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Make cte_alias a property of db engine spec (apache#22947) * fix(migrations): Flask-Migrate output is not logged during alembic migrations apache#17991 (apache#22991) * fix(dashboard): export & import chart description and certification details (apache#22471) * chore: updating link to sandbox.js (apache#23005) * fix(sqllab): clean unwanted scrollbar (apache#22990) * chore: Localization of superset pt. 3 (apache#22938) Co-authored-by: Evan Rusackas <evan@preset.io> * chore(deps): bump ajv and react-jsonschema-form in /superset-frontend (apache#21809) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.6.0 in /superset-websocket (apache#22767) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend/cypress-base (apache#22955) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.13 to 18.11.19 in /superset-websocket (apache#22997) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(datasets): Populate Usage tab in Edit Dataset view (apache#22670) * build(deps-dev): bump @typescript-eslint/parser from 5.48.1 to 5.51.0 in /superset-websocket (apache#23013) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump typescript from 4.9.4 to 4.9.5 in /superset-websocket (apache#22933) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(tests): Cypress optimizations to help with fails (apache#23023) * chore: refactor SliceAdder for react 17 and react 18 (apache#23009) * fix(explore): Enable saving metric after changing title (apache#23020) * fix: dataset import error message (apache#23025) * fix(ssh_tunnel): Fix bug on database edition for databases with ssh tunnels (apache#23006) Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * fix: Handles disabled options on Select All (apache#22830) * fix(dashboard): Stop updating chart owners for charts removed from dashboard (apache#21720) Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> * docs(teradata): fix connection string (apache#23051) * fix: Time Column on Generic X-axis (apache#23021) * fix: Menu items are not disappearing when deleting a dashboard (apache#23039) * fix(i18n): improve Russian translation (apache#22939) * fix(sqllab): Invalid schema fetch by deprecated value (apache#22968) * chore: Removes icon warnings from tests (apache#23054) * feat(sqllab): Add event logger (apache#23040) * chore(datasets): Refactor DatasetDAO update to leverage bulk logic for create, update, and delete operations (apache#22957) * chore: remove db_engines (apache#22444) * feat(helm): allow persisting nodePort for services (apache#22713) Signed-off-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Co-authored-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.49.0 to 5.52.0 in /superset-websocket (apache#23073) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump hot-shots from 9.3.0 to 10.0.0 in /superset-websocket (apache#23031) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump prettier from 2.8.3 to 2.8.4 in /superset-websocket (apache#23030) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.19 to 18.13.0 in /superset-websocket (apache#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: cache warmup solution non legacy charts. (apache#23012) * docs: remove duplicate navbar item (apache#22486) Signed-off-by: tison <wander4096@gmail.com> * chore: Migrate get_or_create_table endpoint to api v1 (apache#22931) * chore: Migrate /superset/csv/<client_id> to API v1 (apache#22913) * fix: css template permissions for gamma role (apache#23083) * build(deps): bump ws from 8.12.0 to 8.12.1 in /superset-websocket (apache#23080) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.33.0 to 8.34.0 in /superset-websocket (apache#23079) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(style): make brand icon max width customizable (apache#23081) * chore: Remove dependency warnings from SqlEditorLeftBar/index.tsx (apache#22975) * chore: Remove dependency warnings from SqlEditor/index.jsx (apache#22974) * chore: Remove dependency warnings from DatasetList.tsx (apache#22973) * test: Convert DatasetList test from jsx to tsx (apache#22971) * test: Clean up SelectAsyncControl test warnings (apache#22969) * chore: move dashboard screenshot standalone logic (apache#23003) * fix: dict bug on QueryContextFactory (apache#23093) Co-authored-by: ok9897 <ok9897@krafton.com> * chore: Improve greeting message (apache#23077) * chore: Updating connection URI for MS SQL Server (apache#22903) Co-authored-by: Evan Rusackas <evan@preset.io> * chore: increment statsd as warn (apache#23041) * fix: removing pyproject.toml (apache#23101) * chore: change AlertQueryError to 400 (apache#23102) * fix: missing __init__ on module sqllab commands (apache#23107) * #21 preparing for linux deployment * chore(backend): Spelling (apache#19677) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io> * chore: Remove yarn.lock from the root folder (apache#23108) * chore(sqla): Address performance tradeoff with eager loading (apache#23113) * fix(ci): explicity set yaml Loader (apache#23126) * fix: Validate jinja rendered query (apache#22851) * fix: reorganize role permissions (apache#23096) * fix: gamma sql_json test (apache#23135) * fix(dashboard): Chart's empty state not centered (apache#23022) * feat: Frontend tagging (apache#20876) Co-authored-by: cccs-nik <68961854+cccs-nik@users.noreply.github.com> Co-authored-by: GITHUB_USERNAME <EMAIL> * feat: return UUID on database creation (apache#23143) * chore: Add docs for ssh tunneling (apache#23131) Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * feat: Enable cross fitlers in WorldMap and Graph charts (apache#22886) * chore: Bump cryptography to 39.0.1 (apache#23158) * feat(dashboard): Add cross filter from context menu (apache#23141) * chore: revert "feat(native_filter_migration): add transition mode (apache#16992)" (apache#23144) * build: Add helm chart option to deploy sidecars with node and worker (apache#23160) * fix(rbac): show objects accessible by database access perm (apache#23118) * fix: bump FAB to 4.3.0 (apache#23184) * fix(clickhouse): add clickhouse connect driver (apache#23185) * fix(clickhouse): add missing default format (apache#23192) * feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials (apache#23099) * chore: refactor SparklineCell for react 17 and react 18 upgrade (apache#23145) * fix(ssh_tunnel): Display SSHTunnel Switch when editing a DB that was created with the Dynamic Form (apache#23195) * fix(sshtunnel): argument params to properly setting `server_port` (apache#23196) * fix(ssh-tunnel): add password to `from_private_key` function (apache#23175) * fix: Pagination of VirtualTable (apache#23130) * fix(dashboard): Focusing charts and native filters from filters badge (apache#23190) * fix(docs): Change postgres to postgresql in brew install command (apache#23202) * build(deps-dev): bump @typescript-eslint/parser from 5.51.0 to 5.53.0 in /superset-websocket (apache#23133) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.13.0 to 18.14.1 in /superset-websocket (apache#23180) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: Remove test playgrounds (apache#23203) * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.52.0 to 5.53.0 in /superset-websocket (apache#23132) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump express and @applitools/eyes-cypress in /superset-frontend/cypress-base (apache#22342) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix typo (apache#23207) * feat: Cross Filters in FilterBar (apache#23138) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix(dashboard): Page crashing when cross filter applied on adhoc column (apache#23215) * fix: memoized decorator memory leak (apache#23139) * build(deps-dev): bump @types/uuid from 9.0.0 to 9.0.1 in /superset-websocket (apache#23152) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.34.0 to 8.35.0 in /superset-websocket (apache#23211) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: adding code owners for github actions/workflows (apache#23201) * build(deps): bump ua-parser-js from 0.7.28 to 0.7.33 in /superset-frontend (apache#22859) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump pre-commit from 3.0.4 to 3.1.0 in /requirements (apache#23168) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: add disallowed query params for engines specs (apache#23217) Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * chore: Add statsd logger for ssh tunneling creation (apache#23225) * fix(dashboard): Don't show cross filters checkbox to users without write permissions (apache#23237) * docs: update installation docs to include frontend asset build (apache#23199) * build(deps): bump pip-compile-multi from 2.6.1 to 2.6.2 in /requirements (apache#23122) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(dashboard): Cross-filters not working properly for new dashboards (apache#23194) * fix: refuse to start with default secret on non debug envs (apache#23186) * fix(dao): use explicit id filter (apache#23246) * fix(explore): Dashboard filters on adhoc cols not working in Explore (apache#23239) * refactor: Organizes the pages in their own folder (apache#23241) * fix: Video Game Sales dashboard default filters (apache#23242) * chore: Deprecate show_native_filters (apache#23228) * chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled (apache#23142) * fix(dashboard): Cross-filter search icon in filter bar (apache#23250) * chore(webdriver): Tuning the Webdriver logging a bit (apache#23255) * fix: customize tab on heatmap chart is blank (apache#23243) * fix(dashboard): Missing filter card styles (apache#23256) * fix: ignore ts warnings from older typescript versions (apache#23262) * chore(cache): Tuning logging in cache manager (apache#23266) * fix(dashboard): Charts crashing when cross filter on adhoc column is applied (apache#23238) Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * fix(plugin-chart-echarts): render horizontal categories from top (apache#23273) * feat(generic-x-axis): add x sorting on series limit metric (apache#23274) * fix(dashboard): Allow selecting text in cells in Table and PivotTable without triggering cross filters (apache#23283) * fix(migration): Address issue in apache#23228 (apache#23276) * chore(dashboard): Cleanup example dashboard filter scopes (apache#23260) * fix(dashboard): Infinite load when filter with default first value is out of scope (apache#23299) * fix(clickhouse): Update to working clickhouse-connect version (apache#23296) * chore: upgrade @ant-design/icons for react upgrade (apache#22890) * docs: typo 'admnistrators' in security.mdx (apache#23166) * build(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 in /superset-websocket (apache#23292) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.14.1 to 18.14.6 in /superset-websocket (apache#23281) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump docusaurus to latest stable (apache#23317) * docs: add lost _filters param docs (apache#23316) * feat(docs): adds BugHerd to documentation site. (apache#23287) * chore: log different selenium timeout errors differently (apache#23290) * docs: improve API v1 migration documentation (apache#23298) * docs(alerts and reports): Update ExecutorType class (apache#23323) * build(deps-dev): bump @typescript-eslint/parser from 5.53.0 to 5.54.1 in /superset-websocket (apache#23294) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(dashboard): Refactor FiltersBadge (apache#23286) * chore: use util test env for init check (apache#23325) * fix(trino): normalize non-iso timestamps (apache#23339) * fix(dashboard): Cross filters with time shifted series (apache#23347) * feat(dashboard): Change default opacity of icon in FiltersBadge (apache#23350) * fix: dashboard DAO small code improvement (apache#23348) * chore: Remove Cross Filter scoping modal (apache#23216) * fix(dashboard): deepmerge htmlSchemaOverrides (apache#23329) * fix(trino): Disallow alias to source column (apache#23324) * fix(examples): Cleanup granularity_sqla column (apache#23322) * fix(sqllab): empty large query results from localStorage (apache#23302) * chore: Update pre-commit packages (apache#23173) * fix(safari): remove autocomplete in table select (apache#23361) * fix(chart-controls): Error if x_axis_sort and timeseries_limit_metric are included in main metrics (apache#23365) * feat(native-filters): allow cascading from time and numeric filters (apache#23319) * build(deps-dev): bump @types/node from 18.14.6 to 18.15.3 in /superset-websocket (apache#23360) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(native-filters): Caching scope (apache#23314) * #56 sync to fix security issues --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Daniel Draper <Germandrummer92@gmail.com> Co-authored-by: Daniel Draper <daniel.draper@understand.ai> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Cody Leff <cody@preset.io> Co-authored-by: Lily Kuang <lily@preset.io> Co-authored-by: Sergey Shevchenko <sergeyshevchdevelop@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: Jack Fragassi <jfragassi98@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Cemre Mengu <cemremengu@gmail.com> Co-authored-by: Mayur <mayurnewase111@gmail.com> Co-authored-by: Diego Medina <diegomedina24@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: cleslie <cjaleslie@gmail.com> Co-authored-by: Calum <calum.leslie@skyscanner.net> Co-authored-by: Igor Șincariov <102555782+igorsinc@users.noreply.github.com> Co-authored-by: Igor Șincariov <igorsinc@pm.me> Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com> Co-authored-by: Artem Shumeiko <53895552+artemonsh@users.noreply.github.com> Co-authored-by: 王一川 <wj2247689442@gmail.com> Co-authored-by: nisheldo <njsheldon@me.com> Co-authored-by: Leo Schick <67712864+leo-schick@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Denis Krivenko <dnskrv88@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com> Co-authored-by: tejaskatariya <42517374+tejaskatariya@users.noreply.github.com> Co-authored-by: Adrian <icsu@users.noreply.github.com> Co-authored-by: alexclavel-ocient <111374753+alexclavel-ocient@users.noreply.github.com> Co-authored-by: Trey Gilliland <treygilliland3@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Rajan Gupta <rajan0493@gmail.com> Co-authored-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Co-authored-by: Dheeraj Jaiswal <118437694+dheeraj-jaiswal-lowes@users.noreply.github.com> Co-authored-by: tison <wander4096@gmail.com> Co-authored-by: Changhoon Oh <81631424+okayhooni@users.noreply.github.com> Co-authored-by: ok9897 <ok9897@krafton.com> Co-authored-by: kuruv <kuruv@users.noreply.github.com> Co-authored-by: Zef Lin <zef@preset.io> Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> Co-authored-by: cccs-nik <68961854+cccs-nik@users.noreply.github.com> Co-authored-by: mkramer5454 <52328004+mkramer5454@users.noreply.github.com> Co-authored-by: Vivek Kumar <49686162+vivekDebugs@users.noreply.github.com> Co-authored-by: Craig Rueda <craig@craigrueda.com> Co-authored-by: Geoff Genz <geoff@clickhouse.com> Co-authored-by: Cameron Gregor <cgregor@securecodewarrior.com> Co-authored-by: Íñigo Álvaro Sáenz <i.saenz@stuart.com>

* feat: add ssh tunneling to dynamic form for Database Connection UI (apache#22689) Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * chore(dashboard): Log events for download as image (apache#22793) * docs: link docker readme in docker config section (apache#22796) * chore: Add explicit bidirectional performant relationships for SQLA model (apache#22413) * fix: better logic to extract errors on databricks (apache#22792) * fix(hive): Regression in apache#21794 (apache#22794) * fix: Unexpected error on simple filter (apache#22814) * feat(docker): Build multiple python version images (apache#22770) Co-authored-by: Daniel Draper <daniel.draper@understand.ai> * fix: allow CSV upload in Other db (apache#22807) * chore: Convert direct uses of antd icons to 'Icons' component (apache#22516) * fix(sqllab): type error on renderBigIntStr (apache#22813) * chore: upgrade react-datetime, react-intersection-observer and react-checkbox-tree (apache#22585) * feat(helm): Add ability to customize affinity per deployment (apache#22827) * chore(issue templates): discouraging Issues for feature requests (apache#22617) * docs(alerts & reports): add, prune, reorganize (apache#20872) * chore(tests): Streamline Cypress login to fix fails/flakes (apache#22844) * feat: export/import `allow_dml` flag (apache#22806) * chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (apache#22789) * test: Fix act errors in DatasourceControl test (apache#22845) * test: Fix act errors in DatabaseModal test (apache#22846) * feat: Move cross filters to Dashboard (apache#22785) * fix(cpq): Add `schema` to Query.data() payload (apache#22791) * fix(Annotation Layers): Error when render options with renamed columns (apache#22453) * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.48.2 to 5.49.0 in /superset-websocket (apache#22838) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(misc): Spelling (apache#19678) Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> * build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /docs (apache#22858) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(cache): update doc strings (apache#22865) * chore: migrate react-diff-viewer to react-diff-viewer-continued for react 18 upgrade (apache#22834) * chore: upgrade react-table for react 18 upgrade (apache#22780) * chore: upgrade react-reverse-portal for react upgrade (apache#22779) * chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (apache#22852) * fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (apache#22872) * fix(sqllab): reverts apache#22695 (apache#22861) * feat(ssh_tunnel): Add feature flag to SSH Tunnel API (apache#22805) * fix: revert RESTful apis and react view for RLS (apache#22818) * chore: deprecate /superset/slice_json/<int:slice_id> and /superset/annotation_json/<int:layer_id> (apache#22496) * chore: add statsd support to base API and refactor (apache#22887) * chore: Migrate /superset/queries/<last_updated_ms> to API v1 (apache#22611) * docs: add Skyscanner to users list (apache#22888) Co-authored-by: Calum <calum.leslie@skyscanner.net> * feat: Add excel export (apache#22006) Co-authored-by: Igor Șincariov <igorsinc@pm.me> Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com> * build(deps): bump moment from 2.29.2 to 2.29.4 in /docs (apache#22891) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump underscore from 1.12.0 to 1.12.1 in /superset-frontend (apache#22892) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: deprecate /superset/filter/... endpoint, migrate to apiv1 (apache#22882) * fix: bump isort to fix pre-commit CI (apache#22907) * chore: migrate /sql_json and /results to apiv1 (apache#22809) * chore: Localization of superset pt. 2 (apache#22772) * fix: edit pyarrow stringify to better handle emojis and accents (apache#22881) * fix(sqllab): inconsistent addNewQueryEditor behavior (apache#21999) * fix(i18n): greatly optimize Chinese translation (apache#22036) * chore: skip puppeteer chromium download (apache#22623) * fix(dependency): update cryptography import (apache#22744) Co-authored-by: Daniel Draper <daniel.draper@understand.ai> * feat: add pyproject.toml file to project (apache#20291) * chore(db_engine_specs): clean up column spec logic and add tests (apache#22871) * feat: Adds the ECharts Sunburst chart (apache#22833) * fix: Time range filter applied on a dashboard is not persisting to the chart explore (apache#22920) * fix(fab): Fix regression on FAB dropdowns (apache#22889) * chore: migrate @vx/responsive to @visx/responsive for react 18 upgrade (apache#22815) * fix: fix warning in ssh tunnel (apache#22912) * chore: upgrade packages for react v17 upgrade (apache#22914) * chore: upgrade react-router-dom to 5.3.4 (apache#22878) * build(deps-dev): bump eslint from 8.32.0 to 8.33.0 in /superset-websocket (apache#22902) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(helm): Make Chart.AppVersion default value for image tag (apache#22854) * chore: Migrate /superset/tables/* to API v1 (apache#22501) * fix(native-filters): Ensure that time range filter loses focus after closing modal (apache#22937) * fix: Remove button is broken for metrics on Explore (apache#22940) * feat: Enable new dataset creation flow II (apache#22835) * fix(datasets): Fix property selection on JSON response (apache#22944) * fix: Improve performance of CSV download (apache#22929) * test: Clean up AdhocFilterOption test warnings (apache#22915) * chore: Bump Flask-AppBuilder constraints (apache#22927) * chore(welcome): change default last tab to "all" (apache#22798) * fix(explore): Time comparison in Mixed Chart in GENERIC_CHART_AXES not working (apache#22945) * chore(superset-ui-chart-controls): refactor pivot and rename operator (apache#22963) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend (apache#22958) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): unable to update linked charts (apache#22896) * chore(frontend): Spelling (apache#19676) Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> * chore: add waitress for win32 platform (apache#22935) * fix(datasets): Include expression and description in duplicated dataset columns (apache#22943) * feat: add tabs to edit dataset page (apache#22043) Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com> * docs: add Caizin to the user list (apache#22961) * test: Fix act errors in DatabaseList test (apache#22970) * test: Clean up QueryList test warnings (apache#22972) * fix(native-filters): Don't include description icon in truncation calc (apache#22941) * fix: Prevents last temporal filter removal (apache#22982) * fix(explore): Mark time range dashboard filter with warning icon (apache#22984) * docs(alerts & reports): clarify nature of "-dev" labeled container images (apache#22988) * chore: bump python version to 3.8.16 in Dockerfile (apache#22934) * fix: Form data was not being passed to save/update slice (apache#22989) * feat(ssh_tunnel): SSH Tunnel Switch extension (apache#22967) * chore: Fix grammar (apache#22831) * docs: added Orange inside the inthewild.md doc (apache#22986) * fix: add new config to allow for specific import data urls (apache#22942) * build(deps): bump pre-commit from 2.20.0 to 3.0.4 in /requirements (apache#22996) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(explore): Save button incorrectly disabled when adding new metric with dnd (apache#23000) * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs (apache#22956) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Make cte_alias a property of db engine spec (apache#22947) * fix(migrations): Flask-Migrate output is not logged during alembic migrations apache#17991 (apache#22991) * fix(dashboard): export & import chart description and certification details (apache#22471) * chore: updating link to sandbox.js (apache#23005) * fix(sqllab): clean unwanted scrollbar (apache#22990) * chore: Localization of superset pt. 3 (apache#22938) Co-authored-by: Evan Rusackas <evan@preset.io> * chore(deps): bump ajv and react-jsonschema-form in /superset-frontend (apache#21809) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint-config-prettier from 7.2.0 to 8.6.0 in /superset-websocket (apache#22767) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /superset-frontend/cypress-base (apache#22955) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.13 to 18.11.19 in /superset-websocket (apache#22997) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(datasets): Populate Usage tab in Edit Dataset view (apache#22670) * build(deps-dev): bump @typescript-eslint/parser from 5.48.1 to 5.51.0 in /superset-websocket (apache#23013) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump typescript from 4.9.4 to 4.9.5 in /superset-websocket (apache#22933) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(tests): Cypress optimizations to help with fails (apache#23023) * chore: refactor SliceAdder for react 17 and react 18 (apache#23009) * fix(explore): Enable saving metric after changing title (apache#23020) * fix: dataset import error message (apache#23025) * fix(ssh_tunnel): Fix bug on database edition for databases with ssh tunnels (apache#23006) Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> * fix: Handles disabled options on Select All (apache#22830) * fix(dashboard): Stop updating chart owners for charts removed from dashboard (apache#21720) Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> * docs(teradata): fix connection string (apache#23051) * fix: Time Column on Generic X-axis (apache#23021) * fix: Menu items are not disappearing when deleting a dashboard (apache#23039) * fix(i18n): improve Russian translation (apache#22939) * fix(sqllab): Invalid schema fetch by deprecated value (apache#22968) * chore: Removes icon warnings from tests (apache#23054) * feat(sqllab): Add event logger (apache#23040) * chore(datasets): Refactor DatasetDAO update to leverage bulk logic for create, update, and delete operations (apache#22957) * chore: remove db_engines (apache#22444) * feat(helm): allow persisting nodePort for services (apache#22713) Signed-off-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Co-authored-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> * build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.49.0 to 5.52.0 in /superset-websocket (apache#23073) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump hot-shots from 9.3.0 to 10.0.0 in /superset-websocket (apache#23031) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump prettier from 2.8.3 to 2.8.4 in /superset-websocket (apache#23030) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump @types/node from 18.11.19 to 18.13.0 in /superset-websocket (apache#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: cache warmup solution non legacy charts. (apache#23012) * docs: remove duplicate navbar item (apache#22486) Signed-off-by: tison <wander4096@gmail.com> * chore: Migrate get_or_create_table endpoint to api v1 (apache#22931) * chore: Migrate /superset/csv/<client_id> to API v1 (apache#22913) * fix: css template permissions for gamma role (apache#23083) * build(deps): bump ws from 8.12.0 to 8.12.1 in /superset-websocket (apache#23080) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump eslint from 8.33.0 to 8.34.0 in /superset-websocket (apache#23079) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(style): make brand icon max width customizable (apache#23081) * chore: Remove dependency warnings from SqlEditorLeftBar/index.tsx (apache#22975) * chore: Remove dependency warnings from SqlEditor/index.jsx (apache#22974) * chore: Remove dependency warnings from DatasetList.tsx (apache#22973) * test: Convert DatasetList test from jsx to tsx (apache#22971) * test: Clean up SelectAsyncControl test warnings (apache#22969) * chore: move dashboard screenshot standalone logic (apache#23003) * fix: dict bug on QueryContextFactory (apache#23093) Co-authored-by: ok9897 <ok9897@krafton.com> * chore: Improve greeting message (apache#23077) * chore: Updating connection URI for MS SQL Server (apache#22903) Co-authored-by: Evan Rusackas <evan@preset.io> * chore: increment statsd as warn (apache#23041) * fix: removing pyproject.toml (apache#23101) * chore: change AlertQueryError to 400 (apache#23102) * fix: missing __init__ on module sqllab commands (apache#23107) * updating package json * post merge fixes * [cccs-2.0] updating docker file (#188) * [CLDN-1565] Fixing bugs (#189) * [CLDN-1565] Fixing bugs * removing uneeded import * Feature/cldn 1565 (#192) * [CLDN-1565] Fixing bugs * removing uneeded import * [CLDN-1565] Adding new image * Feature/cldn 1609 (#195) * Add row number option to CCCS-Grid (#181) * Add row number option to CCCS-Grid * Have row numbers show by default Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * Use new build agent (#187) * Use new build agent * Remove quotes * Display datahub link for datasets with defined URN (#177) * Display datahub link for datasets with defined URN * Add datahub SVG * Reorder imports * Add datahub link to dashboards * Convert to camel case * Add tests for DatasetList * Add tests for dashboard header * Provide explanation for empty catch * [CLDN-1540] Added ability for multiple user emails to be filtered on at once * [CLDN-1540] temp update to docker image tag so that we can deploy code changes to PB-stg * [CLDN-1540] revert of temp update to docker image tag so that we can deploy code changes to PB-stg * Add path to url (#193) * [CLDN-1609] Fixing post merge build errors * Update cccs-build/superset-base/azure-pipelines.yml Co-authored-by: Reese <10563996+reesercollins@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-at-a-glance-user-id/src/styles.js Co-authored-by: Reese <10563996+reesercollins@users.noreply.github.com> Co-authored-by: Reese <10563996+reesercollins@users.noreply.github.com> Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * [CLDN-1609] Updating image (#196) * [CLDN-1620] Making rendering use advanced type (#197) * updating image (#198) * [CLDN-1609] Fixing all QA bugs (#201) * [CLDN-1609] Fixing all QA bugs * [CLDN-1609] Fixing build errors * [CLDN-1609] adding additional fixes * [CLDN-1609] Removing log files * [CLDN-1609] Fixing build error Co-authored-by: reesercollins <10563996+reesercollins@users.noreply.github.com> * Feature/cldn 1541 (#200) * [CLDN-1541] Added the ability to filter on multiple user ID's and IP's at the same time in the Application Links custom viz * Temp update to image for deploying to PB-stg * Reverting change to image * [CLDN-1541] Added a tooltip to the Alfred icon * Temp update to base image * Reverting temporary change to image tag * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-application-links/src/ApplicationLinks.tsx Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-application-links/src/ApplicationLinks.tsx Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * [CLDN-1541] Changed the logic around creating the proper links/URL * Temp update to img * Undo temp img change Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * [CLDN-1609] Updating docker image (#202) * [cccs-2.0] Fixing case sensitivity (#203) * [cccs-2.0] Fixing case sensitivity * [cccs-2.0] Pusing temp image * [cccs-2.0] fixing two order bys * [cccs-2.0] fixing verbose names, fixing sizing, fixing ordering * [cccs-2.0] fixing build error * [cccs-2.0] updating image * [cccs-2.0] fixing time columns * [cccs-2.0] Fixing build errors * [cccs-2.0] updating docker file * [cccs-2.0] Fixing time column to populate default time col * Fixing default time col * [cccs-2.0] updating image * Fix issue where datasets without a date/datetime column would not load in the explore view * Time column dropdown list is now properly populated with either the default temporal column, or the first temporal column (if a default is not set) * Temp update to base image tag * Fixed the bug where when there are no dttm columns, the non-dttm columns were being displayed * Temp update to base image tag * Reverting changes to the img Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * Fix/cccs 2.0 (#204) * [cccs-2.0] Fixing case sensitivity * [cccs-2.0] Pusing temp image * [cccs-2.0] fixing two order bys * [cccs-2.0] fixing verbose names, fixing sizing, fixing ordering * [cccs-2.0] fixing build error * [cccs-2.0] updating image * [cccs-2.0] fixing time columns * [cccs-2.0] Fixing build errors * [cccs-2.0] updating docker file * [cccs-2.0] Fixing time column to populate default time col * Fixing default time col * [cccs-2.0] updating image * Fix issue where datasets without a date/datetime column would not load in the explore view * Time column dropdown list is now properly populated with either the default temporal column, or the first temporal column (if a default is not set) * Temp update to base image tag * Fixed the bug where when there are no dttm columns, the non-dttm columns were being displayed * Temp update to base image tag * Reverting changes to the img * Updating image tag Co-authored-by: cccs-RyanS <71385290+cccs-RyanS@users.noreply.github.com> * Fixed issue with Typescript (#205) * Fix cccs 2.0 (#206) * Fixed issue with Typescript * Update image tag * Feature/cldn 1563 (#207) * Ran pre-commit hook on the front-end * Removed unused file & removed duplicate method * Made changes so that the pre-commit hook would pass all tests * Temp update to build img * revert temp change to build img * Updated image (#208) * [CLDN-1683] Added code to show column descriptions as tooltips in the… (#209) * [CLDN-1683] Added code to show column descriptions as tooltips in the Hogwarts Table custom visualisation * [CLDN-1683] Temp update to build image * [CLDN-1683] Revert update to image tag * Feature/cldn 1676 (#210) * [CLDN-1676] Added ability to search for the IPv4 rendered value of an IP address instead of the raw value * [CLDN-1676] Temp update to img for deploying to UDev * [CLDN-1676] Undo temp update to img for deploying to UDev * Updating Superset Base Image Tag (#211) * added adhoc filter plugin files * Made sure that adhoc filter uses the adhoc filter object * added adhocfiltercontrol to native adhoc filter * fixed hook that made too many requests * fixed applied filter label * removed duplicate files * Removed uneeded functions * Removed uneeded functions and variables * Removed unused props variables * modifying base image tag * Removed unused config settings * removed column for filter config form * Improved the applied filter(s) modal * Temp update to build image * fixed string formatting issue: * updating superset base image tag * added setFocused hooks to filter when hovering * Fixed the right click to emit dashboard cross-filters (#213) * Fixed the right click to emit filters through the context menu as it was not working * Temp update to build image * Revert temp update to build image * Updated superset base image (#214) * fixed unused declaration error * updating image * Prevent invalid filter values from being saved (#215) By assuming that all input is invalid until the api tells us otherwise, we can prevent the user from clicking the save button in the time between the value being entered and the api returning. * [cccs-2.0] fixing trino req (#216) * updating superset-base image tag * added option to emit a filter from a default column for a row in ag grid * Update trino python client (#219) * Updated trino python client from 0.316.0 to 0.318.0 * Temp update to base image tag * Removing temp change to build image * Updated superset's base image tag (#221) * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/CccsGrid.tsx Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * changed control panel to plural * disallow columns that are not a part of the chart to be selected as default emit filters * updated image tag * updated control panel logic for agg mode * update image tag * fixed issues * updating base image * fixed refactor error * updating base image * fixed so that option disables properly * updating base image * Add users API to get and delete users (#223) * Add users API to get and delete users * Allow browser login for users api * updating image * Update cccs-build/superset/Dockerfile Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * Added ability to certify entities with multiple values (#224) * Added ability to certify entities with multiple values * Update description text to reflect new feature * Add tests for multiple certified by values * Feature/cldn 1749 (#222) * [CLDN-1749] adding new viz * chanigng to work with standard filters * Adding generic filter extraction * Removing unused imports * [CLDN-1749] Cleaning up code for reusablility * [CLDN-1749] removing unused files * [CLDN-1746] fixing case * [CLDN-1749] adding parameter validation * [CLDN-1749] adding error message and prefix parameter * [CLDN-1749] removing unused files * [CLDN-1749] adding temp base image for docker deployment * [CLDN-1749] Better error handling and new icon * [CLDN-1749] remove unused imports * temp dockerfile change * [CLDN-1749] Adding the adhoc filters back in * [CLDN-1749] Updating image * [CLDN-1749] Adding new thumbnail * Updating dockerfile * [CLDN-1749] Removing uneeded control panel elements * [CLDN-1749] Fixing build errors * [CLDN-1749] New image * Change to use data from dataset * Removing unsed function * Fixing typos * renove unused import * updating image * error message and label fixes * updating image * Update cccs-build/superset/Dockerfile Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-iframe/src/plugin/transformProps.ts Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-iframe/src/plugin/transformProps.ts Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> * Prevent non-admins from using users api (#236) * Prevent non-admins from using users api * Add tests * added styles to highlight adhoc filter when focused and fix awkward empty header * removed suggestions from popping up * added comment * fixed unused import error * updating base image * Update Dockerfile * [CLDN-1829] fixing principle filter logic with state (#234) (#244) * [CLDN-1829] fixing principle filter logic with state * [CLDN-1829] Fixing build error * [cccs-2.0] Updating image (#245) * value set to empty list instead of undefined * updating base image * Feature/cldn 1748 (#243) * [CLDN-1748] adding base component * [CLDN-1748] changing state to use advanced data type * [CLDN-1748] add multi select for musiness type * [CLDN-1748] adding config manager * [CLDN-1748] fixing build errors * temp update of base image * [CLDN-1748] Fixing Url parameter encoding and show name of dashboard drilling to * temp update of image * Pulling extra data from dashboard endpoint * Adding more data to filters object * [CLDN-1748] passing mroe fitler information * [CLDN-1748] QA feedback * [CLDN-1748] Fixing build issues * [CLDN-1748] Updating dockerfile * [CLDN-1748] Updating dockerfile * fixing props name * update image * updating docker file * [CLDN-1748] Name changes * [CLDN-1748] updating image * [CLDN-1748] Adding icon * [CLDN-1748] fixing build errors * [CLDN-1748] update image * [CLDN-1748] fixing context menue to renderering * UPdating docker file * CLDN-1710 including schema in search columns for datasets api (#253) * Update Dockerfile * CLDN-1710 tag update (#255) * update image tag * updating image tag * Update vault image to get new CAs * update image tag * Update Dockerfile * Update Dockerfile * Feature/cldn 1773 (#269) * [CLDN-1773] Adding default group by * Updating DockerFile * Fixing Groupby * Updating base image * [CLDN-1773] Saving Group by order * Updating dockerfile * Update controlPanel.tsx * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/plugin/transformProps.ts Co-authored-by: cccs-tom <59839056+cccs-tom@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/plugin/transformProps.ts Co-authored-by: cccs-tom <59839056+cccs-tom@users.noreply.github.com> * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/plugin/transformProps.ts Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> --------- Co-authored-by: cccs-tom <59839056+cccs-tom@users.noreply.github.com> Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> * Updating docker file (#270) * Feature/cldn 1968 (Display JSON data inline) (#268) * Add buttons to expand and minimize JSON data as well as ability to expand and/or collapse all rows in a certain column * [CLDN-1968] Added expand button for full row * [CLDN-1968] Resize JSON columns * [CLDN-1968] Added new array which tracks JSON cell state * Revert "[CLDN-1968] Added new array which tracks JSON cell state" This reverts commit dabc3da. * [CLDN-1968] Added ability for row level expand all button to track if cells are expanded or not * [CLDN-1968] Ran pre-commit hook * [CLDN-1968] Improved UI * [CLDN-1968] Update image tag for testing * [CLDN-1968] Revert image tag for testing * [CLDN-1968] Added multiple UI/UX changes based on QA feedback * [CLDN-1968] Added more UI/UX changes based on QA feedback * [CLDN-1968] Temp change to image * Revert "[CLDN-1968] Temp change to image" This reverts commit 57490bd. * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/CccsGrid.tsx Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * [CLDN-1968] Remove 'TODO's as they are no longer needed * [CLDN-1968] Changed a variable name, and condensed a few lines * [CLDN-1968] Modified a setState so that only one is needed instead of 2 --------- Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * Feature/cldn 1968 (#272) * Add buttons to expand and minimize JSON data as well as ability to expand and/or collapse all rows in a certain column * [CLDN-1968] Added expand button for full row * [CLDN-1968] Resize JSON columns * [CLDN-1968] Added new array which tracks JSON cell state * Revert "[CLDN-1968] Added new array which tracks JSON cell state" This reverts commit dabc3da. * [CLDN-1968] Added ability for row level expand all button to track if cells are expanded or not * [CLDN-1968] Ran pre-commit hook * [CLDN-1968] Improved UI * [CLDN-1968] Update image tag for testing * [CLDN-1968] Revert image tag for testing * [CLDN-1968] Added multiple UI/UX changes based on QA feedback * [CLDN-1968] Added more UI/UX changes based on QA feedback * [CLDN-1968] Temp change to image * Revert "[CLDN-1968] Temp change to image" This reverts commit 57490bd. * Update superset-frontend/src/cccs-viz/plugins/plugin-chart-cccs-grid/src/CccsGrid.tsx Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * [CLDN-1968] Remove 'TODO's as they are no longer needed * [CLDN-1968] Changed a variable name, and condensed a few lines * [CLDN-1968] Modified a setState so that only one is needed instead of 2 * Update superset base image --------- Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> * post merge fixes * updating package lock * fix npm install * npm fixes * updating base image tag * fixed typing extensions version * grabbing cldn 2076 changes * fixed dev version number * updating base image --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com> Co-authored-by: Antonio Rivero <antonioriverocode@gmail.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Daniel Draper <Germandrummer92@gmail.com> Co-authored-by: Daniel Draper <daniel.draper@understand.ai> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Cody Leff <cody@preset.io> Co-authored-by: Lily Kuang <lily@preset.io> Co-authored-by: Sergey Shevchenko <sergeyshevchdevelop@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: Jack Fragassi <jfragassi98@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Cemre Mengu <cemremengu@gmail.com> Co-authored-by: Mayur <mayurnewase111@gmail.com> Co-authored-by: Diego Medina <diegomedina24@gmail.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: cleslie <cjaleslie@gmail.com> Co-authored-by: Calum <calum.leslie@skyscanner.net> Co-authored-by: Igor Șincariov <102555782+igorsinc@users.noreply.github.com> Co-authored-by: Igor Șincariov <igorsinc@pm.me> Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com> Co-authored-by: Artem Shumeiko <53895552+artemonsh@users.noreply.github.com> Co-authored-by: 王一川 <wj2247689442@gmail.com> Co-authored-by: nisheldo <njsheldon@me.com> Co-authored-by: Leo Schick <67712864+leo-schick@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Arash Afghahi <48933336+AAfghahi@users.noreply.github.com> Co-authored-by: Denis Krivenko <dnskrv88@gmail.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com> Co-authored-by: tejaskatariya <42517374+tejaskatariya@users.noreply.github.com> Co-authored-by: Adrian <icsu@users.noreply.github.com> Co-authored-by: alexclavel-ocient <111374753+alexclavel-ocient@users.noreply.github.com> Co-authored-by: Trey Gilliland <treygilliland3@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Rajan Gupta <rajan0493@gmail.com> Co-authored-by: DASTC\gupta_rajan <rajan.gupta@stengg.com> Co-authored-by: Dheeraj Jaiswal <118437694+dheeraj-jaiswal-lowes@users.noreply.github.com> Co-authored-by: tison <wander4096@gmail.com> Co-authored-by: Changhoon Oh <81631424+okayhooni@users.noreply.github.com> Co-authored-by: ok9897 <ok9897@krafton.com> Co-authored-by: kuruv <kuruv@users.noreply.github.com> Co-authored-by: Zef Lin <zef@preset.io> Co-authored-by: cccs-RyanS <71385290+cccs-RyanS@users.noreply.github.com> Co-authored-by: Reese <10563996+reesercollins@users.noreply.github.com> Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com> Co-authored-by: cccs-rc <62034438+cccs-rc@users.noreply.github.com> Co-authored-by: GITHUB_USERNAME <EMAIL> Co-authored-by: cccs-nik <68961854+cccs-nik@users.noreply.github.com> Co-authored-by: cccs-tom <59839056+cccs-tom@users.noreply.github.com>

pull-request-size bot added the size/L label Oct 13, 2022

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 2 times, most recently from 0f1ba9e to 3b16583 Compare October 13, 2022 04:41

john-bodley commented Oct 13, 2022

View reviewed changes

john-bodley marked this pull request as ready for review October 13, 2022 04:47

john-bodley requested review from ktmud, villebro, betodealmeida and bkyryliuk October 13, 2022 04:47

john-bodley commented Oct 13, 2022

View reviewed changes

betodealmeida approved these changes Oct 13, 2022

View reviewed changes

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 4 times, most recently from 5f8994d to 996ab1d Compare October 13, 2022 05:54

john-bodley commented Oct 13, 2022

View reviewed changes

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 6 times, most recently from f3338ac to ceb94b3 Compare October 13, 2022 16:59

pull-request-size bot added size/XXL and removed size/L labels Oct 13, 2022

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch from ceb94b3 to dc180ad Compare October 13, 2022 17:00

pull-request-size bot added size/L and removed size/XXL labels Oct 13, 2022

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 2 times, most recently from a9cb73b to 67a38d9 Compare October 13, 2022 17:37

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch from a8c2dc9 to 9dce414 Compare November 9, 2022 15:55

john-bodley changed the title ~~fix(trino): Ensure get_table_names only returns real tables~~ fix(presto/trino): Ensure get_table_names only returns real tables Nov 9, 2022

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 2 times, most recently from 6ac079a to 6fccd66 Compare November 9, 2022 16:07

john-bodley commented Nov 9, 2022

View reviewed changes

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch 8 times, most recently from aecb6fd to 82731ad Compare November 9, 2022 19:17

fix(trino): Ensure get_table_names only returns physical tables

87b9879

john-bodley force-pushed the john-bodley--fix-trino-get-table-names branch from 82731ad to 87b9879 Compare November 9, 2022 19:33

john-bodley merged commit 9f7bd1e into apache:master Nov 9, 2022

john-bodley mentioned this pull request Nov 9, 2022

chore: Change get_table_names/get_view_names return type #22085

Merged

9 tasks

diegomedina248 pushed a commit to preset-io/superset that referenced this pull request Dec 3, 2022

fix(presto/trino): Ensure get_table_names only returns real tables (a…

fff03b4

…pache#21794)

john-bodley mentioned this pull request Jan 20, 2023

fix(hive): Regression in #21794 #22794

Merged

9 tasks

john-bodley added a commit to john-bodley/superset that referenced this pull request Jan 20, 2023

fix(hive): Regression in apache#21794

d48979a

john-bodley added a commit that referenced this pull request Jan 21, 2023

fix(hive): Regression in #21794 (#22794)

0b31b2c

john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 23, 2023

fix(hive): Regression in apache#21794 (apache#22794)

56905a8

(cherry picked from commit 0b31b2c)

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(presto/trino): Ensure get_table_names only returns real tables #21794

fix(presto/trino): Ensure get_table_names only returns real tables #21794

john-bodley commented Oct 13, 2022 •

edited

Loading

john-bodley Oct 13, 2022

betodealmeida Oct 13, 2022

john-bodley Oct 13, 2022

john-bodley Oct 13, 2022

john-bodley Oct 13, 2022

john-bodley Oct 13, 2022 •

edited

Loading

betodealmeida left a comment

betodealmeida Oct 13, 2022

codecov bot commented Oct 13, 2022 •

edited

Loading

john-bodley Oct 13, 2022

john-bodley Nov 9, 2022

fix(presto/trino): Ensure get_table_names only returns real tables #21794

fix(presto/trino): Ensure get_table_names only returns real tables #21794

Conversation

john-bodley commented Oct 13, 2022 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-bodley Oct 13, 2022 • edited Loading

Choose a reason for hiding this comment

betodealmeida left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Oct 13, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-bodley commented Oct 13, 2022 •

edited

Loading

john-bodley Oct 13, 2022 •

edited

Loading

codecov bot commented Oct 13, 2022 •

edited

Loading