fix(dashboard): Chart's empty state not centered

[kgabryje]

SUMMARY

This pr fixes chart's empty state on dashboard vertical alignment - was aligned to the top, should be entered.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Add some filters to trigger empty state in chart on dashboard, verify that empty state placeholder is centred.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC @kasiazjc

[kasiazjc]

Amazing, thank youu @kgabryje ❤️

[codecov]

Codecov Report

Merging #23022 (f091c0b) into master (d4362a3) will increase coverage by 12.41%.
The diff coverage is n/a.

❗ Current head f091c0b differs from pull request most recent head fc0aa5f. Consider uploading reports for the commit fc0aa5f to get more accurate results

@@             Coverage Diff             @@
##           master   #23022       +/-   ##
===========================================
+ Coverage   53.23%   65.65%   +12.41%     
===========================================
  Files        1881     1878        -3     
  Lines       72398    72152      -246     
  Branches     7882     7868       -14     
===========================================
+ Hits        38540    47370     +8830     
+ Misses      31836    22763     -9073     
+ Partials     2022     2019        -3     

Flag	Coverage Δ
javascript	53.81% <ø> (-0.07%)	⬇️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Chart/Chart.jsx	52.45% <ø> (ø)
...set/advanced_data_type/plugins/internet_address.py	16.32% <0.00%> (-79.60%)	⬇️
superset/utils/pandas_postprocessing/boxplot.py	20.51% <0.00%> (-79.49%)	⬇️
superset/charts/post_processing.py	12.40% <0.00%> (-77.38%)	⬇️
...perset/advanced_data_type/plugins/internet_port.py	18.75% <0.00%> (-77.09%)	⬇️
superset/utils/pandas_postprocessing/rolling.py	21.87% <0.00%> (-68.75%)	⬇️
...perset/utils/pandas_postprocessing/contribution.py	34.61% <0.00%> (-65.39%)	⬇️
superset/utils/pandas_postprocessing/resample.py	37.50% <0.00%> (-62.50%)	⬇️
superset/utils/pandas_postprocessing/select.py	38.46% <0.00%> (-61.54%)	⬇️
superset/utils/pandas_postprocessing/rename.py	40.00% <0.00%> (-60.00%)	⬇️
... and 395 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[codyml]

Thanks! Not necessarily a problem but I'm noticing a few layout changes when charts are populated:

Screen.Recording.2023-02-07.at.11.46.06.AM.mov

[kgabryje]

Thanks! Not necessarily a problem but I'm noticing a few layout changes when charts are populated:

Screen.Recording.2023-02-07.at.11.46.06.AM.mov

So THAT'S why cypress is failing 🤦 Thanks, will fix