Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gas] Correct the gas schedule version for a recently added native function #5985

Merged
merged 4 commits into from
Dec 24, 2022

Conversation

movekevin
Copy link
Contributor

@movekevin movekevin commented Dec 22, 2022

Description

The gas version in #5436 is wrong.

New native functions added should use the next gas version.

The new hash native function added in that commit uses an existing gas version (4) while the current latest version is 5 - https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas/src/gas_meter.rs#L49

Test Plan

Compat test

@movekevin movekevin added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 22, 2022
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@vgao1996
Copy link
Contributor

@movekevin @davidiw has gas feature version 5 already been released to testnet or included in a testnet branch cut? If not, then we should probably still consider it the current version.

@davidiw
Copy link
Contributor

davidiw commented Dec 24, 2022

bumping down to 5...

@davidiw davidiw enabled auto-merge (squash) December 24, 2022 00:12
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 597cff41317c34599cf8c79b0e8cb546b1eceea4

performance benchmark with full nodes : 6644 TPS, 5942 ms latency, 12900 ms p99 latency,(!) expired 1360 out of 2838720 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 597cff41317c34599cf8c79b0e8cb546b1eceea4

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 597cff41317c34599cf8c79b0e8cb546b1eceea4 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7602 TPS, 5377 ms latency, 7800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 597cff41317c34599cf8c79b0e8cb546b1eceea4
compatibility::simple-validator-upgrade::single-validator-upgrade : 4332 TPS, 9179 ms latency, 12800 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 597cff41317c34599cf8c79b0e8cb546b1eceea4
compatibility::simple-validator-upgrade::half-validator-upgrade : 4280 TPS, 9383 ms latency, 12700 ms p99 latency,no expired txns
4. upgrading second batch to new version: 597cff41317c34599cf8c79b0e8cb546b1eceea4
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6408 TPS, 6013 ms latency, 9900 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 597cff41317c34599cf8c79b0e8cb546b1eceea4 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants