Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas] fix incorrect gas feature version for hash.blake2b_256 #6125

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

vgao1996
Copy link
Contributor

@vgao1996 vgao1996 commented Jan 9, 2023

There was a previous attempt (57294de in #5985) to fix the incorrect gas feature version for this native function, but even that number was too low.

This relates to the wrong gas version initially introduced in #5436

@vgao1996 vgao1996 enabled auto-merge (squash) January 9, 2023 19:25
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

✅ Forge suite land_blocking success on bb7daf8a55e3e810847721d71dc9555f51c8f43f

performance benchmark with full nodes : 6598 TPS, 6003 ms latency, 8100 ms p99 latency,(!) expired 400 out of 2817840 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bb7daf8a55e3e810847721d71dc9555f51c8f43f

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bb7daf8a55e3e810847721d71dc9555f51c8f43f (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7283 TPS, 5286 ms latency, 7600 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: bb7daf8a55e3e810847721d71dc9555f51c8f43f
compatibility::simple-validator-upgrade::single-validator-upgrade : 4890 TPS, 8426 ms latency, 11400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: bb7daf8a55e3e810847721d71dc9555f51c8f43f
compatibility::simple-validator-upgrade::half-validator-upgrade : 4776 TPS, 8474 ms latency, 10700 ms p99 latency,no expired txns
4. upgrading second batch to new version: bb7daf8a55e3e810847721d71dc9555f51c8f43f
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6640 TPS, 5813 ms latency, 10700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> bb7daf8a55e3e810847721d71dc9555f51c8f43f passed
Test Ok

Copy link
Contributor

@alinush alinush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I will need some help to understand this gas versioning stuff...

@vgao1996 vgao1996 merged commit c671269 into aptos-labs:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants