Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log viewing problem in UI due pod name changes #6962

Closed
tczhao opened this issue Oct 19, 2021 · 5 comments · Fixed by #6982
Closed

Log viewing problem in UI due pod name changes #6962

tczhao opened this issue Oct 19, 2021 · 5 comments · Fixed by #6982
Assignees
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@tczhao
Copy link
Member

tczhao commented Oct 19, 2021

Summary

#6712
introduce POD_NAMES Whether to have pod names contain the template name (v2) or be the node id (v1).

#6925
forces all podname on UI to align with v2,

These introduce problems:

  • by setting POD_NAMES to v2 on workflow-controller

all the historical archived workflow logs won't be viewable in UI because they are stored without the template name

  • by setting POD_NAMES to v1 on workflow-controller

all the new workflow/archived workflows logs won't be viewable in UI because they are stored without the template name

What version of Argo Workflows are you running?
master: cf9a6cd


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@alexec alexec added the type/regression Regression from previous behavior (a specific type of bug) label Oct 19, 2021
@alexec
Copy link
Contributor

alexec commented Oct 19, 2021

This is a really good point. The UI needs to be smarter, and know which pod name format we use.

Proposal:

We annotate news workflow with workflows.argoproj.io/pod-name-format: v2, that data is available in the UI, so the UI can be smart.

@sarabala1979 @JPZ13 thoughts?

@alexec
Copy link
Contributor

alexec commented Oct 19, 2021

Aside - I anticipate this being number 1 complained feature if we don't fix quickly.

@sarabala1979
Copy link
Member

I like the idea of annotating the version.

@sarabala1979
Copy link
Member

@JPZ13 Can you take this issue to fix it?

@JPZ13
Copy link
Member

JPZ13 commented Oct 19, 2021

@sarabala1979 @alexec Yep - I can work on it this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants