Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI logs for multi-step workflows with templateRef still missing in v3.2.1 #6989

Closed
kruegener opened this issue Oct 20, 2021 · 6 comments · Fixed by #6982
Closed

UI logs for multi-step workflows with templateRef still missing in v3.2.1 #6989

kruegener opened this issue Oct 20, 2021 · 6 comments · Fixed by #6982
Assignees
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@kruegener
Copy link

Summary

Version 3.2.0 introduced a bug regarding logs in the UI for multi-step workflows #6947.
This was mostly fixed with version 3.2.1 via #6925, however some edge cases still fail.

In our case, a step using templateRef still does not work. The pod name in the UI for this step contains undefined, where according to the new pod naming scheme the step name should be.
The same config used to work in 2.x.x and 3.1.8.

The workflow actually runs the step/pod completely ok, just the logs are still missing.

Diagnostics

Setup of issue.

apiVersion: argoproj.io/v1alpha1
kind: ClusterWorkflowTemplate
metadata:
  name: component-workflow
spec:
  templates:
  - name: entry
    inputs:
      parameters:
      - name: component
    steps:
    - - name: some-other-step
           template: ....
    - - name: run-tests
           templateRef:
             name: tests-{{inputs.parameters.component}}
             template: tests
     - - name: some-other-step
           template: ....

What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary:
Docker


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@kruegener kruegener added type/bug type/regression Regression from previous behavior (a specific type of bug) triage labels Oct 20, 2021
@tczhao
Copy link
Member

tczhao commented Oct 20, 2021

confirm reproducible with
https://github.com/argoproj/argo-workflows/blob/master/examples/workflow-template/steps.yaml


image
some nodes have undefined in the pod name causing query the backend using incorrect url


Hi @JPZ13 , can you have a look into this as well

@JPZ13
Copy link
Member

JPZ13 commented Oct 20, 2021

Yes. I'll incorporate into #6982

@JPZ13
Copy link
Member

JPZ13 commented Oct 20, 2021

@kruegener and @tczhao - are there any other notable edge cases you're seeing? I'll add specific tests for each case y'all call out

@kruegener
Copy link
Author

So far just the templateRef in a multi-step workflow in our case. Will update if there's more. Thanks for fixing it ;)

@JPZ13
Copy link
Member

JPZ13 commented Oct 20, 2021

So far just the templateRef in a multi-step workflow in our case. Will update if there's more. Thanks for fixing it ;)

You're welcome! And thanks for catching it/filing the issue

@alexec alexec linked a pull request Oct 20, 2021 that will close this issue
@alexec alexec removed the triage label Oct 20, 2021
@alexec
Copy link
Contributor

alexec commented Oct 20, 2021

Thank you @JPZ13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants