update from source #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inherit CarouselPanel from VirtualizingPanel, use ItemsStackPanelLayout - amend ComboBox style to support virtualization
Make the case more robust where the list initially measures with a smaller desired size than what is available, ie the items don't fill all available space. This fixes a bug with the former logic where, after returning a smaller desired size than what was available, the list would be remeasured with that returned size, and then 'forget' that more space had been available.
Fix layout attributes not updating with dynamic sizes correctly, it seems that in some cases PreferredLayoutAttributesFittingAttributes() may be called out of order.
This can occur when Measure() is called outside of the usual loop, followed by ScrollIntoView().
If SelectedItem is a view, ensure it's correctly placed in either the ContentPresenter or the dropdown list according to whether the dropdown is open. This fixes bug where the item would disappear from the ContentPresenter if the dropdown were light-dismissed without changing the selection, and makes the logic more robust in the case of a virtualized list.
Certain Styles application sequences can lead to the same ItemsPanelTemplate (but not reference-equal) being applied multiple times. As a perf improvement, don't reapply the panel. This also works around the issue on Android that changing the ItemsPanel of a ListView after it's already been materialized isn't properly supported and causes errors.
This is a significant perf optimization since UpdateLayout() is called very frequently while scrolling.
When ListView has non-Stretched breadth, item elements must be arranged with the list's breadth rather than their desired size. (Otherwise, eg, selected state highlight doesn't stretch to full width.)
Revert virtualization on these platforms because it breaks layouting (ComboBox dropdown stretches to full width of window). It can be reenabled when #1133 is fixed.
TextBox - add TextChanging and BeforeTextChanging
- Enable InjectEvents permission - Disable keyguard - Enable `-no-window` https://stackoverflow.com/questions/3214531/how-to-send-key-events-to-a-headless-emulator-in-an-instrumentation-test
…ow handled by TextBox.CoerceText()
…length Fix MaxLength handling on Android and WASM
Created UI Test for Vertical Slider Tapping #1350
Co-Authored-By: David Oliver <david.john.oliver@gmail.com>
Refactored Drawable helper to Uno project
…ecostervgls/Uno into dev/pdeco/vertical-slider-tap
…-tap Fix inverted vertical slider
…cing compilation errors. Github Bug #718
…ontent in the file.
Errors setting some properties on root of XAML file
… MonoAndroid90 and 60.1142.1 for MonoAndroid80
Fix to groupedlistviewheaders performance issue
…services Update Xamarin.GooglePlayServices packages
Fix to flyouts resorting to default when flyout is bigger than anchor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):