-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename LATEST_VERSION to LATEST_TYPESCRIPT_VERSION #354
Conversation
We could export both and update all usages and snippets to load TS_LATEST_VERSION, then its not breaking |
Only if we plan to remove it in 2.0. Sound good? |
We have
so perhaps be explicit and follow the same convention with |
Should probably make the same change in rules_swc, rules_esbuild, rules_cypress & rules_deno |
Ok I've switched to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
This previous name is left for backwards compatibility and will be removed in v2.0. Fix aspect-build/rules_js#817
The previous name is left for backwards compatibility and will be removed in v2.0. Fix aspect-build/rules_js#817
Fix aspect-build/rules_js#817
WDYT of changing this in 2.0+? Could add it as an alias for now...