Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename LATEST_VERSION to LATEST_TYPESCRIPT_VERSION #354

Merged
merged 1 commit into from
May 1, 2023

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 19, 2023

Fix aspect-build/rules_js#817

WDYT of changing this in 2.0+? Could add it as an alias for now...

@gregmagolan
Copy link
Member

gregmagolan commented Apr 19, 2023

We could export both and update all usages and snippets to load TS_LATEST_VERSION, then its not breaking

@jbedard
Copy link
Member Author

jbedard commented Apr 19, 2023

Only if we plan to remove it in 2.0. Sound good?

@gregmagolan
Copy link
Member

gregmagolan commented Apr 19, 2023

We have DEFAULT_NODE_VERSION in rules_nodejs and I saw these in our bazel-examples

load("@aspect_rules_esbuild//esbuild:repositories.bzl", "esbuild_register_toolchains", LATEST_ESBUILD_VERSION = "LATEST_VERSION")

esbuild_register_toolchains(
    name = "esbuild",
    esbuild_version = LATEST_ESBUILD_VERSION,
)
load("@aspect_rules_swc//swc:repositories.bzl", "swc_register_toolchains", LATEST_SWC_VERSION = "LATEST_VERSION")

swc_register_toolchains(
    name = "swc",
    swc_version = LATEST_SWC_VERSION,
)

so perhaps be explicit and follow the same convention with LATEST_TYPESCRIPT_VERSION as the exported symbol with LATEST_VERSION around for backward compat and to be removed in 2.0?

@gregmagolan
Copy link
Member

gregmagolan commented Apr 19, 2023

Should probably make the same change in rules_swc, rules_esbuild, rules_cypress & rules_deno

@jbedard
Copy link
Member Author

jbedard commented Apr 19, 2023

Ok I've switched to the LATEST_*_VERSION style and marked the LATEST_VERSION to be removed in 2.0. If that looks right I'll do the same in other rulesets as well.

Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard changed the title docs: alias LATEST_VERSION as TS_LATEST_VERSION in example snippets refactor: rename LATEST_VERSION to LATEST_TYPESCRIPT_VERSION Apr 20, 2023
This previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
@jbedard jbedard merged commit d82b64b into main May 1, 2023
@jbedard jbedard deleted the 817js-docs branch May 1, 2023 19:08
alexeagle pushed a commit that referenced this pull request Aug 7, 2023
The previous name is left for backwards compatibility and will be removed in v2.0.

Fix aspect-build/rules_js#817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FR]: Add renamed symbols to the release snippets
2 participants