Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it OK to have TODO comment in PR code? #118

Closed
taikitanaka3 opened this issue Dec 6, 2021 · 2 comments
Closed

Is it OK to have TODO comment in PR code? #118

taikitanaka3 opened this issue Dec 6, 2021 · 2 comments

Comments

@taikitanaka3
Copy link
Contributor

as PR title description.

@kenji-miyake
Copy link
Contributor

I think it's okay, but it should be reviewed as much as possible.

1222-takeshi added a commit that referenced this issue Dec 6, 2021
* release v0.4.0

* Modify to use projection matrix with undistorted 2D result (#722)

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (#28)

* Rename h files to hpp (#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (#143)

* Use quotes for includes where appropriate (#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* ported roi_cluster_fusion from ROS1 to ROS2 (#118)

compiles succesfully.
Getting some undefined reference error while launching the node.

* Port euclidean cluster (#120)

* porting CmakeLists.txt and package.xml in progress

* ported CMakeLists.txt and package.xml to ROS2

* Ported euclidean_cluster from ROS1 to ROS2

* deleted unnecesary files

* fixed transient_local

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* hotfix roi_cluster_fusion (#239)

* Fix perception launches (#240)

* fix roi_cluster_fusion launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

* add comment on launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>

* Ros2 v0.8.0 roi cluster fusion (#321)

* restore v0.5.0

* Feature/fusion debug (#1051)

* add debuger

* change param

* add publisher

* Compatible with opencv4 (#1156)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* refactor for ros2 style

* fix code

* to hpp

* fix code

* uncursify

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (#346)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix transform (#420)

* Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix canTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix test

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo in perception module (#440)

* add use_sim-time option (#454)

* Format launch files (#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Unify Apache-2.0 license name (#1242)

* Remove use_sim_time for set_parameter (#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix -Wunused-parameter (#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* [roi_cluster_fusion]: Fix poting mistake (#1624)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix typo & check debugger (#1511) (#1625)

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Use set_remap for if tag (#1800)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply format (#1999)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix cpplint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Detection by tracker (#1910)

* initial commit

* backup

* apply format

* cosmetic change

* implement divided under segmenterd clusters

* cosmetic change

* bug fix

* bug fix

* bug fix

* modify launch

* add debug and bug fix

* bug fix

* bug fix

* add no found tracked object

* modify parameters and cmake

* bug fix

* remove debug info

* add readme

* modify clustering launch

* run pre-commit

* cosmetic change

* cosmetic change

* cosmetic change

* apply markdownlint

* modify launch

* modify for cpplint

* modify qos

* change int to size_T

* bug fix

* change perception qos

* Update perception/object_recognition/detection/detection_by_tracker/package.xml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* cosmetic change

* cosmetic change

* fix launch

* Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* modify header include order

* change include order

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* change to std::optional

* cosmetic change

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* bug fix

* modify readme

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* sync rc rc/v0.23.0 (#2219)

* Fix qos in roi cluster fusion (#2218)

* fix confidence (#2220)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Change formatter to clang-format and black (#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port roi cluster fusion (#536)

* remove COLCON_IGNORE

* use DetectedObjectsWithFeature

* fix topic type

* update overwrite condition

* add README of roi_cluster_fusion (#653)

* add README of roi_cluster_fusion

* fix typo

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add image

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
@maxime-clem
Copy link
Contributor

The template for merge requests in .Auto has checkboxes for:

Review any // TODO item added in the MR that can be addressed without the reviewer's help

and

Any added source-code comment about future work refers to a follow-up GitLab issue explicitly; e.g., // TODO #551 refactor code below

I think this is a good practice.

harihitode pushed a commit to harihitode/autoware.universe that referenced this issue Dec 9, 2021
compiles succesfully.
Getting some undefined reference error while launching the node.
tkimura4 pushed a commit to tkimura4/autoware.universe that referenced this issue Dec 10, 2021
* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this issue Dec 10, 2021
* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
tkimura4 pushed a commit to tkimura4/autoware.universe that referenced this issue Dec 13, 2021
tkimura4 pushed a commit to tkimura4/autoware.universe that referenced this issue Dec 13, 2021
1222-takeshi pushed a commit that referenced this issue Dec 14, 2021
* release v0.4.0

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit e002b78f1e1ddf980ee7c4010918f1c117ff4be1.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port to ROS 2

* Fix params file paths

* Re-add autoware_state_monitor

* Update system_launch/launch/system.launch.xml

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Add linters and missing pakcages dependencies (#37)

* V0.8 system launch (#51)

* tmp rename launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add system_monitor to system.launch (#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config file of system_monitor (#115)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config of diagnostic_aggregator (#128)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add vehicle cmd gate config (#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_hold arg (#142)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix system.launch (#161)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "tmp rename launch file"

This reverts commit d1bb989eac90f43bab2af6669b00638fd2147eeb.

* fix launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor bug

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Rename ROS-related .yaml to .param.yaml (#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add clock_publisher and autoware_version (#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update package.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Split system_monitor config (#98)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (#99)

* Replace doc by description (#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_parameter for use_sim_time (#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change system_monitor.launch.xml to launch.py (#203)

* add README.md and svg files (#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix pre-commit (#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update system.launch.xml (#411)

* Feature/autoware api autoware versions (#438)

* Add package version API

* Fix message type

* Modify api name

* use let variable in system_launch (#473)

* Add sensor_model to system_launch (#480)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to black (#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Fix diagnostic_aggregator config path (#118)

* update param

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
taikitanaka3 added a commit that referenced this issue Dec 14, 2021
* release v0.4.0

* Feature/phased timestamped velodyne (#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (#32)

* Ros2 v0.8.0 sensing launch (#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (#89)

* fix pass through filter launch (#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (#100)

* fix livox launch arg (#108)

* add usb_cam depend (#118)

* update aip_x1 camera.launch (#119)

* update imu.launch (#120)

* fix veodyne setting in aip_x1/lidar.launch (#125)

* Add velodyne_monitor to velodyne_*.launch (#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (#143)

* Format gnss.launch (#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (#71)

* update sensing launch to support aip_x1 (#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (#85)

* Use sensor data qos for pointcloud (#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (#87)

* Fix default value of use_concat_filter and use_radius_search (#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (#97)

* Move individual params to a separate package (#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (#99)

* Format launch files (#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (#296)

* add description for sensing_launch (#336)

* add description

* fix sentence

* add README.md and svg files (#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (#434)

* Change formatter to black (#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* Modify to use projection matrix with undistorted 2D result (autowarefoundation#722)

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118)

compiles succesfully.
Getting some undefined reference error while launching the node.

* Port euclidean cluster (autowarefoundation#120)

* porting CmakeLists.txt and package.xml in progress

* ported CMakeLists.txt and package.xml to ROS2

* Ported euclidean_cluster from ROS1 to ROS2

* deleted unnecesary files

* fixed transient_local

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* hotfix roi_cluster_fusion (autowarefoundation#239)

* Fix perception launches (autowarefoundation#240)

* fix roi_cluster_fusion launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

* add comment on launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>

* Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321)

* restore v0.5.0

* Feature/fusion debug (autowarefoundation#1051)

* add debuger

* change param

* add publisher

* Compatible with opencv4 (autowarefoundation#1156)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* refactor for ros2 style

* fix code

* to hpp

* fix code

* uncursify

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix transform (autowarefoundation#420)

* Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix canTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix test

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo in perception module (autowarefoundation#440)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625)

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Use set_remap for if tag (autowarefoundation#1800)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply format (autowarefoundation#1999)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix cpplint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Detection by tracker (autowarefoundation#1910)

* initial commit

* backup

* apply format

* cosmetic change

* implement divided under segmenterd clusters

* cosmetic change

* bug fix

* bug fix

* bug fix

* modify launch

* add debug and bug fix

* bug fix

* bug fix

* add no found tracked object

* modify parameters and cmake

* bug fix

* remove debug info

* add readme

* modify clustering launch

* run pre-commit

* cosmetic change

* cosmetic change

* cosmetic change

* apply markdownlint

* modify launch

* modify for cpplint

* modify qos

* change int to size_T

* bug fix

* change perception qos

* Update perception/object_recognition/detection/detection_by_tracker/package.xml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* cosmetic change

* cosmetic change

* fix launch

* Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* modify header include order

* change include order

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* change to std::optional

* cosmetic change

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* bug fix

* modify readme

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* sync rc rc/v0.23.0 (autowarefoundation#2219)

* Fix qos in roi cluster fusion (autowarefoundation#2218)

* fix confidence (autowarefoundation#2220)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port roi cluster fusion (autowarefoundation#536)

* remove COLCON_IGNORE

* use DetectedObjectsWithFeature

* fix topic type

* update overwrite condition

* add README of roi_cluster_fusion (autowarefoundation#653)

* add README of roi_cluster_fusion

* fix typo

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add image

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit e002b78f1e1ddf980ee7c4010918f1c117ff4be1.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port to ROS 2

* Fix params file paths

* Re-add autoware_state_monitor

* Update system_launch/launch/system.launch.xml

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Add linters and missing pakcages dependencies (autowarefoundation#37)

* V0.8 system launch (autowarefoundation#51)

* tmp rename launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add system_monitor to system.launch (autowarefoundation#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config file of system_monitor (autowarefoundation#115)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config of diagnostic_aggregator (autowarefoundation#128)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add vehicle cmd gate config (autowarefoundation#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_hold arg (autowarefoundation#142)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix system.launch (autowarefoundation#161)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "tmp rename launch file"

This reverts commit d1bb989eac90f43bab2af6669b00638fd2147eeb.

* fix launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor bug

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update package.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Split system_monitor config (autowarefoundation#98)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change system_monitor.launch.xml to launch.py (autowarefoundation#203)

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update system.launch.xml (autowarefoundation#411)

* Feature/autoware api autoware versions (autowarefoundation#438)

* Add package version API

* Fix message type

* Modify api name

* use let variable in system_launch (autowarefoundation#473)

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Fix diagnostic_aggregator config path (autowarefoundation#118)

* update param

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* Feature/phased timestamped velodyne (autowarefoundation#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (autowarefoundation#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (autowarefoundation#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (autowarefoundation#32)

* Ros2 v0.8.0 sensing launch (autowarefoundation#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (autowarefoundation#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (autowarefoundation#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (autowarefoundation#85)

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (autowarefoundation#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (autowarefoundation#87)

* Fix default value of use_concat_filter and use_radius_search (autowarefoundation#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (autowarefoundation#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (autowarefoundation#97)

* Move individual params to a separate package (autowarefoundation#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (autowarefoundation#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (autowarefoundation#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (autowarefoundation#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (autowarefoundation#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (autowarefoundation#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (autowarefoundation#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (autowarefoundation#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (autowarefoundation#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (autowarefoundation#296)

* add description for sensing_launch (autowarefoundation#336)

* add description

* fix sentence

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (autowarefoundation#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (autowarefoundation#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (autowarefoundation#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (autowarefoundation#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (autowarefoundation#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (autowarefoundation#434)

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (autowarefoundation#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* Modify to use projection matrix with undistorted 2D result (autowarefoundation#722)

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 6e1593f7d630fc1e670df40fe1723890fc238f17.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* ported roi_cluster_fusion from ROS1 to ROS2 (autowarefoundation#118)

compiles succesfully.
Getting some undefined reference error while launching the node.

* Port euclidean cluster (autowarefoundation#120)

* porting CmakeLists.txt and package.xml in progress

* ported CMakeLists.txt and package.xml to ROS2

* Ported euclidean_cluster from ROS1 to ROS2

* deleted unnecesary files

* fixed transient_local

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* hotfix roi_cluster_fusion (autowarefoundation#239)

* Fix perception launches (autowarefoundation#240)

* fix roi_cluster_fusion launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

* add comment on launch

Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com>

Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>

* Ros2 v0.8.0 roi cluster fusion (autowarefoundation#321)

* restore v0.5.0

* Feature/fusion debug (autowarefoundation#1051)

* add debuger

* change param

* add publisher

* Compatible with opencv4 (autowarefoundation#1156)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* refactor for ros2 style

* fix code

* to hpp

* fix code

* uncursify

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* [roi_cluster_fusion]: Avoid redeclaring parameter for compressed image publisher (autowarefoundation#346)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix transform (autowarefoundation#420)

* Replace rclcpp::Time(0) by tf2::TimePointZero() in lookupTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix canTransform

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix test

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo in perception module (autowarefoundation#440)

* add use_sim-time option (autowarefoundation#454)

* Format launch files (autowarefoundation#1219)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add pre-commit (autowarefoundation#1560)

* add pre-commit

* add pre-commit-config

* add additional settings for private repository

* use default pre-commit-config

* update pre-commit setting

* Ignore whitespace for line breaks in markdown

* Update .github/workflows/pre-commit.yml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* exclude svg

* remove pretty-format-json

* add double-quote-string-fixer

* consider COLCON_IGNORE file when seaching modified package

* format file

* pre-commit fixes

* Update pre-commit.yml

* Update .pre-commit-config.yaml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* [roi_cluster_fusion]: Fix poting mistake (autowarefoundation#1624)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix typo & check debugger (autowarefoundation#1511) (autowarefoundation#1625)

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Use set_remap for if tag (autowarefoundation#1800)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply format (autowarefoundation#1999)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix cpplint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Detection by tracker (autowarefoundation#1910)

* initial commit

* backup

* apply format

* cosmetic change

* implement divided under segmenterd clusters

* cosmetic change

* bug fix

* bug fix

* bug fix

* modify launch

* add debug and bug fix

* bug fix

* bug fix

* add no found tracked object

* modify parameters and cmake

* bug fix

* remove debug info

* add readme

* modify clustering launch

* run pre-commit

* cosmetic change

* cosmetic change

* cosmetic change

* apply markdownlint

* modify launch

* modify for cpplint

* modify qos

* change int to size_T

* bug fix

* change perception qos

* Update perception/object_recognition/detection/detection_by_tracker/package.xml

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* cosmetic change

* cosmetic change

* fix launch

* Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* modify header include order

* change include order

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* change to std::optional

* cosmetic change

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* bug fix

* modify readme

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

* sync rc rc/v0.23.0 (autowarefoundation#2219)

* Fix qos in roi cluster fusion (autowarefoundation#2218)

* fix confidence (autowarefoundation#2220)

Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port roi cluster fusion (autowarefoundation#536)

* remove COLCON_IGNORE

* use DetectedObjectsWithFeature

* fix topic type

* update overwrite condition

* add README of roi_cluster_fusion (autowarefoundation#653)

* add README of roi_cluster_fusion

* fix typo

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add image

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: pre-commit <pre-commit@example.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit e002b78f1e1ddf980ee7c4010918f1c117ff4be1.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port to ROS 2

* Fix params file paths

* Re-add autoware_state_monitor

* Update system_launch/launch/system.launch.xml

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Add linters and missing pakcages dependencies (autowarefoundation#37)

* V0.8 system launch (autowarefoundation#51)

* tmp rename launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add system_monitor to system.launch (autowarefoundation#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config file of system_monitor (autowarefoundation#115)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config of diagnostic_aggregator (autowarefoundation#128)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add vehicle cmd gate config (autowarefoundation#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_emergency_hold arg (autowarefoundation#142)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix system.launch (autowarefoundation#161)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "tmp rename launch file"

This reverts commit d1bb989eac90f43bab2af6669b00638fd2147eeb.

* fix launch file

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor bug

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update package.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* update build_depends.repos

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix CI

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Split system_monitor config (autowarefoundation#98)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* change system_monitor.launch.xml to launch.py (autowarefoundation#203)

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update system.launch.xml (autowarefoundation#411)

* Feature/autoware api autoware versions (autowarefoundation#438)

* Add package version API

* Fix message type

* Modify api name

* use let variable in system_launch (autowarefoundation#473)

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Fix diagnostic_aggregator config path (autowarefoundation#118)

* update param

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 4, 2022
* release v0.4.0

* Feature/phased timestamped velodyne (autowarefoundation#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (autowarefoundation#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (autowarefoundation#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (autowarefoundation#32)

* Ros2 v0.8.0 sensing launch (autowarefoundation#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (autowarefoundation#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (autowarefoundation#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (autowarefoundation#85)

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (autowarefoundation#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (autowarefoundation#87)

* Fix default value of use_concat_filter and use_radius_search (autowarefoundation#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (autowarefoundation#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (autowarefoundation#97)

* Move individual params to a separate package (autowarefoundation#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (autowarefoundation#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (autowarefoundation#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (autowarefoundation#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (autowarefoundation#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (autowarefoundation#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (autowarefoundation#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (autowarefoundation#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (autowarefoundation#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (autowarefoundation#296)

* add description for sensing_launch (autowarefoundation#336)

* add description

* fix sentence

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (autowarefoundation#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (autowarefoundation#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (autowarefoundation#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (autowarefoundation#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (autowarefoundation#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (autowarefoundation#434)

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (autowarefoundation#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this issue Oct 5, 2022
…undation#1727) (autowarefoundation#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix readme and default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
kminoda added a commit to kminoda/autoware.universe that referenced this issue Oct 14, 2022
…undation#1727) (autowarefoundation#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix readme and default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue Feb 2, 2023
…undation#1727) (autowarefoundation#118)

* fix(vehicle_velocity_converter): simpify parameter inputs

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix readme and default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* fix default value

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this issue Feb 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
keiota pushed a commit to keiota/autoware.universe that referenced this issue Aug 17, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
knzo25 pushed a commit to knzo25/autoware.universe that referenced this issue May 17, 2024
…utowarefoundation#118)

* fix(log-messages): lower some info message to debug

* fix(log-messages): removing leftover std::cout log from  from the original Velodyne implementation

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>

---------

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants