Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better avoidance drivable areas extension in behavior path planning: Remaining TODO #485

Closed
zulfaqar-azmi-t4 opened this issue Mar 7, 2022 · 2 comments
Closed

better avoidance drivable areas extension in behavior path planning: Remaining TODO #485

zulfaqar-azmi-t4 opened this issue Mar 7, 2022 · 2 comments
Labels
type:new-feature New functionalities or additions, feature requests.

Comments

@zulfaqar-azmi-t4
Copy link
Contributor

zulfaqar-azmi-t4 commented Mar 7, 2022 •
edited
Loading

Remaining TODO:

  1. Code refactoring (removing unnecessary function and make code more concise)
    1. refactor(avoidance_module): change implementation to lambda #486 -- DONE
  2. Create debug new drivable area debug visualization to show extendable areas (allows us to see which areas which has 2 lanelets but the linestring is not shared.
    1. feat(behavior_path_planner): add drivable area visualization to observe shared linestring #499
  3. Visualization improvement.
  4. documentation edit

Related

  1. The implementation feat(route_handler): better avoidance drivable areas extension in behavior path planning #285
  2. Bug fix fix(behavior_path_planner): crash when drivable area expanding #365
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this issue Mar 7, 2022
@taikitanaka3 @mitsudome-r
@fred-apex-ai @nnmm @esteve @tkimura4 @kmiya @wep21 @KeisukeShima @kenji-miyake @kyoichi-sugahara @rej55
feat: add shift decider (autowarefoundation#29)
2ab1ade 
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add sample ros2 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit bcc60bdc82842e2ea4d1e844b4442fa613d80fdf.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port shift decider to ros2 (#7)

* Update package.xml and CMakeLists.txt to ros2

Code doesn't compile yet

* Code compiles

* Update launch file

* Add better timer

clang-format shift_decider

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* Added linters to shift_decider (autowarefoundation#167)

* Added linters to shift_decider

* Fix dependencies

* Use ament_cmake_cppcheck and ament_cmake_cpplint

* Fix linting errors

* add use_sim-time option (autowarefoundation#454)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Make control modules components (autowarefoundation#1262)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port shift decider (autowarefoundation#485)

* port shift decider

* apply clang format

* delete colcon ignore

* change to ackermann control command

* remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549)

* fix autoware_error_monitor

* fix state monitor

* fix emergency handler(vehicle_state_report)

* fix emergency Handler(vehicle_state_command)

* fix shift_decider

* fix emergency_handler(vehicle_control_command)

* fix topic name

* fix readme

* Update system/autoware_state_monitor/Readme.md

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix format

* Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix typo

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* [shift decider] add README.md (autowarefoundation#577)

* add readme to shift decider

* better expression

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Fix topic name (autowarefoundation#673)

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Sugatyon <32741405+Sugatyon@users.noreply.github.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
This was referenced Mar 7, 2022
Merged
Merged
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 mentioned this issue Apr 7, 2022
Merged
8 tasks
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 mentioned this issue Apr 15, 2022
Merged
7 tasks
@zulfaqar-azmi-t4
Copy link
Contributor Author

Adding debug message to show reason for failure.
This is to simplify debugging on field as the field integrator members can just echo the message directly using ros2 topic echo.

@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@zulfaqar-azmi-t4
Copy link
Contributor Author

Since the debug messages is already included in the avoidance module, the TODO list is considered completed.

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this issue Oct 5, 2022
@tier4-autoware-private-bot @kenji-miyake
Auto-update pre-commit hooks (autowarefoundation#485)
3f75be9 
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this issue May 17, 2023
@tkimura4
Merge pull request autowarefoundation#485 from tier4/feat/update_goal…
8785c2b 
…_planner_0.8

feat(behavior_path_planner): update and fix goal_planner
keiota pushed a commit to keiota/autoware.universe that referenced this issue Aug 17, 2023
@soblin
feat(intersection): extract occlusion contour as polygon (autowarefou…
91d4afb 
…ndation#485)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara pushed a commit that referenced this issue Sep 16, 2023
@scepter914
fix: rename ARS408 driver branch name (#485)
69b2e12
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this issue Mar 8, 2024
@TomohitoAndo
chore: update hash of individual params (autowarefoundation#485)
6b83ddf 
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BonoloAWF @zulfaqar-azmi-t4