-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance_module): change implementation to lambda #486
refactor(avoidance_module): change implementation to lambda #486
Conversation
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
=========================================
- Coverage 10.94% 2.85% -8.09%
=========================================
Files 704 110 -594
Lines 49690 10702 -38988
Branches 6655 1101 -5554
=========================================
- Hits 5440 306 -5134
+ Misses 39888 10252 -29636
+ Partials 4362 144 -4218
Continue to review full report at Codecov.
|
4c8a3bf
to
ec7459f
Compare
165de1e
to
957079c
Compare
In the generateExtendedDrivableArea function, the implementation to extend drivable areas with reference to object is refactor to lambda. This will allow the function to be used for some future planned updates. The refactor doesn't affect the behavior of the avoidance_module. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
By default, the parameter is true, therefore it doesn't affect the original behavior. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
The implementation is made into function and moved into route handler Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
50e717a
to
65313d4
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also modified some avoidance_module to include the refactored functions Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* refactor(avoidance_module): change implementation to lambda In the generateExtendedDrivableArea function, the implementation to extend drivable areas with reference to object is refactor to lambda. This will allow the function to be used for some future planned updates. The refactor doesn't affect the behavior of the avoidance_module. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: add default flag to extend_to_opposite side By default, the parameter is true, therefore it doesn't affect the original behavior. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * ci(pre-commit): autofix * fix: rework function for better extension Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor(route handler, avoidance_module): move the implementation The implementation is made into function and moved into route handler Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: convert lambdas to function Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: add comments for comments for documentation in the header file Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: local variable rename Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: make a wrapper function to get furthest linestrings Also modified some avoidance_module to include the refactored functions Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(avoidance_module): change implementation to lambda In the generateExtendedDrivableArea function, the implementation to extend drivable areas with reference to object is refactor to lambda. This will allow the function to be used for some future planned updates. The refactor doesn't affect the behavior of the avoidance_module. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: add default flag to extend_to_opposite side By default, the parameter is true, therefore it doesn't affect the original behavior. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * ci(pre-commit): autofix * fix: rework function for better extension Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor(route handler, avoidance_module): move the implementation The implementation is made into function and moved into route handler Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: convert lambdas to function Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: add comments for comments for documentation in the header file Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: local variable rename Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: make a wrapper function to get furthest linestrings Also modified some avoidance_module to include the refactored functions Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(avoidance_module): change implementation to lambda In the generateExtendedDrivableArea function, the implementation to extend drivable areas with reference to object is refactor to lambda. This will allow the function to be used for some future planned updates. The refactor doesn't affect the behavior of the avoidance_module. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: add default flag to extend_to_opposite side By default, the parameter is true, therefore it doesn't affect the original behavior. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * ci(pre-commit): autofix * fix: rework function for better extension Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor(route handler, avoidance_module): move the implementation The implementation is made into function and moved into route handler Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: convert lambdas to function Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: add comments for comments for documentation in the header file Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactor: local variable rename Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * refactor: make a wrapper function to get furthest linestrings Also modified some avoidance_module to include the refactored functions Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* add rviz helper for ad api Signed-off-by: khtan <tkh.my.p@gmail.com> * sync for init pose Signed-off-by: khtan <tkh.my.p@gmail.com> * add missing sync Signed-off-by: khtan <tkh.my.p@gmail.com> * add rviz adaptor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix launch_dummy_localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * add dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: khtan <tkh.my.p@gmail.com> Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chore: sync upstream
Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
In the generateExtendedDrivableArea function, the implementation to extend
drivable areas with reference to object is moved to
route_handler
library.This will allow the function to be reused for some future planned updates.
The refactor doesn't affect the behavior of the avoidance_module.
Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp
Related Issue(required)
#485
#499
Description(required)
Refactoring the function so that the intent is much more clear, therefore it doensn't affect the behavior of the avoidance_module.
This also allows the function to be reused for debug visualization if necessary.
Review Procedure(required)
See build pass (no behavior change)
Related PR(optional)
#285
#365
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks