fix(behavior_path_planner): crash when drivable area expanding #365

zulfaqar-azmi-t4 · 2022-02-09T02:51:30Z

This is to fix the behavior path planner crash when the drivable area is
expanding towards opposite direction lane

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

Related Issue(required)

Description(required)

The behavior path planner node crashes when the obstacle is in this position.

The PR aims to solve this issue.

Review Procedure(required)

Place ego vehicle and obstacle here. Check if the node crashes.

Related PR(optional)

#287

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Read commit-guidelines
Assign PR to reviewer

If you are adding new package following items are required:

Documentation with description of the package is available
A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Commits are properly organized and messages are according to the guideline
PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR / build-and-test-pr: Required to pass before the merge.
Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

This is to fix the behavior path planner crash when the drivable area is expanding towards opposite direction lane Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

taikitanaka3 · 2022-02-09T03:02:20Z

@zulfaqar-azmi-t4
can you also check this case?

codecov · 2022-02-09T03:05:51Z

Codecov Report

Merging #365 (89f2abb) into tier4/proposal (a9c47ef) will decrease coverage by 9.30%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           tier4/proposal    #365      +/-   ##
=================================================
- Coverage            9.30%   0.00%   -9.31%     
=================================================
  Files                 701      34     -667     
  Lines               48911    4783   -44128     
  Branches             5807       0    -5807     
=================================================
- Hits                 4549       0    -4549     
+ Misses              40551    4783   -35768     
+ Partials             3811       0    -3811

Impacted Files	Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp	`0.00% <ø> (ø)`
...tion/traffic_light_classifier/utils/trt_common.cpp
localization/ndt/include/ndt/omp.hpp
...tem/velodyne_monitor/src/velodyne_monitor_node.cpp
...ehicle_rviz_plugin/src/tools/jsk_overlay_utils.cpp
...ace/src/pacmod_interface/pacmod_diag_publisher.cpp
map/lanelet2_extension/lib/no_stopping_area.cpp
...ure_pursuit/src/pure_pursuit/pure_pursuit_node.cpp
...ure_pursuit/include/pure_pursuit/util/tf_utils.hpp
...nal_processing/test/src/lowpass_filter_1d_test.cpp
... and 658 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c47ef...89f2abb. Read the comment docs.

zulfaqar-azmi-t4 · 2022-02-09T03:09:30Z

@zulfaqar-azmi-t4 can you also check this case?

Yes, I've check there seems to be no problem so far.

zulfaqar-azmi-t4 · 2022-02-09T03:12:05Z

planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

@@ -1682,22 +1682,26 @@ void AvoidanceModule::generateExtendedDrivableArea(ShiftedPath * shifted_path) c
          extended_lanelets.push_back(lanelet_at_left.get());
          lanelet_at_left = route_handler->getLeftLanelet(lanelet_at_left.get());
        }
-        auto lanelet_at_right =
-          planner_data_->route_handler->getRightLanelet(lanelet_at_left.get());


@taikitanaka3
This is the cause of the issue.
Since lanelet_at_left might be empty (optional), it cause the crash when we try accessing them.
Adding if will check the availability of the lanelet first before accessing them.

taikitanaka3

LGTM

taikitanaka3 · 2022-02-09T03:33:48Z

@zulfaqar-azmi-t4
can you write this to release note?
https://tier4.atlassian.net/wiki/spaces/AIP/pages/2255913621

taikitanaka3 · 2022-02-09T04:52:55Z

cc: @yukkysaito

…arefoundation#365) This is to fix the behavior path planner crash when the drivable area is expanding towards opposite direction lane Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

…arefoundation#365) This is to fix the behavior path planner crash when the drivable area is expanding towards opposite direction lane Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* release v0.4.0 * add obstacle avoid param (autowarefoundation#62) * Feature/add stop reason lane change (autowarefoundation#69) * add blocked by obstacle * add stop reason topic to lane change planner * Revert "add blocked by obstacle" This reverts commit 1f5ecdb30c04f7ee70a4b3271bb2099c44752801. * removed ROS1 package Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "removed ROS1 package" This reverts commit c914e2e16fed7726f8748e1f936b061f051eaf8f. * add COLCON_IGNORE file to all ROS1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * rename *.launch files to *.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * port planning launch Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add missing porting Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * replace rostopic pub with executable in behavior_planning.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix remapping of topics in launch files Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * modify integer parameters to double parameters Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix arguments in parking.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * fix remapping of topics in scenario_planning.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * ROS2 Linting: planning_launch (autowarefoundation#38) * Ros2 port autoware launch (autowarefoundation#35) * [autoware_launch] port CMakelists.txt and remove COLCON_IGNORE Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] fix planning_simulator.launch.xml Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] add rviz config Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * [autoware_launch] first port of autoware_launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * lanuch rviz with config file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * modify launch file for making psim work Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * add vehicle model in launch Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * change from vehicle_model to vehicle_param_file Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * [autoware_launch] add autoware_web_controller and system launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add rosbrdige_suite to build_depends.repos Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Update rviz Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update autoware.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove autoware_ros2.rviz Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: kosuke murakami <kosuke.murakami@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 planning launch (autowarefoundation#59) * [planning_launch] restore file name for ros2 porting Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Add obstacle_stop_planner.yaml (autowarefoundation#82) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add surround obstacle checker options (autowarefoundation#86) * fix slow down param related to tier4/autoware.iv@a9cdcb2 (autowarefoundation#91) * fix parame max_steer_deg (autowarefoundation#92) * add refine_goal_search_radius_range (autowarefoundation#93) * Change default evaluation in motion velocity optimizer (autowarefoundation#97) * Use Linf * Add new line * Add maximum_deceleration parameter (autowarefoundation#98) * Add maximum_deceleration parameter * Change default value * Unable abort lane change (autowarefoundation#102) * add param stoping velocity and fix typo (autowarefoundation#106) * Add a parameter for minimum velocity for lane change (autowarefoundation#109) * Add parameters for collision check for lane change (autowarefoundation#110) * Add a parameter for disable collision check at prepare phase * Add parameters for collision check with predicted_path * Add a parameter for backward buffer for end of lane (autowarefoundation#114) * Add parameters for backward buffer for end of lane * Remove comment out * add extend_distance param (autowarefoundation#107) * add parameter of acc (autowarefoundation#129) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> * fix typo & change static object velocity thres in lane_change_planner (autowarefoundation#104) * change static object velocity thres Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * fix typo Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Change minimum_lane_change_velocity (autowarefoundation#131) * Feature/update avoidance param (autowarefoundation#140) * update avoidance param Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * disable unnecesarry marker Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * modify min_behavior_stop_margin (autowarefoundation#127) * modify min_behavior_stop_margin Signed-off-by: Yamato Ando <yamato.ando@gmail.com> * Update obstacle_stop_planner.yaml Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Add expand_stop_range to obstacle_stop_planner.yaml (autowarefoundation#152) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Update obstacle_stop_planner.yaml (autowarefoundation#153) * Visualize echo back goal_pose instead of 2D Nav Goal (autowarefoundation#150) * Visualize echo back goal_pose instead of 2D Nav Goal Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mission_planning.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add surround_obstacle_checker.yaml (autowarefoundation#157) * Add parameter (autowarefoundation#158) * Revert "[planning_launch] restore file name for ros2 porting" This reverts commit 275f0df232323bf24627adea9cb08888c250625e. * fix namespace Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix relay Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * [planning_launch]: Add vehicle_param_file for turn signal decider Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [planning_launch]: Change topic type of lane change approval Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Satoshi Tanaka <st14.828soccer@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: hiroaki-ishikawa-t4 <57431939+hiroaki-ishikawa-t4@users.noreply.github.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Ros2 v0.8.0 fix packages (autowarefoundation#64) * add vehicle_param_file to simple planning simulator * add vehicle_param_file to lane change planner * Rename ROS-related .yaml to .param.yaml (autowarefoundation#65) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing '--' Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix livox param name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 update v0.9.0 (autowarefoundation#67) * Add pose history into rviz config Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add blocked by obstacle option (autowarefoundation#164) * fix tab name (autowarefoundation#166) * disenable ndt visualization (autowarefoundation#169) * disenable ndt visualization * change alpha * dont visualize position covariance Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * change global frame to map (autowarefoundation#171) * add param (autowarefoundation#156) Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Ros2 fix topic name part1 (autowarefoundation#83) * Fix topic name for behavior_velocity_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of lane_change_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for freespace_planner Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix typo in planning launch (autowarefoundation#92) * Fix typo in planning launch * Fix remaining errors * Fix various typos in launch files (autowarefoundation#97) * add use_sim-time option (autowarefoundation#99) * Format launch files (autowarefoundation#178) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Sync public repo (autowarefoundation#185) * add tier4 usbcam (autowarefoundation#104) * add tier4 usbcam * change version * tier4/ros2 * Ros2 vehicle info param server (autowarefoundation#96) * add vehicle info param server * delete vehicle param file Co-authored-by: taikitanaka <ttatcoder@outlook.jp> * Ros2 fix topic name part2 (autowarefoundation#89) * Fix topic name for traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_visualization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name for traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> * Ros2 lsim test (autowarefoundation#186) * Add group to launch file for var scope Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add use_sim_time Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove pointcloud relay for localization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Use set_parameter for use_sim_time (autowarefoundation#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add container launch for planning (autowarefoundation#205) * Add container launch for planning Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix porting miss * fix lane_driving.launch.xml * Add missing parameters Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: taichiH <azumade.30@gmail.com> * Rename AstarNavi to FreespacePlannerNode (autowarefoundation#213) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typos in launch files (autowarefoundation#231) * Fix typos in launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Format launch files (autowarefoundation#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix topic name of external traffic light input (autowarefoundation#236) * Add namespace to behavior_velocity_planner (autowarefoundation#252) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typo applygin->applying (autowarefoundation#304) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add description for planning_launch autowarefoundation#335 * add README.md and svg files (autowarefoundation#328) * add md and svg * fix typo * fix typo * fix word * fix typo * add lack of things * Update README * fix depending packages * fix word * Add autoware api (autowarefoundation#376) * Add external api adaptor (autowarefoundation#267) * Add external api adaptor * Add api adaptor to logging simulator Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add engage status output Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add internal api adaptor (autowarefoundation#273) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add map hash generator (autowarefoundation#319) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add autoware api launch (autowarefoundation#326) * Add autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Apply autoware api launch Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add deprecated comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove unused parameter (autowarefoundation#325) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add api parameter (autowarefoundation#341) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add start request API (autowarefoundation#321) * Add use start request option Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Feature external cmd selector heartbeat (autowarefoundation#356) * Rename external command topic Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Modify command topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename remote_cmd_converter Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Remove gate mode from external command Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix latest external command name (autowarefoundation#361) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix merge conflict Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * change external traffic light topic name in behavior velocity planner (autowarefoundation#310) * fix topic * change internal topic name Co-authored-by: yabuta <makoto.yabuta@tier4.jp> * Merge pull request autowarefoundation#359 from tier4/feature/add_plannig_error_monitor (autowarefoundation#365) * Feature/add virtual traffic light planner (autowarefoundation#317) * Fix pre-commit (autowarefoundation#407) * Fix pre-commit errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix parameter name (autowarefoundation#470) * Feature/porting behavior path planner (autowarefoundation#300) * modify behavior_planning launch for behavior_path_planner with lane_c… (autowarefoundation#239) * modify behavior_planning launch for behavior_path_planner with lane_change_only config Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * remove avoidance & side_shift related code Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix launcher and add config files and change obstacle avoid param * Add new line * Fix visualization and remove multiple args * Enable auto approve path change Co-authored-by: rej55 <rej55.g@gmail.com> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add param in behavior_path_planner (autowarefoundation#255) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix param (autowarefoundation#251) * Fix typo Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: rej55 <rej55.g@gmail.com> * Feature/porting motion velocity smoother (autowarefoundation#302) * Launch motion_velocity_smoother (autowarefoundation#215) * Launch motion_velocity_smoother * Change params * Fix parameter files * Fix Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix/smoother trajectory ds (autowarefoundation#249) * Add parameter * Fix * Fix * change launcher parameter (autowarefoundation#265) * Feature/smoother resampling (autowarefoundation#269) * change launcher parameter * add new parameter Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> * Master sync parking module (autowarefoundation#303) * Add namespace Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add freespace planner config file Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing import Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * update rviz config & planner params (autowarefoundation#305) Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> * Feature/porting occlusion spot (autowarefoundation#309) * add occulusion_spot marker (autowarefoundation#266) * add blindspot marker * to occlusion spot slow down * remove debug info from marker (autowarefoundation#287) * remove debug info from marker * remove debug arrow * fix format * update behavior launch * apply pep8 * fix format Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Use multithread for lane driving planning (autowarefoundation#327) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix import order of parking.launch.py (autowarefoundation#347) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add analytical smoother config (autowarefoundation#360) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * update acc param (autowarefoundation#358) * add rosparam for vehicle center optimization (autowarefoundation#362) * update ros param for .iv (autowarefoundation#353) * update ros param for .iv * forward fixing mpt time: 3.0->1.0 * Fix/obstacle avoid revert some improvements (autowarefoundation#381) * Revert "update ros param for .iv (autowarefoundation#353)" This reverts commit f7f341a. * Revert "add rosparam for vehicle center optimization (autowarefoundation#362)" This reverts commit 78bbf70. * update side shift param (autowarefoundation#370) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add yaml & load lane following params (autowarefoundation#377) * add pull over/out module (autowarefoundation#430) add yaml file and modify BT tree file path modify parameter file add parameter add use_dynamic_object flag in pull out param delete unncesarry parameters delete unnecessary param merge change for jpntaxi delete blank line modify BT file name modify launch file * Update behavior path planner launch files (autowarefoundation#433) * update launch parameters for behavior_path_planner Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * update param at experiment Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix typo Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix indent Co-authored-by: TakaHoribe <horibe.takamasa@gmail.com> * Fix for pre-commit (437) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * change threshold_distance_object_is_on_center to 1.0 (autowarefoundation#441) Signed-off-by: TakaHoribe <horibe.takamasa@gmail.com> * delete optimizer (autowarefoundation#456) * add params for acceleration prevention (autowarefoundation#454) (autowarefoundation#457) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Feature/use external velocity limit selector (autowarefoundation#460) * use external velocity limit selector * add common planning params * update yaml params * Feature/add slow down params (autowarefoundation#448) * add/update slow down params * topic remap * update topic name * Fix/use common param (autowarefoundation#465) * Change formatter to black (autowarefoundation#488) * Update pre-commit settings * Apply Black * Replace ament_lint_common with autoware_lint_common * Update build_depends.repos * Fix build_depends * twist -> odometry (autowarefoundation#109) Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> * Auto/fix launch (autowarefoundation#110) * fix namespace * remove dynamic_object_visualization * fix rviz * remove unused depend/launcher (autowarefoundation#112) * Fix remapping in control.launch.py (autowarefoundation#115) * Fix remappings * Add comment * Sync .auto branch with the latest branch in internal repository (autowarefoundation#120) * Disbale intersection polygon marker (autowarefoundation#483) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area Feature/no stopping area Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Update traffic light topic name (autowarefoundation#131) * Update traffic light topic name Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update traffic light topic name in perception Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix no ground pointcloud topic name (autowarefoundation#134) Signed-off-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> * auto/fix occupancy grid map topic name (autowarefoundation#137) * fix/rename segmentation namespace (autowarefoundation#139) * fix namespace: rviz config * fix namespace: planning stack * rename segmentatino directory * fix namespace: perception stack * add vehicle info parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * ci(pre-commit): autofix * remove unused import * remove unused import Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@tier4.jp> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Satoshi Tanaka <st14.828soccer@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: hiroaki-ishikawa-t4 <57431939+hiroaki-ishikawa-t4@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: taichiH <azumade.30@gmail.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: purewater0901 <43805014+purewater0901@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: satoshi-ota <satoshi.ota@gmail.com> Co-authored-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: kyoichi sugahara <81.s.kyo.19@gmail.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* release v0.4.0 * Change localization diag namespace (autowarefoundation#718) * Change default value of output_diagnostics_topic Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove localization_diagnostic.js from web_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Integrate localization diag to diagnostic_aggregator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Delete old and unused publisher Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 63dc7f4e1defe5fd908eeefc7a2cdfac7cb47022. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * ROS2 Porting: autoware_error_monitor (autowarefoundation#42) * Temporary add the autoware_error_monitor package for conversion * Renaming to adhere to convention - Modify CMakeList to compile using ROS2 - TODO: fix FMT import * Replace node implementation with ROS2 version - Rename core - Fix FMT library linking and ROS-related compilation erros - Add Readme - Add publisher and subscribers - Add timer * Launch configurationse - Add ROS2 launch file - Modify config file with ROS2 conventions - Convert package.xml - Fix CMakelist - Bug fixes - Launch file correct indentation - Fix param.yaml to not use nested lists - Use as_string_array() when getting string array parameters * Remove old files * Fix cmake and package xml - Use ament cmake auto * Fix parameters - Use dots as delimiters for nested parameter names - Move parameter declaration to constructor initialization list where possible - Update parameter file - Update launch files * Fix launch and param files - Aggregator node doesn't appear to be working as expected with the launch files... - Fix cmake - Aggregator doesn't seem to allow multiple top level diagnostics * Fix config * Add rqt_robot_monitor to exec depends in package.xml * Update rate should be converted to a period Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Address PR comment: - Change top level namespace to autoware * Remove commented out code * Address PR comment: - Fix root for keys - Correct update rate Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Add linter tests (autowarefoundation#204) * Ros2 v0.8.0 autoware error monitor (autowarefoundation#281) * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 v0.8.0 fix packages2 (autowarefoundation#354) * fix topic name * fix duration rate * fix sensing.yaml * fix topic name * add latch-option to autoware_state_monitor * fix timer callback * fix autoware state monitor config * fix sensing.yaml * Fix autoware error monitor (autowarefoundation#362) * Remove cpu_load_average Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Disable resource monitoring in planning_simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix diagnostic_aggregator's params Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [Update v0.9.0] system monitor (autowarefoundation#365) * Disable CPU Load Average warning. (autowarefoundation#1147) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Fix cpu_monitor respawning forever. (autowarefoundation#1150) * Disable cpu_temperature in planning simulation (autowarefoundation#1151) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Net Monitor: Handle as an error if specified device not exist. (autowarefoundation#1152) * Handled as an error if specified device not exist. * Disable network diags in simulation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * apply ament_uncrustify Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Disable resource monitoring in planning_simulator (autowarefoundation#1172) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Treat logging errors as safe faults (autowarefoundation#1164) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix test code of system_monitor (autowarefoundation#1178) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Import v0.9.1 (autowarefoundation#431) * add local optimal solution ocillation check to ndt_scan_matcher (autowarefoundation#1182) * Add obstacle_crush diagnostic (autowarefoundation#1186) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix diagnostics api (autowarefoundation#1185) * Fix diagnostics api Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Don't overwrite level Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Overwrite level of No Fault diagnostics Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing diag in autoware_error_monitor.yaml (autowarefoundation#1187) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Filter hazard_status (autowarefoundation#1191) * Filter hazard_status Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Filter leaf diagnostics Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix wrong calculation of available memory. (autowarefoundation#1168) * Fixed wrong calculation of available memory. * Added comments about output example of free -tb command. * Change monitoring method to get HDD temperature and usage per specified device. (autowarefoundation#1195) * Changed monitoring method to get temperature and usage per specified device. * Fixed test codes. * Removed unnecessary (void) parameter. * return input pointcloud when ground plane not found (autowarefoundation#1190) * fix yaw-smoothing bug (autowarefoundation#1198) * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix typo in system module (autowarefoundation#434) * Fix typo in system module * Change variable name * Move comments * Apply uncrustify * add use_sim-time option (autowarefoundation#454) * Treat NTP offset error as safe fault (autowarefoundation#1220) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for rolling (autowarefoundation#1226) * Replace doc by description Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Replace ns by push-ros-namespace Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix/fix porting miss (autowarefoundation#1254) * Fix porting miss of vehicle_cmd_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake of autoware_error_monitor.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * error monitor for foa controller (autowarefoundation#1369) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add diagnostics config for ros2_socketcan (autowarefoundation#1447) * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix typo (autowarefoundation#1711) * suppress warnings for declare parameters (autowarefoundation#1724) * fix for lanelet2_extension * fix for traffic light ssd fine detector * fix for topic_state_monitor * fix for dummy diag publisher * fix for remote cmd converter * fix for vehicle_info_util * fix for multi object tracker * fix for freespace planner * fix for autoware_error_monitor * add Werror for multi object tracker * fix for multi object tracker * add Werror for liraffic light ssd fine detector * add Werror for topic state monitor * add Werror * add Werror * add Werror * add Werror * fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * enable autonomous recovery (autowarefoundation#1904) * add aggregator config at planing error monitor (autowarefoundation#1955) (autowarefoundation#1963) * add trajectory monitoring setting (autowarefoundation#2018) * Fix typo `obstacle_crush` to `obstacle_crash` (autowarefoundation#2031) * Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030) * Use EmergencyState instead of deprecated EmergencyMode Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use stamped type Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Sync rc v1.5.0 (autowarefoundation#2058) * Cleanup autoware_error_monitor launch (autowarefoundation#2143) * Improve diagnostic tree for future extensions (autowarefoundation#2153) * change resource monitoring group * implement diagnostic tree proposal * rename v2x param file * add v2x to launch * add dummy analyzer to avoid format error * modify external control * rename vehicle_ecu_errors * fixup * remove num_items * fix error * add heartbeat to external command selector * Restore sensing/node_alive_monitoring * Update system/autoware_error_monitor/config/diagnostic_aggregator/sensing.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * add sensor_kit arg for diagnostic_agg * change sensor_kit's default value * add _ prefix to hide parameter file * delete dummy parameter * change to use update_functions * add extra_agg_config_file_vehicle * change initializer * remove line * Update system/autoware_error_monitor/config/diagnostic_aggregator/system.param.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * change hearbeat diag * add clock group * update sensing diag * Remove discard and v2x Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix heartbeat name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_control to external_control Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename command_gate to control_command_gate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Simplify resource monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove sensing from autoware_error_monitor.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove trajectory_deviation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove vehicle specific settings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add blank lines Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore matching_score error Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove debug_data_logger Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add trajectory_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Specify children for performance_monitoring Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Comment out route_validation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Revert "Remove trajectory_deviation" This reverts commit 199132f1a6c7083440f0ef9a956b0663d45f4531. * Remove control_command_topic_status Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Disable some diagnostics for planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add TODO comment Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Enable /autoware/vehicle/node_alive_monitoring in planning simulator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change autoware_error_monitor config format (autowarefoundation#2244) * Change autoware_error_monitor config file use automatically_declare_parameters_from_overrides Change yaml format replace default value move nodeoption to core simplify parameter splitting code use set fix to use at function merge for loop add explanation for new format fix default value replace DiagLevel Update system/autoware_error_monitor/src/autoware_error_monitor_core.cpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Update system/autoware_error_monitor/src/autoware_error_monitor_core.cpp Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> use fmt change to use uniform initialization * Change autoware_error_monitor config file * Fix format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * support .auto message (autowarefoundation#529) * remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549) * fix autoware_error_monitor * fix state monitor * fix emergency handler(vehicle_state_report) * fix emergency Handler(vehicle_state_command) * fix shift_decider * fix emergency_handler(vehicle_control_command) * fix topic name * fix readme * Update system/autoware_state_monitor/Readme.md Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix format * Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix typo Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Fix autoware monitors readme (autowarefoundation#629) * Fix readme of autoware_state_monitor * Fix readme of autoware_error_monitor Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: s-murakami-esol <81723883+s-murakami-esol@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

* release v0.4.0 * Fixed uninitialized variable. (autowarefoundation#763) * Fixed various bugs. (autowarefoundation#768) * Fixed various bugs. * Fixed wrong status report of NIC. * Added the mode of CPU Usage to check statistics calculated as averages among all processors by default. (autowarefoundation#788) * fix uninitialized variables (autowarefoundation#816) * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit a9436882d50dc09fa5b8d6c0a151a10def76b242. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Port system monitor to ros2 (autowarefoundation#71) * Implement a utility function that spins and updates a monitor node. * Port cpu monitor * Port hdd monitor. * Port mem_monitor to ROS2 * Port net_monitor to ROS2 * Port ntp_monitor to ROS2 * Port process_monitor to ROS2 * Port GPU_monitor to ROS2 * Port msr_reader and hdd_reader to ROS2 * Clean up the build and launch files: * Clean up and comment on CMake and package files. * Port the launch file to ROS2 * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: system_monitor (autowarefoundation#207) * Add linters * Fix clang-tidy error in util.hpp * Ros2 v0.8.0 system monitor (autowarefoundation#276) * fix dependency of system_monitor Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Exclude SwPowerCap as an error. (autowarefoundation#1146) (autowarefoundation#364) Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> * [Update v0.9.0] system monitor (autowarefoundation#365) * Disable CPU Load Average warning. (autowarefoundation#1147) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Fix cpu_monitor respawning forever. (autowarefoundation#1150) * Disable cpu_temperature in planning simulation (autowarefoundation#1151) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Net Monitor: Handle as an error if specified device not exist. (autowarefoundation#1152) * Handled as an error if specified device not exist. * Disable network diags in simulation Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * apply ament_uncrustify Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Disable resource monitoring in planning_simulator (autowarefoundation#1172) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Treat logging errors as safe faults (autowarefoundation#1164) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix test code of system_monitor (autowarefoundation#1178) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Use thread for ntpdate. (autowarefoundation#1160) (autowarefoundation#375) * Use thread for ntpdate. (autowarefoundation#1160) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * removed unused variable Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Import v0.9.1 (autowarefoundation#431) * add local optimal solution ocillation check to ndt_scan_matcher (autowarefoundation#1182) * Add obstacle_crush diagnostic (autowarefoundation#1186) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix diagnostics api (autowarefoundation#1185) * Fix diagnostics api Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Don't overwrite level Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Overwrite level of No Fault diagnostics Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add missing diag in autoware_error_monitor.yaml (autowarefoundation#1187) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Filter hazard_status (autowarefoundation#1191) * Filter hazard_status Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Filter leaf diagnostics Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix wrong calculation of available memory. (autowarefoundation#1168) * Fixed wrong calculation of available memory. * Added comments about output example of free -tb command. * Change monitoring method to get HDD temperature and usage per specified device. (autowarefoundation#1195) * Changed monitoring method to get temperature and usage per specified device. * Fixed test codes. * Removed unnecessary (void) parameter. * return input pointcloud when ground plane not found (autowarefoundation#1190) * fix yaw-smoothing bug (autowarefoundation#1198) * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> * Fix typo in system module (autowarefoundation#434) * Fix typo in system module * Change variable name * Move comments * Apply uncrustify * Split system_monitor config (autowarefoundation#452) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove unnecessary diagnostic update. (autowarefoundation#455) * add use_sim-time option (autowarefoundation#454) * Sync public repo (autowarefoundation#1228) * [simple_planning_simulator] add readme (autowarefoundation#424) * add readme of simple_planning_simulator Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Update simulator/simple_planning_simulator/README.md * set transit_margin_time to intersect. planner (autowarefoundation#460) * Fix pose2twist (autowarefoundation#462) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Ros2 vehicle info param server (autowarefoundation#447) * add vehicle_info_param_server * update vehicle info * apply format * fix bug * skip unnecessary search * delete vehicle param file * fix bug * Ros2 fix topic name part2 (autowarefoundation#425) * Fix topic name of traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of traffic_light_visualization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix topic name of traffic_light_map_based_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint traffic_light_recognition Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint traffic_light_classifier Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix lint traffic_light_ssd_fine_detector Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Fix issues in hdd_reader (autowarefoundation#466) * Fix some issues detected by Coverity Scan and Clang-Tidy * Update launch command * Add more `close(new_sock)` * Simplify the definitions of struct * fix: re-construct laneletMapLayer for reindex RTree (autowarefoundation#463) * Rviz overlay render fix (autowarefoundation#461) * Moved painiting in SteeringAngle plugin to update() Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * super class now back to MFD Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * uncrustified Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * acquire data in mutex Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * back to RTD as superclass Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Rviz overlay render in update (autowarefoundation#465) * Moved painiting in SteeringAngle plugin to update() Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * super class now back to MFD Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * uncrustified Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * acquire data in mutex Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * removed unnecessary includes and some dead code Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * Adepted remaining vehicle plugin classes to render-in-update concept. Returned to MFD superclass Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> * restored RTD superclass Signed-off-by: Adam Dabrowski <adam.dabrowski@robotec.ai> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Fix issues in gpu_monitor (autowarefoundation#1248) * Fix issues in gpu_monitor * Fix uninitialized variables * Use range-based for loop * Fix compile errors of tegra_gpu_monitor * Replace C-style to C++-style * Make iterators const * Fix fmt::format() usage error * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [system_monitor] change some nodes into components (autowarefoundation#1234) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Takeshi Miura <takeshi.miura@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add system_monitor.launch.py (autowarefoundation#1238) * add system_monitor.launch.py * refactor system_monitor.launch.py * fix launch bug * fix typo * fix launch py * fix param loading * format code * fix system monitor executor to publish diagnostics asynclonously (autowarefoundation#1283) * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add kernel CPU usage. (autowarefoundation#1465) * Add kernel CPU usage. * Change CPU x: usage to CPU x: total. * Changed variable name. * Add markdownlint and prettier (autowarefoundation#1661) * Add markdownlint and prettier Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for system monitor (autowarefoundation#1723) * fix for hdd_monitor * fix no initialization and warning * change command for ntp_monitor (autowarefoundation#1705) * [EVT4-403] change command for ntp_monitor * [EVT4-403] fixed CI build error * [EVT4-403] fixed cpplint error * delete executeChronyc thread, fix error topic and log output code * fix cpplint error and code style divergence * fix cpplint error(missing correction) * Fix MD029 (autowarefoundation#1813) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * add gpu usage per process (autowarefoundation#1798) * add gpu usage per process * change illegal usage(4294967295%) to 0%, and fix CI running errors * Replace gettimeofday with rclcpp::Node::now(). * Fix uncrustify error. * Replace rclcpp::Node::now() with rclcpp::Clock(RCL_SYSTEM_TIME). Co-authored-by: ito-san <fumihito.ito@tier4.jp> * fix some typos (autowarefoundation#1941) * fix some typos * fix typo * Fix typo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * suppress warnings for system directory autowarefoundation#2046 * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Add execution time logging. (autowarefoundation#2066) * Add markdown-link-check pre-commit (autowarefoundation#2215) * add markdown-lint-check pre-commit * delete files argument * add optional hook * modify comment * add comment * delete hook * add retry option * add option * add files arg * Fix links in hdd_reader.md Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore 403 Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore tier4 github url Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Update link Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove COLCON_IGNORE in system_packages and map_tf_generator (autowarefoundation#532) Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: ito-san <57388357+ito-san@users.noreply.github.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Yunus Emre Çalışkan <yunus.ec@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Makoto Tokunaga <vios-fish@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: Takeshi Miura <takeshi.miura@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: v-kitahara8153 <86092199+v-kitahara8153@users.noreply.github.com> Co-authored-by: ito-san <fumihito.ito@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

…nig_error_monitor (autowarefoundation#365)

…tion (autowarefoundation#365) * resolve conflict Signed-off-by: kminoda <koji.m.minoda@gmail.com> * update readme Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

chore: sync upstream

…utowarefoundation#365) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

zulfaqar-azmi-t4 changed the title ~~fix(behavior_path_planner): behavior path planner crash when drivable area expanding~~ fix(behavior_path_planner): crash when drivable area expanding Feb 9, 2022

fix(behavior_path_planner): crash when drivable area expanding

89f2abb

This is to fix the behavior path planner crash when the drivable area is expanding towards opposite direction lane Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

zulfaqar-azmi-t4 force-pushed the fix/drivable_area_expansion_when_obstacle_is_on_furthest branch from 44d888d to 89f2abb Compare February 9, 2022 02:57

zulfaqar-azmi-t4 commented Feb 9, 2022

View reviewed changes

taikitanaka3 approved these changes Feb 9, 2022

View reviewed changes

taikitanaka3 approved these changes Feb 10, 2022

View reviewed changes

takayuki5168 approved these changes Feb 10, 2022

View reviewed changes

takayuki5168 merged commit eb599ae into autowarefoundation:tier4/proposal Feb 10, 2022

tier4-autoware-public-bot bot mentioned this pull request Feb 10, 2022

chore: sync upstream tier4/autoware.universe#11

Merged

This was referenced Mar 7, 2022

better avoidance drivable areas extension in behavior path planning: Remaining TODO #485

Closed

refactor(avoidance_module): change implementation to lambda #486

Merged

zulfaqar-azmi-t4 deleted the fix/drivable_area_expansion_when_obstacle_is_on_furthest branch April 22, 2022 00:51

TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022

Merge pull request autowarefoundation#359 from tier4/feature/add_plan…

5858dc9

…nig_error_monitor (autowarefoundation#365)

KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023

chore: update tool versions (autowarefoundation#365)

de83e5e

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

soblin pushed a commit to soblin/autoware.universe that referenced this pull request May 10, 2023

Merge pull request autowarefoundation#365 from tier4/sync-upstream

9d76d18

chore: sync upstream

keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023

refactor(autoware_launch): remove duplicated path in planning launch (a…

30b422a

…utowarefoundation#365) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023

change branch of lexus_description (#365)

015d355

HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024

feat: add pyrocan repos (autowarefoundation#365)

21bfa98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(behavior_path_planner): crash when drivable area expanding #365

fix(behavior_path_planner): crash when drivable area expanding #365

zulfaqar-azmi-t4 commented Feb 9, 2022

taikitanaka3 commented Feb 9, 2022

codecov bot commented Feb 9, 2022 •

edited

Loading

zulfaqar-azmi-t4 commented Feb 9, 2022

zulfaqar-azmi-t4 Feb 9, 2022 •

edited

Loading

taikitanaka3 left a comment

taikitanaka3 commented Feb 9, 2022

taikitanaka3 commented Feb 9, 2022

fix(behavior_path_planner): crash when drivable area expanding #365

fix(behavior_path_planner): crash when drivable area expanding #365

Conversation

zulfaqar-azmi-t4 commented Feb 9, 2022

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-Review Checklist for the PR Author

CI Checks

taikitanaka3 commented Feb 9, 2022

codecov bot commented Feb 9, 2022 • edited Loading

Codecov Report

zulfaqar-azmi-t4 commented Feb 9, 2022

zulfaqar-azmi-t4 Feb 9, 2022 • edited Loading

Choose a reason for hiding this comment

taikitanaka3 left a comment

Choose a reason for hiding this comment

taikitanaka3 commented Feb 9, 2022

taikitanaka3 commented Feb 9, 2022

codecov bot commented Feb 9, 2022 •

edited

Loading

zulfaqar-azmi-t4 Feb 9, 2022 •

edited

Loading