feat: add line_width property to object display #1206

tkimura4 · 2022-07-01T03:14:44Z

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

Add a line with property to object display

Review procedure

Check that the line width of object-shape changes depending on the value of line witdh property on rviz.

(with tier4/autoware_launch#378 )

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

codecov · 2022-07-01T03:31:12Z

Codecov Report

Merging #1206 (ad85fd1) into main (791fd51) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1206      +/-   ##
========================================
- Coverage   9.56%   9.54%   -0.02%     
========================================
  Files       1049    1049              
  Lines      72107   72212     +105     
  Branches   15601   15601              
========================================
  Hits        6896    6896              
- Misses     58962   59067     +105     
  Partials    6249    6249

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`9.54% <0.00%> (ø)`		Carriedforward from 652a33a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...include/object_detection/object_polygon_detail.hpp	`0.00% <ø> (ø)`
...e/object_detection/object_polygon_display_base.hpp	`0.00% <0.00%> (ø)`
.../src/object_detection/detected_objects_display.cpp	`0.00% <0.00%> (ø)`
...gin/src/object_detection/object_polygon_detail.cpp	`0.00% <0.00%> (ø)`
...src/object_detection/predicted_objects_display.cpp	`0.00% <0.00%> (ø)`
...n/src/object_detection/tracked_objects_display.cpp	`0.00% <0.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791fd51...ad85fd1. Read the comment docs.

shmpwk

autoware.universe/common/autoware_auto_perception_rviz_plugin/include/object_detection/object_polygon_detail.hpp

Lines 77 to 78 in 36c323b

    
           /// \param color_rgba Color and alpha values to use for the marker 
        
           /// \return Marker ptr. Id and header will have to be set by the caller

autoware.universe/common/autoware_auto_perception_rviz_plugin/include/object_detection/object_polygon_display_base.hpp

Lines 136 to 137 in 36c323b

    
           /// \param labels List of ObjectClassificationMsg objects 
        
           /// \return Marker ptr. Id and header will have to be set by the caller

Adding Parameters description is better

/// \param line_width Line thickness around the object

common/autoware_auto_perception_rviz_plugin/include/object_detection/object_polygon_detail.hpp

common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit d6a59ac4c3762cb58ce6ca3e2cb31b3b8fc810ea. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Port euclidean cluster (autowarefoundation#120) * porting CmakeLists.txt and package.xml in progress * ported CMakeLists.txt and package.xml to ROS2 * Ported euclidean_cluster from ROS1 to ROS2 * deleted unnecesary files * fixed transient_local Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * Fix perception launches (autowarefoundation#240) * fix roi_cluster_fusion launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> * add comment on launch Signed-off-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> * Ros2 v0.8.0 euclidean cluster (autowarefoundation#310) * restore euclidean cluster files for v0.8.0 update * fix typos in perception (autowarefoundation#862) * Feature/camera lidar perception (autowarefoundation#937) * add object splitter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add object merger Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * change pkg name Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * cosmetic change Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * add comment Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * remove litter Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix : debug code Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * enable vehicle to unknown track Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> * bug fix * add object position in clustering * 🚮 * change param * fix name * bug fix * add install * Feature/fusion debug (autowarefoundation#1051) * add debuger * change param * add publisher * Revert "restore euclidean cluster files for v0.8.0 update" This reverts commit 894cb8746622b4eb88f2cf1b036cc8c94ab1ac96. * fix bug * use containter to launch nodelet * add line * [euclidean_cluster]: Fix launch python and CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * add use_sim-time option (autowarefoundation#454) * Format launch files (autowarefoundation#1219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix variable names Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Porting euclidean cluster (autowarefoundation#1291) * create config for euclidean cluster (autowarefoundation#1206) * create config * fix EOF * fix cmake list (autowarefoundation#1208) * Add load_composable_node_param Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use tier4 voxel grid filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Refactor voxel grid based euclidean cluster launch Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix launch xml tag Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add missing arguments Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix pointcloud subscriber qos Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix dependency in CMakeLists.txt Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Invoke code formatter at pre-commit (autowarefoundation#1935) * Run ament_uncrustify at pre-commit * Reformat existing files * Fix copyright and cpplint errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/clustering lib (autowarefoundation#1914) * change to lib for detection by tracking * refactor * apply format * Detection by tracker (autowarefoundation#1910) * initial commit * backup * apply format * cosmetic change * implement divided under segmenterd clusters * cosmetic change * bug fix * bug fix * bug fix * modify launch * add debug and bug fix * bug fix * bug fix * add no found tracked object * modify parameters and cmake * bug fix * remove debug info * add readme * modify clustering launch * run pre-commit * cosmetic change * cosmetic change * cosmetic change * apply markdownlint * modify launch * modify for cpplint * modify qos * change int to size_T * bug fix * change perception qos * Update perception/object_recognition/detection/detection_by_tracker/package.xml Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * cosmetic change * cosmetic change * fix launch * Update perception/object_recognition/detection/detection_by_tracker/src/utils.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * modify header include order * change include order * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * change to std::optional * cosmetic change * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Update perception/object_recognition/detection/detection_by_tracker/src/detection_by_tracker_core.cpp Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * bug fix * modify readme Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * port euclidean_cluster (autowarefoundation#533) * delete COLCON_IGNORE * change dynamic_object_with_feature_array to detected_objects_with_feature * add classification * add classification.probability * add README of euclidean_cluster (autowarefoundation#614) * add README of euclidean_cluster * add period Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * update README Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> * auto fix no ground pointcloud topic name (autowarefoundation#704) * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: nik-tier4 <71747268+nik-tier4@users.noreply.github.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <takamasa.horib@gmail.com> Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Takeshi Ishita <ishitah.takeshi@gmail.com> Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>

* feat: add line_width property to object display Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove default value Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add the description of parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

) * feat: add line_width property to object display Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove default value Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add the description of parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add line_width property to object display Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * remove default value Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * add the description of parameter Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

…efoundation#1206) * fix(lane_change): consider max velocity during path planning (autowarefoundation#6615) (autowarefoundation#1203) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the max_velocity not subscribed from motion velocity smoother Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

feat: add line_width property to object display

36c323b

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

tkimura4 requested a review from takayuki5168 July 1, 2022 03:14

tkimura4 mentioned this pull request Jul 1, 2022

feat: add line_width property to object display tier4/autoware_launch-old#378

Merged

8 tasks

tkimura4 marked this pull request as ready for review July 5, 2022 06:10

tkimura4 requested a review from shmpwk July 5, 2022 06:10

shmpwk reviewed Jul 5, 2022

View reviewed changes

common/autoware_auto_perception_rviz_plugin/include/object_detection/object_polygon_detail.hpp Outdated Show resolved Hide resolved

common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp Outdated Show resolved Hide resolved

tkimura4 added 2 commits July 5, 2022 19:13

remove default value

652a33a

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

add the description of parameter

ad85fd1

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

shmpwk approved these changes Jul 5, 2022

View reviewed changes

tkimura4 merged commit 3573624 into autowarefoundation:main Jul 5, 2022

tkimura4 deleted the feature/object_shape_line_width branch July 5, 2022 16:38

tkimura4 mentioned this pull request Jul 5, 2022

feat: add line_width property to object display autowarefoundation/autoware_launch#56

Merged

4 tasks

tier4-autoware-public-bot bot mentioned this pull request Jul 6, 2022

chore: sync upstream tier4/autoware.universe#68

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add line_width property to object display #1206

feat: add line_width property to object display #1206

tkimura4 commented Jul 1, 2022 •

edited by shmpwk

Loading

codecov bot commented Jul 1, 2022 •

edited

Loading

shmpwk left a comment •

edited

Loading

	/// \param color_rgba Color and alpha values to use for the marker
	/// \return Marker ptr. Id and header will have to be set by the caller

	/// \param labels List of ObjectClassificationMsg objects
	/// \return Marker ptr. Id and header will have to be set by the caller

feat: add line_width property to object display #1206

feat: add line_width property to object display #1206

Conversation

tkimura4 commented Jul 1, 2022 • edited by shmpwk Loading

Description

Related links

Review procedure

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jul 1, 2022 • edited Loading

Codecov Report

shmpwk left a comment • edited Loading

Choose a reason for hiding this comment

tkimura4 commented Jul 1, 2022 •

edited by shmpwk

Loading

codecov bot commented Jul 1, 2022 •

edited

Loading

shmpwk left a comment •

edited

Loading