-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(run_out): fix uninitialized ptr #1270
Merged
taikitanaka3
merged 3 commits into
autowarefoundation:main
from
taikitanaka3:fix/run_out_ptr
Jul 11, 2022
Merged
fix(run_out): fix uninitialized ptr #1270
taikitanaka3
merged 3 commits into
autowarefoundation:main
from
taikitanaka3:fix/run_out_ptr
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
========================================
- Coverage 9.71% 9.56% -0.16%
========================================
Files 1073 1074 +1
Lines 73986 74272 +286
Branches 16294 16548 +254
========================================
- Hits 7190 7101 -89
- Misses 60207 60860 +653
+ Partials 6589 6311 -278
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3
force-pushed
the
fix/run_out_ptr
branch
from
July 7, 2022 10:52
919972b
to
e6c4038
Compare
taikitanaka3
changed the title
fix(run_out): fix invalid use of optional
fix(run_out): fix uninitialized ptr
Jul 7, 2022
planning/behavior_velocity_planner/src/scene_module/run_out/scene.cpp
Outdated
Show resolved
Hide resolved
TomohitoAndo
approved these changes
Jul 11, 2022
taikitanaka3
commented
Jul 11, 2022
planning/behavior_velocity_planner/src/scene_module/run_out/scene.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
TomohitoAndo
referenced
this pull request
in tier4/autoware.universe
Jul 11, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
4 tasks
kosuke55
referenced
this pull request
in tier4/autoware.universe
Jul 14, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
* fix(run_out): fix uninitialized ptr Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> * chore: use make optional Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
1222-takeshi
pushed a commit
to 1222-takeshi/autoware.universe
that referenced
this pull request
Jun 13, 2024
…ain-sync chore: sync beta branch beta/v0.27.0 with tier4/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tanaka3 ttatcoder@outlook.jp
Description
fix this error when stop_dist is not initialized
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x00007f20053ad859 in __GI_abort () at abort.c:79 #2 0x00007f20053ad729 in __assert_fail_base (fmt=0x7f2005543588 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7f1fca3ecbf1 "this->is_initialized()", file=0x7f1fca3ecbc8 "/usr/include/boost/optional/optional.hpp", line=1207, function=<optimized out>) at assert.c:92 #3 0x00007f20053befd6 in __GI___assert_fail (assertion=0x7f1fca3ecbf1 "this->is_initialized()", file=0x7f1fca3ecbc8 "/usr/include/boost/optional/optional.hpp", line=1207, function=0x7f1fca3ecb48 "boost::optional<T>::reference_type boost::optional<T>::get() [with T = double; boost::optional<T>::reference_type = double&]") at assert.c:101 #4 0x00007f1fc9f18757 in boost::optional<double>::get() (this=0x7f1fdfffbc60) at /usr/include/boost/optional/optional.hpp:1207 #5 0x00007f1fca3c3020 in boost::optional<double>::operator*() & (this=0x7f1fdfffbc60) at /usr/include/boost/optional/optional.hpp:1224 #6 0x00007f1fca3bbaf6 in behavior_velocity_planner::RunOutModule::createDetectionAreaPolygon (this=0x7f1fb40830d0, smoothed_path=...) at /home/t4tanaka/workspace/pilot-auto.x2_v0.4.0/src/autoware/universe/planning/behavior_velocity_planner/src/scene_module/run_out/scene.cpp:144 144 *stop_dist = 0;
After this PR this error didn't happen
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.