Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_out): fix uninitialized ptr #1270

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Jul 7, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

fix this error when stop_dist is not initialized
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x00007f20053ad859 in __GI_abort () at abort.c:79 #2 0x00007f20053ad729 in __assert_fail_base (fmt=0x7f2005543588 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7f1fca3ecbf1 "this->is_initialized()", file=0x7f1fca3ecbc8 "/usr/include/boost/optional/optional.hpp", line=1207, function=<optimized out>) at assert.c:92 #3 0x00007f20053befd6 in __GI___assert_fail (assertion=0x7f1fca3ecbf1 "this->is_initialized()", file=0x7f1fca3ecbc8 "/usr/include/boost/optional/optional.hpp", line=1207, function=0x7f1fca3ecb48 "boost::optional<T>::reference_type boost::optional<T>::get() [with T = double; boost::optional<T>::reference_type = double&]") at assert.c:101 #4 0x00007f1fc9f18757 in boost::optional<double>::get() (this=0x7f1fdfffbc60) at /usr/include/boost/optional/optional.hpp:1207 #5 0x00007f1fca3c3020 in boost::optional<double>::operator*() & (this=0x7f1fdfffbc60) at /usr/include/boost/optional/optional.hpp:1224 #6 0x00007f1fca3bbaf6 in behavior_velocity_planner::RunOutModule::createDetectionAreaPolygon (this=0x7f1fb40830d0, smoothed_path=...) at /home/t4tanaka/workspace/pilot-auto.x2_v0.4.0/src/autoware/universe/planning/behavior_velocity_planner/src/scene_module/run_out/scene.cpp:144 144 *stop_dist = 0;

After this PR this error didn't happen
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1270 (7c83988) into main (23de2c6) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #1270      +/-   ##
========================================
- Coverage   9.71%   9.56%   -0.16%     
========================================
  Files       1073    1074       +1     
  Lines      73986   74272     +286     
  Branches   16294   16548     +254     
========================================
- Hits        7190    7101      -89     
- Misses     60207   60860     +653     
+ Partials    6589    6311     -278     
Flag Coverage Δ *Carryforward flag
differential 4.95% <ø> (?)
total 9.59% <ø> (-0.11%) ⬇️ Carriedforward from e6c4038

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <ø> (ø)
...include/tier4_autoware_utils/geometry/geometry.hpp 86.66% <0.00%> (-4.38%) ⬇️
...autoware_utils/test/src/geometry/test_geometry.cpp 37.59% <0.00%> (-2.99%) ⬇️
...behavior_velocity_planner/src/utilization/util.cpp 24.31% <0.00%> (-0.10%) ⬇️
map/lanelet2_extension/lib/query.cpp 9.52% <0.00%> (ø)
map/lanelet2_extension/lib/utilities.cpp 8.89% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 34.35% <0.00%> (ø)
map/lanelet2_extension/lib/visualization.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23de2c6...7c83988. Read the comment docs.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 changed the title fix(run_out): fix invalid use of optional fix(run_out): fix uninitialized ptr Jul 7, 2022
@taikitanaka3 taikitanaka3 marked this pull request as ready for review July 7, 2022 11:00
@TomohitoAndo TomohitoAndo self-requested a review July 11, 2022 05:26
taikitanaka3 and others added 2 commits July 11, 2022 14:33
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) July 11, 2022 06:13
@taikitanaka3 taikitanaka3 merged commit 44c4bd1 into autowarefoundation:main Jul 11, 2022
@taikitanaka3 taikitanaka3 mentioned this pull request Jul 11, 2022
3 tasks
TomohitoAndo referenced this pull request in tier4/autoware.universe Jul 11, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
@taikitanaka3 taikitanaka3 deleted the fix/run_out_ptr branch August 10, 2022 05:46
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Jun 13, 2024
…ain-sync

chore: sync beta branch beta/v0.27.0 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants