Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/cherry pick #84

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Chore/cherry pick #84

merged 2 commits into from
Jul 11, 2022

Conversation

TomohitoAndo
Copy link

Description

cherry-pic bug fixes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TomohitoAndo and others added 2 commits July 11, 2022 16:10
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
* fix(run_out): fix uninitialized ptr

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>

* chore: use make optional

Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo requested a review from 0x126 July 11, 2022 08:12
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 0823848 into beta/v0.4.1 Jul 11, 2022
@TomohitoAndo TomohitoAndo deleted the chore/cherry-pick branch July 11, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants