Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cancel-previous-workflows.yaml #1736

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Aug 31, 2022

Description

As written in #1669, sometimes CI execution will be jammed.

To resolve this, I'd like to introduce this option.
https://github.com/styfle/cancel-workflow-action#advanced-all-but-latest

Because this action can only cancel workflows if it is actually being run, it only helps if the pipeline isn't saturated and there are still runners available to schedule the workflow.
By default, this action does not cancel any workflows created after itself. The all_but_latest flags allows the action to cancel itself and all later-scheduled workflows, leaving only the latest.

Also, since it's not limited to build-and-test, I try splitting the workflow.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Kenji Miyake added 2 commits August 31, 2022 13:45
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

@kenji-miyake kenji-miyake marked this pull request as ready for review August 31, 2022 04:54
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Copy link
Contributor

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenji-miyake kenji-miyake merged commit 603e408 into main Aug 31, 2022
@kenji-miyake kenji-miyake deleted the add-cancel-workflow branch August 31, 2022 05:13
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* ci: add cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(build-and-test-differential): remove cancel action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* ci: add cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(build-and-test-differential): remove cancel action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* ci: add cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(build-and-test-differential): remove cancel action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* ci: add cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(build-and-test-differential): remove cancel action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* ci: add cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(build-and-test-differential): remove cancel action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync cancel-previous-workflows.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants