Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): rename pull_over params #1747

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 31, 2022

Description

Remove SI units from params of pull_over

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 changed the title Chore/rename pull over params chore(behavior_path_planner): rename pull_over params Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1747 (ef0b447) into main (8273ab0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head ef0b447 differs from pull request most recent head 2f19343. Consider uploading reports for the commit 2f19343 to get more accurate results

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   10.27%   10.26%   -0.02%     
==========================================
  Files        1204     1204              
  Lines       86885    86966      +81     
  Branches    20054    20104      +50     
==========================================
- Hits         8931     8926       -5     
- Misses      68659    68736      +77     
- Partials     9295     9304       +9     
Flag Coverage Δ *Carryforward flag
differential 1.26% <0.00%> (?)
total 10.25% <0.00%> (-0.01%) ⬇️ Carriedforward from 8a097d8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
.../scene_module/utils/geometric_parallel_parking.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.22% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the chore/rename_pull_over_params branch from ef0b447 to 2f19343 Compare August 31, 2022 13:06
@kosuke55 kosuke55 changed the title chore(behavior_path_planner): rename pull_over params refactor(behavior_path_planner): rename pull_over params Aug 31, 2022
@kosuke55 kosuke55 merged commit c9dd11c into autowarefoundation:main Aug 31, 2022
@kosuke55 kosuke55 deleted the chore/rename_pull_over_params branch August 31, 2022 17:26
@kosuke55
Copy link
Contributor Author

TIER IV internal scenario tests result
https://evaluation.tier4.jp/evaluation/reports/09628818-08be-5240-9587-0c166fde1979?project_id=prd_jt

some tests failed but this is not related to this PR, so merge it.

[openscenario_interpreter_node-3] [component_container_mt-47] terminate called after throwing an instance of 'std::invalid_argument'
[openscenario_interpreter_node-3] [component_container_mt-47]   what():  query_keys is out of base_keys
[openscenario_interpreter_node-3] [ERROR] [component_container_mt-47]: process has died [pid 609, exit code -6, cmd '/opt/ros/galactic/lib/rclcpp_components/component_container_mt --ros-args -r __node:=behavior_planning_container -r __ns:=/planning/scenario_planning/lane_driving/behavior_planning --params-file /tmp/launch_params_hrfe5_d_'].

same to https://star4.slack.com/archives/C03QW0GU6P7/p1661929519085059?thread_ts=1661913029.169039&cid=C03QW0GU6P7

boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…ndation#1747)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants