-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_velocity_planner): replace Polygon2d with common's one #1767
feat(behavior_velocity_planner): replace Polygon2d with common's one #1767
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1767 +/- ##
========================================
Coverage 10.38% 10.39%
========================================
Files 1212 1212
Lines 87407 88014 +607
Branches 20282 20686 +404
========================================
+ Hits 9080 9150 +70
- Misses 68846 69329 +483
- Partials 9481 9535 +54
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
occlusion spot
run out
and CI checks https://evaluation.tier4.jp/evaluation/reports/692dcc52-5308-5fc0-9b6a-abedde2116d3?project_id=prd_jt
…utowarefoundation#1767) * feat(behavior_velocity_planner): replace Polygon2d with common's one Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1767) * feat(behavior_velocity_planner): replace Polygon2d with common's one Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1767) * feat(behavior_velocity_planner): replace Polygon2d with common's one Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1767) * feat(behavior_velocity_planner): replace Polygon2d with common's one Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1767) * feat(behavior_velocity_planner): replace Polygon2d with common's one Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
replace behavior_vel's original Polygon2d with common's Polygon2d.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.