Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): replace Polygon2d with common's one #1767

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 2, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

replace behavior_vel's original Polygon2d with common's Polygon2d.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review September 2, 2022 06:30
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1767 (b0197a2) into main (6075e60) will increase coverage by 0.00%.
The diff coverage is 16.12%.

@@           Coverage Diff            @@
##             main    #1767    +/-   ##
========================================
  Coverage   10.38%   10.39%            
========================================
  Files        1212     1212            
  Lines       87407    88014   +607     
  Branches    20282    20686   +404     
========================================
+ Hits         9080     9150    +70     
- Misses      68846    69329   +483     
- Partials     9481     9535    +54     
Flag Coverage Δ *Carryforward flag
differential 11.72% <0.00%> (?)
total 10.37% <17.85%> (ø) Carriedforward from 8c1c4fc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <ø> (ø)
...nner/include/utilization/boost_geometry_helper.hpp 21.56% <0.00%> (-7.38%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 0.00% <ø> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...module/no_stopping_area/scene_no_stopping_area.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/occlusion_spot/grid_utils.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 10.88% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <ø> (ø)
...elocity_planner/src/scene_module/run_out/utils.cpp 0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 16.04% <0.00%> (+3.58%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168 takayuki5168 merged commit fd9677c into autowarefoundation:main Sep 5, 2022
@takayuki5168 takayuki5168 deleted the feat/use-common-polygon2d-in-behavior-vel branch September 5, 2022 01:25
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…utowarefoundation#1767)

* feat(behavior_velocity_planner): replace Polygon2d with common's one

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1767)

* feat(behavior_velocity_planner): replace Polygon2d with common's one

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1767)

* feat(behavior_velocity_planner): replace Polygon2d with common's one

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1767)

* feat(behavior_velocity_planner): replace Polygon2d with common's one

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…utowarefoundation#1767)

* feat(behavior_velocity_planner): replace Polygon2d with common's one

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants