-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): use object recognition for pull_over #1777
Merged
kosuke55
merged 6 commits into
autowarefoundation:main
from
tier4:feature/pull_over_object_recognition
Sep 5, 2022
Merged
feat(behavior_path_planner): use object recognition for pull_over #1777
kosuke55
merged 6 commits into
autowarefoundation:main
from
tier4:feature/pull_over_object_recognition
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feature/pull_over_object_recognition
branch
from
September 5, 2022 04:26
147a9de
to
32436db
Compare
kosuke55
changed the title
feat(behavior_path_planner) use object recognition for pull_over
feat(behavior_path_planner): use object recognition for pull_over
Sep 5, 2022
Merged
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
- Coverage 10.40% 10.35% -0.05%
==========================================
Files 1218 1218
Lines 87306 87682 +376
Branches 20227 20576 +349
==========================================
+ Hits 9081 9082 +1
- Misses 68771 69128 +357
- Partials 9454 9472 +18
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shmpwk
reviewed
Sep 5, 2022
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Outdated
Show resolved
Hide resolved
...avior_path_planner/include/behavior_path_planner/scene_module/pull_over/pull_over_module.hpp
Outdated
Show resolved
Hide resolved
…_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feature/pull_over_object_recognition
branch
from
September 5, 2022 06:44
9bd1a8e
to
ad49941
Compare
shmpwk
approved these changes
Sep 5, 2022
kosuke55
requested review from
zulfaqar-azmi-t4,
TakaHoribe,
purewater0901 and
takayuki5168
as code owners
September 5, 2022 07:30
kosuke55
removed request for
takayuki5168,
TakaHoribe,
purewater0901 and
zulfaqar-azmi-t4
September 5, 2022 07:31
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
feature/pull_over_object_recognition
branch
from
September 5, 2022 07:54
9c797a5
to
d2c3016
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
shmpwk
approved these changes
Sep 5, 2022
7 tasks
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
7 tasks
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 13, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 14, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 17, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
4 tasks
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 18, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 10, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 30, 2022
…towarefoundation#1777) * feat(behavior_path_planner): use object recognition for pull_over Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * rename checkCollision Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove unnecessary lines Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update warn message Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use object recognition for pull_over
This is a solution to the problem of not being able to park on the shoulder due to vegetation.
Both occupancy gird and object recognition can be used. Both can be optionally enabled.
use_occupancy_grid
use_object_recognition
The visualization of the division of the goal search area was stopped to reduce the computational complexity.
pull_over_object_recognition-2022-09-05_12.49.30.mp4
Related links
Tests performed
The original goal is also repositioned.
https://console.data-search.tier4.jp/projects/prd_jt/environments/9ba5b2bc-9b8e-438a-aba6-342d19c876a5/rosbags/7d31ef3c-5cae-4728-9403-975f911c7ee9
2022-09-02-13-08-16.mp4
https://console.data-search.tier4.jp/projects/prd_jt/environments/9ba5b2bc-9b8e-438a-aba6-342d19c876a5/rosbags/85b8a4ee-f2b9-4312-814c-786e98b5ce7e
2022-09-02-18-20-21.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.