Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): use object recognition for pull_over #1777

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 5, 2022

Description

Use object recognition for pull_over
This is a solution to the problem of not being able to park on the shoulder due to vegetation.

  • Both occupancy gird and object recognition can be used. Both can be optionally enabled.

    • use_occupancy_grid
    • use_object_recognition
  • The visualization of the division of the goal search area was stopped to reduce the computational complexity.

pull_over_object_recognition-2022-09-05_12.49.30.mp4

Related links

Tests performed

  • psim
  • lsim (TIER IV internal rosbag)

The original goal is also repositioned.

https://console.data-search.tier4.jp/projects/prd_jt/environments/9ba5b2bc-9b8e-438a-aba6-342d19c876a5/rosbags/7d31ef3c-5cae-4728-9403-975f911c7ee9

2022-09-02-13-08-16.mp4

https://console.data-search.tier4.jp/projects/prd_jt/environments/9ba5b2bc-9b8e-438a-aba6-342d19c876a5/rosbags/85b8a4ee-f2b9-4312-814c-786e98b5ce7e

2022-09-02-18-20-21.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/pull_over_object_recognition branch from 147a9de to 32436db Compare September 5, 2022 04:26
@kosuke55 kosuke55 changed the title feat(behavior_path_planner) use object recognition for pull_over feat(behavior_path_planner): use object recognition for pull_over Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1777 (1dcd4c3) into main (a9b9722) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   10.40%   10.35%   -0.05%     
==========================================
  Files        1218     1218              
  Lines       87306    87682     +376     
  Branches    20227    20576     +349     
==========================================
+ Hits         9081     9082       +1     
- Misses      68771    69128     +357     
- Partials     9454     9472      +18     
Flag Coverage Δ *Carryforward flag
differential 1.28% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from d2c3016

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.35% <0.00%> (+0.14%) ⬆️
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kosuke55 and others added 2 commits September 5, 2022 15:44
…_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/pull_over_object_recognition branch from 9bd1a8e to ad49941 Compare September 5, 2022 06:44
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/pull_over_object_recognition branch from 9c797a5 to d2c3016 Compare September 5, 2022 07:54
@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 5, 2022

@shmpwk
Thanks for your review.
Updated docs and removed unnecessary processing. It does not affect the behavior.
ac7b882
d2c3016

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 5, 2022

@shmpwk
Updated warning message and throw exception when search_priority is invalid.
1dcd4c3

@kosuke55 kosuke55 merged commit dff3102 into autowarefoundation:main Sep 5, 2022
@kosuke55 kosuke55 deleted the feature/pull_over_object_recognition branch September 5, 2022 09:08
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…towarefoundation#1777)

* feat(behavior_path_planner): use object recognition for pull_over

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* rename checkCollision

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update docs

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* remove unnecessary lines

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update warn message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants