Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heatmap_visualizer): add unknown class #1781

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Sep 5, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

When the input object topic includes unknown objects, heatmap_visualizer dies with a following message.
image

This is due to invalid access to heatmaps_ here
I fixed it by adding unknown to class_names_

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1781 (c578b87) into main (2f379a6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   10.35%   10.35%           
=======================================
  Files        1218     1218           
  Lines       87375    87375           
  Branches    20224    20224           
=======================================
  Hits         9051     9051           
  Misses      68874    68874           
  Partials     9450     9450           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.34% <0.00%> (ø) Carriedforward from 2f379a6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tkimura4 tkimura4 requested a review from shmpwk September 5, 2022 07:46
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 57c4b1f into autowarefoundation:main Sep 5, 2022
@tkimura4 tkimura4 deleted the fix/heatmap_vis_unknown_objects branch September 5, 2022 10:41
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Sep 6, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants