Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maintainer in ekf_localizer and ndt_scan_matcher #2109

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 19, 2022

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda marked this pull request as ready for review October 19, 2022 06:56
@kminoda kminoda self-assigned this Oct 19, 2022
@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 10.78% // Head: 10.78% // No change to project coverage 👍

Coverage data is based on head (518fbc8) compared to base (272f8a2).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2109   +/-   ##
=======================================
  Coverage   10.78%   10.78%           
=======================================
  Files        1179     1179           
  Lines       84449    84449           
  Branches    19795    19795           
=======================================
  Hits         9104     9104           
  Misses      65853    65853           
  Partials     9492     9492           
Flag Coverage Δ *Carryforward flag
differential 8.60% <ø> (?)
total 10.76% <60.00%> (ø) Carriedforward from 2e8c87b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/routing.cpp 33.33% <60.00%> (ø)
.../src/goal_pose_visualizer/goal_pose_visualizer.cpp
...n_planner/src/lanelet2_plugins/default_planner.cpp
...planner/src/lanelet2_plugins/utility_functions.cpp

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda merged commit 0ab91f4 into main Oct 19, 2022
@kminoda kminoda deleted the chore/add_maintainer_in_ekf_and_ndt branch October 19, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants