fix(behavior_path_planner): die when using getExtendedCurrentLanes in the last lane #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the last lane Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
7 tasks
Codecov ReportBase: 11.14% // Head: 11.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 11.14% 11.13% -0.02%
==========================================
Files 1203 1203
Lines 86268 86381 +113
Branches 20829 20887 +58
==========================================
Hits 9615 9615
- Misses 66490 66602 +112
- Partials 10163 10164 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
purewater0901
approved these changes
Nov 9, 2022
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 10, 2022
… the last lane (autowarefoundation#2256) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
7 tasks
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
… the last lane (autowarefoundation#2256) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
… the last lane (autowarefoundation#2256) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2207 added front() of next/prev lanes to current_lanes. but when these lanes are empty, the node dies. In this PR, changed next/prev lanes are empty.
Related links
Tests performed
psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.