Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): send intersection/intersection_occlusion rtc status #3511

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 24, 2023

Description

Always send two intersection cooperate status:

  • when occlusion is not detected:
    • default intersection and (safe, -inf) intersection_occlusion status
  • when occlusion is detected
    • before first stop line:
      • intersection_occlusion and intersection(for first stop line)
    • after first stop line:
      • intersection_occlusion and default intersection(for collision checking)

Related links

https://tier4.atlassian.net/browse/RT1-2166

Tests performed

When occlusion is not detected:

image

When occlusion is not detected:
image

Notes for reviewers

This should be stress tested with FOA.

Interface changes

For each intersection, there will always be intersection and intersection_occlusion rtc status.

Effects on system behavior

For each intersection, there will always be intersection and intersection_occlusion rtc status.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…n_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 24, 2023
@soblin soblin changed the title Feat/intersection occlusion UUID feat(intersection): send intersection/intersection_occlusion rtc status Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (a3a653d) 14.61% compared to head (dd683d5) 14.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
- Coverage   14.61%   14.61%   -0.01%     
==========================================
  Files        1294     1294              
  Lines       92007    92012       +5     
  Branches    29071    29082      +11     
==========================================
  Hits        13451    13451              
- Misses      64111    64116       +5     
  Partials    14445    14445              
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.62% <ø> (+<0.01%) ⬆️ Carriedforward from a3a653d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/scene_module/intersection/scene_intersection.hpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 16f6434 into autowarefoundation:main Apr 24, 2023
soblin added a commit that referenced this pull request Apr 24, 2023
fix #3511) (#3512)

* Merge feat/intersection-occlusion-latest (#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus at the beginning of send RTC

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin deleted the feat/intersection-occlusion-uuid branch April 24, 2023 13:13
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…us (autowarefoundation#3511)

* Merge feat/intersection-occlusion-latest (#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
fix autowarefoundation#3511) (autowarefoundation#3512)

* Merge feat/intersection-occlusion-latest (#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus at the beginning of send RTC

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…us (autowarefoundation#3511)

* Merge feat/intersection-occlusion-latest (tier4#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
fix autowarefoundation#3511) (autowarefoundation#3512)

* Merge feat/intersection-occlusion-latest (tier4#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus at the beginning of send RTC

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants