Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): send intersection/intersection_occlusion rtc status(fix #3511) #3512

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Apr 24, 2023

Description

A additional PR for #3511, which I merged WIP status by mistake.

Tests performed

With this PR #3511 's result is available.

Effects on system behavior

same as #3511

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…n_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 24, 2023
@soblin soblin changed the title Feat/intersection occlusion uuid2 feat(intersection): send intersection/intersection_occlusion rtc status(fix #3511) Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a0f760) 13.74% compared to head (8312408) 13.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3512   +/-   ##
=======================================
  Coverage   13.74%   13.74%           
=======================================
  Files        1392     1392           
  Lines       97856    97844   -12     
  Branches    29072    29072           
=======================================
  Hits        13451    13451           
+ Misses      69960    69948   -12     
  Partials    14445    14445           
Flag Coverage Δ *Carryforward flag
differential 3.46% <0.00%> (?)
total 13.75% <ø> (+<0.01%) ⬆️ Carriedforward from 2a0f760

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <ø> (ø)
...ane_change/external_request_lane_change_module.hpp 0.00% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...ane_change/external_request_lane_change_module.cpp 12.77% <ø> (+0.10%) ⬆️
...rc/scene_module/lane_change/lane_change_module.cpp 16.02% <ø> (+0.40%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 5.88% <ø> (+0.14%) ⬆️
...e/scene_module/intersection/scene_intersection.hpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit de4b01b into autowarefoundation:main Apr 24, 2023
@soblin soblin deleted the feat/intersection-occlusion-uuid2 branch April 24, 2023 13:13
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
fix autowarefoundation#3511) (autowarefoundation#3512)

* Merge feat/intersection-occlusion-latest (#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus at the beginning of send RTC

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
fix autowarefoundation#3511) (autowarefoundation#3512)

* Merge feat/intersection-occlusion-latest (tier4#8)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fixed virtual wall marker

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* use is_occluded flag

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* 3 rtc intersection appears

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus before sendRTC not to duplicate default/occlusion_first_stop_uuid

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* clearCooperateStatus at the beginning of send RTC

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants