Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): clear waiting approval only when all target module are unavoidable #3662

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 10, 2023

Description

  • set waiting approval in onProcessEntry().
  • don't clear waiting approval if there is unavoidable objects even when no shift line is generated.

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…e unavoidable

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (a97f60a) 14.72% compared to head (20d0920) 14.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3662      +/-   ##
==========================================
- Coverage   14.72%   14.72%   -0.01%     
==========================================
  Files        1298     1298              
  Lines       92512    92519       +7     
  Branches    29309    29312       +3     
==========================================
  Hits        13619    13619              
- Misses      64113    64120       +7     
  Partials    14780    14780              
Flag Coverage Δ *Carryforward flag
differential 13.09% <0.00%> (?)
total 14.72% <ø> (+<0.01%) ⬆️ Carriedforward from a97f60a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 3.65% <0.00%> (-0.01%) ⬇️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...top_planner/include/obstacle_stop_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_stop_planner/src/node.cpp 9.34% <ø> (+0.03%) ⬆️
...anning/obstacle_stop_planner/src/planner_utils.cpp 13.47% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit d2a5e84 into autowarefoundation:main May 11, 2023
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request May 16, 2023
…e unavoidable (autowarefoundation#3662)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 16, 2023
…e unavoidable (autowarefoundation#3662) (#482)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request May 16, 2023
…e unavoidable (autowarefoundation#3662) (autowarefoundation#482)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
@satoshi-ota satoshi-ota deleted the fix/clear-waiting-approval-avoidance branch May 30, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants