-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): clear waiting approval only when all target module are unavoidable #3662
Merged
kosuke55
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:fix/clear-waiting-approval-avoidance
May 11, 2023
Merged
fix(avoidance): clear waiting approval only when all target module are unavoidable #3662
kosuke55
merged 1 commit into
autowarefoundation:main
from
satoshi-ota:fix/clear-waiting-approval-avoidance
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unavoidable Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3662 +/- ##
==========================================
- Coverage 14.72% 14.72% -0.01%
==========================================
Files 1298 1298
Lines 92512 92519 +7
Branches 29309 29312 +3
==========================================
Hits 13619 13619
- Misses 64113 64120 +7
Partials 14780 14780
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
May 10, 2023 23:07
kosuke55
approved these changes
May 11, 2023
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2023
…e unavoidable (autowarefoundation#3662) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
7 tasks
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2023
…e unavoidable (autowarefoundation#3662) (#482) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
May 16, 2023
…e unavoidable (autowarefoundation#3662) (autowarefoundation#482) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onProcessEntry()
.Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.