feat(map_based_prediciton): consider y component of the velocity vector #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
github-actions
bot
added
the
component:perception
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
YoshiRi
requested review from
miursh,
tkimura4 and
purewater0901
as code owners
takayuki5168
approved these changes
Aug 28, 2023
YoshiRi
added
the
tag:run-build-and-test-differential
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
==========================================
- Coverage 15.11% 15.06% -0.05%
==========================================
Files 1563 1563
Lines 107835 108169 +334
Branches 33061 33061
==========================================
Hits 16296 16296
- Misses 73803 74137 +334
Partials 17736 17736
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 30, 2023
…or (autowarefoundation#4728) * consider y component of the velocity vector Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * uncomment compensateTimeDelay function because it is not used Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 7, 2023
…or (autowarefoundation#4728) * consider y component of the velocity vector Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * uncomment compensateTimeDelay function because it is not used Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…or (autowarefoundation#4728) * consider y component of the velocity vector Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * uncomment compensateTimeDelay function because it is not used Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 26, 2023
…or (autowarefoundation#4728) * consider y component of the velocity vector Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * uncomment compensateTimeDelay function because it is not used Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 25, 2023
…or (autowarefoundation#4728) * consider y component of the velocity vector Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * uncomment compensateTimeDelay function because it is not used Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4637, map_based_prediction package also need to consider vy component of the velocity.
Most of changes is conversion from abs(vx) to hypot(vx, vy).
Tests performed
Tested with Psim.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.