Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add jerk and acc limits for slow-down #5810

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Dec 7, 2023

Description

🤖[deprecated] Generated by Copilot at f95a0b7

This pull request adds new parameters and variables for the slow down mode of the obstacle cruise planner. The slow down mode is used to avoid collisions with obstacles by smoothly reducing the ego vehicle speed. The new parameters and variables allow tuning the minimum deceleration and jerk values for the slow down mode.

Usually, the min_jerk and min_acc values are tuned to low values for a comfortable driving experience. However, if said values are too low, it is possible that the cruise_planner's slow down cannot be used when the vehicle is travelling at highers speeds (the slow down requires a bigger jerk and/or acceleration limit). This PR adds parameters to customize the minimum jerk and acc used specifically for slow down.

Related links

ticket: TIER IV INTERNAL LINK

Tests performed

Simulations on PSim to check the effect of the changes.

Notes for reviewers

Requires this PR(launch) to be merged as well: autowarefoundation/autoware_launch#726

Interface changes

Added a min_acc and min_jerk parameter for obstacle_cruise_planner slow_down

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 7, 2023
@danielsanchezaran danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 7, 2023
@danielsanchezaran danielsanchezaran marked this pull request as ready for review December 8, 2023 00:14
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (f95a0b7) 8.39%.
Report is 174 commits behind head on main.

Files Patch % Lines
...include/obstacle_cruise_planner/common_structs.hpp 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5810       +/-   ##
==========================================
- Coverage   15.32%   8.39%    -6.93%     
==========================================
  Files        1721      18     -1703     
  Lines      118559    2286   -116273     
  Branches    37995    1235    -36760     
==========================================
- Hits        18169     192    -17977     
+ Misses      79657    1759    -77898     
+ Partials    20733     335    -20398     
Flag Coverage Δ
differential 8.39% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit f41d3fa into autowarefoundation:main Dec 11, 2023
35 of 39 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add-slow-down-jerk-acc-min branch December 11, 2023 01:55
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2023
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5810)

Add jerk and acc limits for slow-down

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants