-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): add jerk and acc limits for slow-down #5810
Merged
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/add-slow-down-jerk-acc-min
Dec 11, 2023
Merged
feat(obstacle_cruise_planner): add jerk and acc limits for slow-down #5810
danielsanchezaran
merged 1 commit into
autowarefoundation:main
from
tier4:feat/add-slow-down-jerk-acc-min
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 7, 2023
danielsanchezaran
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 7, 2023
danielsanchezaran
requested review from
kosuke55,
satoshi-ota and
takayuki5168
as code owners
December 8, 2023 00:14
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5810 +/- ##
==========================================
- Coverage 15.32% 8.39% -6.93%
==========================================
Files 1721 18 -1703
Lines 118559 2286 -116273
Branches 37995 1235 -36760
==========================================
- Hits 18169 192 -17977
+ Misses 79657 1759 -77898
+ Partials 20733 335 -20398
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Dec 11, 2023
danielsanchezaran
merged commit Dec 11, 2023
f41d3fa
into
autowarefoundation:main
35 of 39 checks passed
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 20, 2023
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at f95a0b7
This pull request adds new parameters and variables for the slow down mode of the obstacle cruise planner. The slow down mode is used to avoid collisions with obstacles by smoothly reducing the ego vehicle speed. The new parameters and variables allow tuning the minimum deceleration and jerk values for the slow down mode.
Usually, the min_jerk and min_acc values are tuned to low values for a comfortable driving experience. However, if said values are too low, it is possible that the cruise_planner's slow down cannot be used when the vehicle is travelling at highers speeds (the slow down requires a bigger jerk and/or acceleration limit). This PR adds parameters to customize the minimum jerk and acc used specifically for slow down.
Related links
ticket: TIER IV INTERNAL LINK
Tests performed
Simulations on PSim to check the effect of the changes.
Notes for reviewers
Requires this PR(launch) to be merged as well: autowarefoundation/autoware_launch#726
Interface changes
Added a min_acc and min_jerk parameter for obstacle_cruise_planner slow_down
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.