fix(autoware_behavior_velocity_planner_common): remove lane_id check from arc_lane_util #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki
requested review from
kosuke55,
shmpwk,
tkimura4,
rej55,
isamu-takagi,
soblin and
kyoichi-sugahara
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
tag:run-build-and-test-differential
soblin
approved these changes
Jun 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7710 +/- ##
===========================================
+ Coverage 14.84% 16.81% +1.96%
===========================================
Files 1999 486 -1513
Lines 139163 38889 -100274
Branches 43716 10368 -33348
===========================================
- Hits 20661 6539 -14122
+ Misses 95731 31473 -64258
+ Partials 22771 877 -21894
☔ View full report in Codecov by Sentry. |
yhisaki
changed the title
kyoichi-sugahara
approved these changes
Jun 26, 2024
kosuke55
approved these changes
Jun 27, 2024
rej55
approved these changes
Jun 27, 2024
mitukou1109
pushed a commit
to mitukou1109/autoware.universe
that referenced
this pull request
Jul 2, 2024
…from arc_lane_util (autowarefoundation#7710) * fix(arc_lane_util): remove lane_id check from arc_lane_util Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * modify test_arc_lane_util.cpp Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki
added a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 8, 2024
…d check from arc_lane_util (autowarefoundation#7710)" This reverts commit be02771.
This was referenced Jul 8, 2024
yhisaki
added a commit
to yhisaki/autoware.universe
that referenced
this pull request
Jul 8, 2024
…d check from arc_lane_util (autowarefoundation#7710)" This reverts commit be02771.
yhisaki
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 8, 2024
…d check from arc_lane_util (autowarefoundation#7710)" This reverts commit be02771.
palas21
pushed a commit
to palas21/autoware.universe
that referenced
this pull request
Jul 12, 2024
…from arc_lane_util (autowarefoundation#7710) * fix(arc_lane_util): remove lane_id check from arc_lane_util Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * modify test_arc_lane_util.cpp Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel
pushed a commit
to tby-udel/autoware.universe
that referenced
this pull request
Jul 14, 2024
…from arc_lane_util (autowarefoundation#7710) * fix(arc_lane_util): remove lane_id check from arc_lane_util Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * modify test_arc_lane_util.cpp Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…from arc_lane_util (#7710) * fix(arc_lane_util): remove lane_id check from arc_lane_util Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> * modify test_arc_lane_util.cpp Signed-off-by: Y.Hisaki <yhisaki31@gmail.com> --------- Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when checking the intersection of stop_line and path, it was checked if the lane_id of the intersection is the same as the one specified. However, this check is meaningless and may cause the following error. Therefore, the code to check the lane_id has been removed.
https://tier4.atlassian.net/browse/RT0-30839
How was this PR tested?
https://evaluation.ci.tier4.jp/evaluation/reports/6f5f6e7c-1d11-5ca3-b5cd-f89ac8fca216?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.