Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_velocity_planner_common,autoware_behavior_velocity_stop_line_module): revert pr7710 and Check next_lane_id in createTargetPoint on stop line #1396

Closed

Conversation

yhisaki
Copy link

@yhisaki yhisaki commented Jul 8, 2024

Description

  • revert this PR
  • make createTargetPoint's lane_id argument to lane_ids vector
  • Check next_lane_id in createTargetPoint on stop line

Tests performed

tested on psim

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

takayuki5168 and others added 30 commits June 30, 2024 20:14
…cessing time

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
…towarefoundation#7814)

* fix(radar_fusion_to_detected_object): fix knownConditionTrueFalse

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* inline suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
…on (autowarefoundation#7835)

* fix(autoware_behavior_velocity_intersection_module): fix shadowFunction

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…lanner (autowarefoundation#7836)

add diagnostics publishing to cruise planner

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…ion#7838)

* fix(diagnostic_graph_aggregator): fix shadowFunction

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* feat: modify variable name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…n between pose and lane (autowarefoundation#7828)

* fix(safety_check): filter by yaw deviation to check object belongs to lane

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): check yaw only when the object is moving

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…oundation#7791)

* feat(goal_planner): prioritize pull over path by curvature

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

fix

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add comment

* pre commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
… logic (autowarefoundation#7830)

* fix(static_obstacle_avoidance): check if object is inside/outside by its position point instead of its polygon

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(static_obstacle_avoidance): add getter functions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): check next lane without route if the current lane is not preferred

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(static_obstacle_avoidance): fix parked vehicle check

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
…tory structure (autowarefoundation#7748)

chore: update namespace and file structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…n#7757)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…ry structure (autowarefoundation#7739)

refactor: namespace fix, rename file names, move header to src



refactor: update PLUGIN namespace in CMakeLists.txt

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…n#7837)

* refactor based on linter

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* style(pre-commit): autofix

* Update map/map_height_fitter/src/map_height_fitter.cpp

fix to used angle brackets for including

Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
…velocity (autowarefoundation#7810)

refactor external velocity

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…foundation#7843)

add getLeftOppositeLanelers in getAdjacentLane function

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
…efoundation#7786)

* fix(pointcloud_preprocessor): fix preprocessorErrorDirective

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* fix postfixOperator

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* remove unnecessary count() and contains()

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* restore bitness macros

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>

* remove operator=

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>

* remove addOrFree function

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>

* add cppcheck suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* add cppcheck suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* add cppcheck suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* add cppcheck suppression

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
…on#7848)

chore(ci): remove unnecessary suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
…autowarefoundation#7846)

fix control evaluator plugin name

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.