Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trajectory_follower_nodes): mpc_follower does not send proper converged data under low steering rate limit #378

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 31, 2023

Description

launcher update for autowarefoundation/autoware.universe#2454

Related links

Tests performed

I checked psim and tier4 internal scenario test (1326/1372->1329/1372), and it worked fine.

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…verged data under low steering rate limit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Member

@brkay54 brkay54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brkay54 brkay54 merged commit e566355 into main Jun 2, 2023
@brkay54 brkay54 deleted the mpc-converged branch June 2, 2023 09:31
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…owarefoundation#670) (autowarefoundation#378)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 10, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants