Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(system_error_monitor): check lateral deviation in sim #516

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 15, 2023

Description

check lateral deviation in sim.
I would like to use this diag topic in evaluator with diagnostic_converter.

Tests performed

Psim

Effects on system behavior

output error diag if the ego is far from trajectory.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit b84b8cb into main Aug 15, 2023
12 of 13 checks passed
@satoshi-ota satoshi-ota deleted the feat/check-lateral-deviation branch August 15, 2023 01:59
kyoichi-sugahara pushed a commit that referenced this pull request Aug 15, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara added a commit that referenced this pull request Aug 15, 2023
…tory (#509)

* update launcher

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add config and modify launch file

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* feat(lane_departure_checker): add road_border departure checker (#511)

add param

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* feat(system_error_monitor): check lateral deviation in sim (#516)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* restore rviz config change

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
* fix: longitudinal_controller_mode arg

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* feat: add longitudinal controller arg

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
* fix: longitudinal_controller_mode arg

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* feat: add longitudinal controller arg

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
chore: sync awf/autoware_launch
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Oct 23, 2023
…dation#516)

fix stop_duration_sec param

Signed-off-by: scepter914 <scepter914@gmail.com>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
fix stop_duration_sec param

Signed-off-by: scepter914 <scepter914@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants