Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): expand target lanes for object filtering #601

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Add lane expansion parameters and logic for object filtering in lane change module. This improves safety check by allowing user to determine if they want to consider slightly out of lane object as target.

Note:
Purple cube: other lane object
Aqua cube: target lane object
Yellow cube: current lane object

Before PR

Screenshot from 2023-09-28 12-25-45

After PR

Left Expansion with additional 1 m

Screenshot from 2023-09-28 12-29-05

Left Expansion with additional 10 m

Screenshot from 2023-09-28 12-30-38

Right Expansion

Screenshot from 2023-09-28 12-38-00

Related links

autowarefoundation/autoware.universe#5167

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit da1cfda into main Oct 2, 2023
9 of 10 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the feat-lc-object-filter-expanded-lanes branch October 2, 2023 01:55
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…undation#601)

* feat(autoware_launch): visualize multiple candidate paths

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feature(autoware_launch): fix name space in autoware.rviz

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Oct 23, 2023
…foundation#601)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants