Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add param file for obstacle pointcloud based validator #606

Conversation

badai-nguyen
Copy link
Contributor

Description

This PR add param file for #5177 and should merge together with those PR.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the fix/add_param_file_obstacle_pointcloud_based_validator branch from 9d83654 to 981489f Compare October 2, 2023 00:29
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit 811307d into autowarefoundation:main Oct 5, 2023
8 of 9 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
* feat: launch diagnostic graph converter tool

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* feat: launch diagnostic graph converter tool

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix comments

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants