Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module #730

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Dec 11, 2023

Description

Add parameter file for a new behavior_velocity_planner module.
Required for autowarefoundation/autoware.universe#5835

Tests performed

PSim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/36edca70-1018-5410-9957-4412db637bbc?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem changed the title feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module Dec 11, 2023
@maxime-clem maxime-clem force-pushed the feat/dynamic_obstacle_stop branch 3 times, most recently from 52e99ee to cb91237 Compare December 13, 2023 04:53
maxime-clem and others added 9 commits December 18, 2023 13:41
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit d7e2d5d.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxime-clem Please add launch flag in default_preset.yaml.

  # behavior velocity modules
  - arg:
      name: launch_crosswalk_module
      default: "true"
...

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
Copy link
Contributor Author

@satoshi-ota

Please add launch flag in default_preset.yaml.

Done: d83fbda

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
@maxime-clem maxime-clem merged commit daea9fc into autowarefoundation:main Jan 10, 2024
12 of 13 checks passed
@maxime-clem maxime-clem deleted the feat/dynamic_obstacle_stop branch January 10, 2024 02:31
maxime-clem added a commit to maxime-clem/autoware_launch that referenced this pull request Jan 11, 2024
…le (autowarefoundation#730)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware_launch that referenced this pull request Jan 11, 2024
…le (#267)

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module (autowarefoundation#730)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants