-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(log-messages): reduce excessive log messages #760
Merged
xmfcx
merged 1 commit into
autowarefoundation:main
from
ahmeddesokyebrahim:autoware/launch/5539-fix-log-messages
Feb 12, 2024
Merged
fix(log-messages): reduce excessive log messages #760
xmfcx
merged 1 commit into
autowarefoundation:main
from
ahmeddesokyebrahim:autoware/launch/5539-fix-log-messages
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmeddesokyebrahim
changed the title
fix(log-messages): Reduce excessive error and warning logs on Autoware launch
fix(log-messages): Reduce excessive logs messages in Autoware
Dec 26, 2023
ahmeddesokyebrahim
changed the title
fix(log-messages): Reduce excessive logs messages in Autoware
fix(log-messages): Reduce excessive log messages in Autoware
Dec 26, 2023
This was referenced Dec 26, 2023
7 tasks
ahmeddesokyebrahim
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
2 times, most recently
from
January 19, 2024 14:47
51c5470
to
f16098e
Compare
ahmeddesokyebrahim
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
from
January 22, 2024 14:44
f16098e
to
29c754e
Compare
ahmeddesokyebrahim
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
from
February 2, 2024 11:41
29c754e
to
7d3cff4
Compare
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
ahmeddesokyebrahim
changed the title
fix(log-messages): Reduce excessive log messages in Autoware
fix(log-messages): reduce excessive log messages
Feb 7, 2024
ahmeddesokyebrahim
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
from
February 7, 2024 01:45
7d3cff4
to
885b59a
Compare
xmfcx
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
from
February 7, 2024 11:25
885b59a
to
ebbfac3
Compare
…updater: No HW_ID was set..." Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
ahmeddesokyebrahim
force-pushed
the
autoware/launch/5539-fix-log-messages
branch
from
February 12, 2024 05:59
ebbfac3
to
895fd96
Compare
3 tasks
xmfcx
approved these changes
Feb 12, 2024
Merging this as |
This was referenced Feb 12, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.
Related links
Part of:
Relevant PRS
Tests performed
Notes for reviewers
Take into consideration relevant PRs.
🔴 Merge Dependency 🔴
❗ It will be risky if this PR got merged before autoware.universe due to the deletion of a parameter that can be not found by current autoware.universe ❗
Interface changes
N.A
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.