Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-messages): reduce excessive log messages #760

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Dec 26, 2023

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Related links

Part of:

Relevant PRS

Tests performed

  • Planning Simulation
    • Run Autoware planning simulator and you can see no more excessive and recurring error, warning, and info message when the system running as expected
  • Rosbag Replay Simulation
    • To be addressed in another PR
  • AWSIM
    • To be addressed in another PR - extended goal

Notes for reviewers

Take into consideration relevant PRs.

🔴 Merge Dependency 🔴
❗ It will be risky if this PR got merged before autoware.universe due to the deletion of a parameter that can be not found by current autoware.universe ❗

Interface changes

N.A

Effects on system behavior

  • Improved console output => better developer experience specially for debugging and catching actual problems.
  • Some recurrent info messages are lowered to debug level. So the developer would need to set the logger level of that specific node to see the debug message.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Dec 26, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title fix(log-messages): Reduce excessive error and warning logs on Autoware launch fix(log-messages): Reduce excessive logs messages in Autoware Dec 26, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title fix(log-messages): Reduce excessive logs messages in Autoware fix(log-messages): Reduce excessive log messages in Autoware Dec 26, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/5539-fix-log-messages branch 2 times, most recently from 51c5470 to f16098e Compare January 19, 2024 14:47
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/5539-fix-log-messages branch from f16098e to 29c754e Compare January 22, 2024 14:44
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/5539-fix-log-messages branch from 29c754e to 7d3cff4 Compare February 2, 2024 11:41
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title fix(log-messages): Reduce excessive log messages in Autoware fix(log-messages): reduce excessive log messages Feb 7, 2024
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/launch/5539-fix-log-messages branch from 7d3cff4 to 885b59a Compare February 7, 2024 01:45
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review February 7, 2024 01:59
@xmfcx xmfcx force-pushed the autoware/launch/5539-fix-log-messages branch from 885b59a to ebbfac3 Compare February 7, 2024 11:25
…updater: No HW_ID was set..."

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@xmfcx
Copy link
Contributor

xmfcx commented Feb 12, 2024

@xmfcx xmfcx merged commit 1a31b4b into autowarefoundation:main Feb 12, 2024
11 of 12 checks passed
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants