Skip to content

Commit

Permalink
Default priorityClassName to blank string (#253)
Browse files Browse the repository at this point in the history
Issue #, if available:
Relates #249
Relates #252

Description of changes:
This fixes a bug I introduced in a previous PR (sorry!)
This must default to an empty string rather than null or you get:
```
Error: values don't meet the specifications of the schema(s) in the following chart(s):
s3-chart:
- deployment.priorityClassName: Invalid type. Expected: string, given: null

```

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
philnichol authored Dec 27, 2021
1 parent 60b04fe commit fd2fda0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/helm/values.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ deployment:
affinity: {}
# Which priorityClassName to set?
# See: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#pod-priority
priorityClassName:
priorityClassName: ""

metrics:
service:
Expand Down

0 comments on commit fd2fda0

Please sign in to comment.