Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default priorityClassName to blank string #253

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Default priorityClassName to blank string #253

merged 1 commit into from
Dec 27, 2021

Conversation

philnichol
Copy link
Contributor

Issue #, if available:
Relates #249
Relates #252

Description of changes:
This fixes a bug I introduced in a previous PR (sorry!)
This must default to an empty string rather than null or you get:

Error: values don't meet the specifications of the schema(s) in the following chart(s):
s3-chart:
- deployment.priorityClassName: Invalid type. Expected: string, given: null

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 24, 2021

Hi @philnichol. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 24, 2021
@RedbackThomson
Copy link
Contributor

All good. Thanks

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philnichol, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit fd2fda0 into aws-controllers-k8s:main Dec 27, 2021
@philnichol philnichol deleted the fix-helm-default-value branch December 27, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants