Adds helm schema validation #252
Conversation
|
Hi @philnichol. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-bot
added
the
needs-ok-to-test
|
/assign @RedbackThomson |
Signed-off-by: Phil Nichol <35630607+philnichol@users.noreply.github.com>
|
@RedbackThomson thanks for the speedy review 😃 , have pushed a commit that hopefully addresses your comments |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philnichol, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: Relates #249 Relates #252 Description of changes: This fixes a bug I introduced in a previous PR (sorry!) This must default to an empty string rather than null or you get: ``` Error: values don't meet the specifications of the schema(s) in the following chart(s): s3-chart: - deployment.priorityClassName: Invalid type. Expected: string, given: null ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
Closes aws-controllers-k8s/community#899
Description of changes:
This adds a JSON schema to validate inputs to the helm chart, so that values of an incorrect type, regex or enumeration will fail quickly, rather than after the helm deployment runs.
Please let me know if I've missed any of the enum options.
Also worth noting that regarding the types, this will break functionality for anyone using
"true","false",1,0as a boolean or"42"as an integer, so let me know if you want those added as additional options to those fields.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.