Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate aws-sdk-go/$service import #102

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

a-hilaly
Copy link
Member

Remove duplicate aws-sdk-go/$service import. It is already imported in L14 with the alias svcsdk

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member Author

Also in other files the svcsdkapi is used as alias for imports similar to "github.com/aws/aws-sdk-go/service/{{ .ServiceIDClean }}/{{ .ServiceIDClean }}iface"

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit ece6139 into aws-controllers-k8s:main Jun 23, 2021
ack-bot pushed a commit that referenced this pull request Jun 23, 2021
Description of changes:
Add the missing `ReplaceConditions` method introduced in aws-controllers-k8s/runtime#24 .
Fix a import path error introduced in #102

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson pushed a commit to RedbackThomson/ack-code-generator that referenced this pull request Jun 24, 2021
Remove duplicate `aws-sdk-go/$service` import. It is already imported in L14 with the alias `svcsdk`

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson added a commit to RedbackThomson/ack-code-generator that referenced this pull request Jun 24, 2021
Description of changes:
Add the missing `ReplaceConditions` method introduced in aws-controllers-k8s/runtime#24 .
Fix a import path error introduced in aws-controllers-k8s#102

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants