Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing replace conditions method #104

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

RedbackThomson
Copy link
Contributor

Description of changes:
Add the missing ReplaceConditions method introduced in aws-controllers-k8s/runtime#24 .
Fix a import path error introduced in #102

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and jaypipes June 23, 2021 18:26
@vijtrip2
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 85e4aa7 into aws-controllers-k8s:main Jun 23, 2021
@RedbackThomson RedbackThomson deleted the fix-sdkapi-import branch June 23, 2021 19:05
@jaypipes
Copy link
Collaborator

@RedbackThomson @vijtrip2 remember to do a release of the ACK runtime before PRs like this and then update the go.mod file in code-generator to reference the new ACK runtime release. No worries on this one, but just for future reference... I'm pushing up a PR that updates the go.mod and the pinned runtime_test.go file and then I'll cut a new code-generator release v0.3.0 to match the ACK runtime.

RedbackThomson added a commit to RedbackThomson/ack-code-generator that referenced this pull request Jun 24, 2021
Description of changes:
Add the missing `ReplaceConditions` method introduced in aws-controllers-k8s/runtime#24 .
Fix a import path error introduced in aws-controllers-k8s#102

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants