add common ACK pkg/condition #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
force-pushed
the
common-condition-handlers
branch
from
4db22b4 to
90242d8
Compare
|
/approve |
a-hilaly
reviewed
Jun 21, 2021
pkg/types/manages_conditions.go
Outdated
|
|
||
| // ManagesConditions describes a thing that can set and retrieve Condition | ||
| // objects. | ||
| type ManagesConditions interface { |
There was a problem hiding this comment.
nit: s/ManagesConditions/ConditionsManager/
There was a problem hiding this comment.
nit: s/
ManagesConditions/ConditionsManager/
@a-hilaly @RedbackThomson fine, changed the name :)
|
/approve |
Adds common resource condition functions to a new `pkg/condition`:
- `Synced()` returns the resource's Condition of type
ConditionTypeResourceSynced, or nil if the condition isn't found.
- `Terminal()` returns the resource's Condition of type
ConditionTypeTerminal, or nil if the condition isn't found.
- `FirstOfType()` returns the first Condition of the specified type, or
nil if a condition of the type isn't found on the resource.
- `AllOfType()` returns a slice of `Condition` having the specified
condition type.
- `SetSynced()` ensures that a Condition of type
ConditionTypeResourceSynced is present in the resource's Conditions
collection and has a specified status, message and reason
- `SetTerminal()` ensures that a Condition of type
ConditionTypeResourceTerminal is present in the resource's Conditions
collection and has a specified status, message and reason
IMPORTANT COMPATIBILITY NOTE:
Note that the `pkg/types.AWSResource` interface has been modified to be
a composition of a new `pkg/types.ConditionManager` interface which
adds a new `ReplaceConditions()` method that overwrites a resource's
Conditions collection. This is a backwards-incompatible change since the
`pkg/types.AWSResource` implementations generated by
`aws-controllers-k8s/code-generator` (the `pkg/{RESOURCE/resource.go`
files...}) will not include this new `ReplaceConditions` implementation
and thus won't compile if you attempt to regenerate a controller using
the ACK runtime after this patch is merged. A corresponding patch to the
code-generator is coming that adds the `ReplaceCondiions`
implementation.
jaypipes
force-pushed
the
common-condition-handlers
branch
from
90242d8 to
b3e167d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Jun 23, 2021
Description of changes: Add the missing `ReplaceConditions` method introduced in aws-controllers-k8s/runtime#24 . Fix a import path error introduced in #102 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
RedbackThomson
added a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jun 24, 2021
Description of changes: Add the missing `ReplaceConditions` method introduced in aws-controllers-k8s/runtime#24 . Fix a import path error introduced in aws-controllers-k8s#102 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds common resource condition functions to a new
pkg/condition:Synced()returns the resource's Condition of typeConditionTypeResourceSynced, or nil if the condition isn't found.
Terminal()returns the resource's Condition of typeConditionTypeTerminal, or nil if the condition isn't found.
FirstOfType()returns the first Condition of the specified type, ornil if a condition of the type isn't found on the resource.
AllOfType()returns a slice ofConditionhaving the specifiedcondition type.
SetSynced()ensures that a Condition of typeConditionTypeResourceSynced is present in the resource's Conditions
collection and has a specified status, message and reason
SetTerminal()ensures that a Condition of typeConditionTypeResourceTerminal is present in the resource's Conditions
collection and has a specified status, message and reason
IMPORTANT COMPATIBILITY NOTE:
Note that the
pkg/types.AWSResourceinterface has been modified to bea composition of a new
pkg/types.ConditionManagerinterface whichadds a new
ReplaceConditions()method that overwrites a resource'sConditions collection. This is a backwards-incompatible change since the
pkg/types.AWSResourceimplementations generated byaws-controllers-k8s/code-generator(thepkg/{RESOURCE/resource.gofiles...}) will not include this new
ReplaceConditionsimplementationand thus won't compile if you attempt to regenerate a controller using
the ACK runtime after this patch is merged. A corresponding patch to the
code-generator is coming that adds the
ReplaceCondiionsimplementation.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.