Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Add gcc_quoting_for_param_files feature (#314)" #321

Merged

Conversation

brentleyjones
Copy link
Collaborator

@brentleyjones brentleyjones commented Apr 1, 2024

This reverts commit cf271a3.

This adds a dependency on bazel_features in order to know when it's safe to enable gcc_quoting_for_param_files by default.

@brentleyjones brentleyjones force-pushed the bj/reapply-add-gcc_quoting_for_param_files-feature-314 branch from 2f1c481 to f5a8a26 Compare April 18, 2024 20:39
@brentleyjones
Copy link
Collaborator Author

I'm not sure on the apple_support_extra_dependencies abstraction. Probably better to just have the bazel_features_deps() call listed in our snippet, similar to the rules_xcodeproj instructions. Also, it's technically a breaking change to add this for WORKSPACE users, but similar to how we handled it in rules_swift, we won't be upgrading the major version for this.

Signed-off-by: Brentley Jones <github@brentleyjones.com>
This reverts commit cf271a3.

Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones force-pushed the bj/reapply-add-gcc_quoting_for_param_files-feature-314 branch from f5a8a26 to c4c33dd Compare April 25, 2024 20:49
@brentleyjones
Copy link
Collaborator Author

Now I just need to remember to add a note in the release notes.

@brentleyjones brentleyjones merged commit c3666ff into master Apr 26, 2024
11 checks passed
@brentleyjones brentleyjones deleted the bj/reapply-add-gcc_quoting_for_param_files-feature-314 branch April 26, 2024 14:16
@keith
Copy link
Member

keith commented May 4, 2024

I think you'll need to update this too: https://github.com/bazelbuild/apple_support/blob/master/.github/generate-notes.sh

@brentleyjones
Copy link
Collaborator Author

#329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants