Add gcc_quoting_for_param_files feature
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirrors bazelbuild/bazel@bd2da6e. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Mar 19, 2024
brentleyjones
added a commit
that referenced
this pull request
Apr 1, 2024
This reverts commit 4df4418. Until `dsym_path` is no longer incorrectly quoted by Bazel.
brentleyjones
added a commit
that referenced
this pull request
Apr 1, 2024
This reverts commit 4df4418. Until `dsym_path` is no longer incorrectly quoted by Bazel, or we have a workaround in place.
brentleyjones
added a commit
that referenced
this pull request
Apr 1, 2024
This reverts commit cf271a3. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
added a commit
that referenced
this pull request
Apr 18, 2024
This reverts commit cf271a3. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit cf271a3. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
added a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit cf271a3. This adds a dependency on **bazel_features** in order to know when it's safe to enable `gcc_quoting_for_param_files` by default. --------- Signed-off-by: Brentley Jones <github@brentleyjones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors bazelbuild/bazel@bd2da6e.