-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make UI text rendering camera driven #13697
make UI text rendering camera driven #13697
Conversation
Side-question (this PR seems useful regardless): should Bevy promote another |
I tried that at first (if there is no primary window, promote the first window to it) because it seemed simpler, but that didn't work nicely. Do you despawn cameras that are targeting the primary window with the primary window? We should have an answer for that, but that need more design... |
Yeah, it feels like something the user should manage to me. I would imagine that most of the time, users would not want to allow the primary window to be despawned in the first place. Just surfacing the idea because it seemed like an "obvious" fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this done across the UI stack: multi-window UI is the primary consumer of multiple windows.
let's discuss in #13698 |
Objective
Solution
PrimaryWIndow
There are other parts of UI that are still
PrimaryWindow
dependent, if the changes here are OK I'll apply them everywhere.I'm not a fan of the
EntityHashMap
here to hold the scale factors, but it seems the quick and easy fixTesting
multiple_windows
on a screen with a scale factor different than 1, close the primary window