Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global app name and repo #103 #192

Merged
merged 5 commits into from
Feb 18, 2021
Merged

add global app name and repo #103 #192

merged 5 commits into from
Feb 18, 2021

Conversation

MordRot
Copy link
Contributor

@MordRot MordRot commented Feb 16, 2021

Use repo name and URL from package.config #103

@baruchiro
Copy link
Collaborator

@MordRot Please see my comments.

Also, if you know about things that should be changed after changing the repository path, I will appreciate if you can list them in #140

baruchiro
baruchiro approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a problem in ElectronBuilder, not related to you, I will check it later.

baruchiro
baruchiro reviewed Feb 17, 2021
View reviewed changes
vue.config.js Outdated Show resolved Hide resolved
baruchiro
baruchiro reviewed Feb 18, 2021
View reviewed changes
vue.config.js Outdated Show resolved Hide resolved
baruchiro
baruchiro reviewed Feb 18, 2021
View reviewed changes
vue.config.js Outdated Show resolved Hide resolved
@baruchiro baruchiro linked an issue Feb 18, 2021 that may be closed by this pull request
Use repo name and URL from package.config #103
Closed
@baruchiro baruchiro merged commit fc70a7b into brafdlog:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use repo name and URL from package.config
2 participants
@MordRot @baruchiro