Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use repo name and URL from package.config #103

Closed
baruchiro opened this issue Sep 15, 2020 · 3 comments · Fixed by #192 or #269
Closed

Use repo name and URL from package.config #103

baruchiro opened this issue Sep 15, 2020 · 3 comments · Fixed by #192 or #269
Labels
good first issue Good for newcomers

Comments

@baruchiro
Copy link
Collaborator

Instead of using the budget-tracking or https://github.com/brafdlog/budget-tracking in many places in the log, we need to declare them once and use the variable all over the code.

It can be implemented by Webpack DefinePlugin or import { name } from 'package.json.
@baruchiro baruchiro mentioned this issue Sep 15, 2020
Closed
brafdlog pushed a commit that referenced this issue Dec 22, 2020
@baruchiro
Merge pull request #103 from baruchiro/dependabot/npm_and_yarn/vuetif…
a783bd5 
…y-2.2.12

Bump vuetify from 2.2.11 to 2.2.12
@baruchiro baruchiro added the good first issue Good for newcomers label Feb 4, 2021
@baruchiro baruchiro mentioned this issue Feb 6, 2021
Closed
@baruchiro
Copy link
Collaborator Author

Please also update with the new name: "Hiuvi".

See #140 and #139 (reply in thread)

@baruchiro baruchiro assigned baruchiro and unassigned baruchiro Feb 6, 2021
@baruchiro
Copy link
Collaborator Author

https://github.com/brafdlog/budget-tracking/blob/e9e3159981fa67c7b97f74a013e609f23f61efa8/src/ui/components/App.vue#L53

https://github.com/brafdlog/budget-tracking/blob/e9e3159981fa67c7b97f74a013e609f23f61efa8/src/main.ts#L33

https://github.com/brafdlog/budget-tracking/blob/e9e3159981fa67c7b97f74a013e609f23f61efa8/src/ui/components/App.vue#L10

MordRot added a commit to MordRot/budget-tracking that referenced this issue Feb 16, 2021
@MordRot
add global app name and repo brafdlog#103
e19337c
@MordRot MordRot mentioned this issue Feb 16, 2021
Merged
@baruchiro baruchiro removed their assignment Feb 16, 2021
MordRot added a commit to MordRot/budget-tracking that referenced this issue Feb 16, 2021
@MordRot
Fixes in using repo URL from package.config brafdlog#103
ca7f92a
MordRot added a commit to MordRot/budget-tracking that referenced this issue Feb 17, 2021
@MordRot
use app name from package.json instead from globals. brafdlog#103
d433cba
@baruchiro baruchiro linked a pull request Feb 18, 2021 that will close this issue
add global app name and repo #103 #192
Merged
baruchiro added a commit that referenced this issue Feb 18, 2021
@baruchiro
Merge pull request #192 from MordRot/use_repo_url_from_package_config…
fc70a7b 
…_#103

add global app name and repo #103
@baruchiro
Copy link
Collaborator Author

Reopen: rename to כספיון
#139 (comment)

@baruchiro baruchiro reopened this Jun 22, 2021
@brafdlog brafdlog linked a pull request Jun 22, 2021 that will close this issue
Rename hiuvi -> Caspion #269
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@baruchiro