Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a name for the app and update the code #140

Closed
brafdlog opened this issue Dec 16, 2020 · 6 comments · Fixed by #245 or #269
Closed

Choose a name for the app and update the code #140

brafdlog opened this issue Dec 16, 2020 · 6 comments · Fixed by #245 or #269
Assignees

Comments

@brafdlog
Copy link
Owner

brafdlog commented Dec 16, 2020

Choose a name for the app and update the code to that name.

Related discussion #139

@brafdlog brafdlog changed the title App name and logo Choose a name for the app and update the code Dec 17, 2020
brafdlog pushed a commit that referenced this issue Dec 22, 2020
@baruchiro
Copy link
Collaborator

I think the real work is by #103

@brafdlog I suggest changing the repo name. Don't worry, Github will redirect the old URL to the new one for a time.

@MordRot
Copy link
Contributor

MordRot commented Feb 16, 2021

In a future change of the app name, public\index.html will need to be changed:
https://github.com/brafdlog/budget-tracking/blob/e19337c67da60e1eedd6f15405c12561280dbe12/public/index.html#L8

The repository path will need to be updated in few places that currently use old URL and email:
docs\share-spreadsheet.md
.github\workflows\release.yml

@baruchiro
Copy link
Collaborator

Also, of course, the repo path in the package.json should be updated.

@MordRot
Copy link
Contributor

MordRot commented Feb 16, 2021

And app name in: globals.js

@baruchiro
Copy link
Collaborator

@brafdlog Please change the repo name.
Don't worry, it will redirect the current URL to the new one for some time. (AFAIK)

@baruchiro
Copy link
Collaborator

Reopen: rename to כספיון
#139 (comment)

@baruchiro baruchiro reopened this Jun 22, 2021
@brafdlog brafdlog linked a pull request Jun 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants